| Message ID | 20190507182409.GA11027@embeddedor (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 0981949da8f7498b96c6e0ae60680865ca283bf1 |
| Headers | show |
| Series | Input: libps2 - mark expected switch fall-through | expand |
On Tue, May 07, 2019 at 01:24:09PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warning: > > drivers/input/serio/libps2.c: In function ‘ps2_handle_ack’: > drivers/input/serio/libps2.c:407:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > if (ps2dev->flags & PS2_FLAG_NAK) { > ^ > drivers/input/serio/libps2.c:417:2: note: here > case 0x00: > ^~~~ > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > This patch is part of the ongoing efforts to enable > -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Applied, thank you. > --- > drivers/input/serio/libps2.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/serio/libps2.c b/drivers/input/serio/libps2.c > index e6a07e68d1ff..22b8e05aa36c 100644 > --- a/drivers/input/serio/libps2.c > +++ b/drivers/input/serio/libps2.c > @@ -409,6 +409,7 @@ bool ps2_handle_ack(struct ps2dev *ps2dev, u8 data) > ps2dev->nak = PS2_RET_ERR; > break; > } > + /* Fall through */ > > /* > * Workaround for mice which don't ACK the Get ID command. > -- > 2.21.0 >
On 5/7/19 2:27 PM, Dmitry Torokhov wrote: > On Tue, May 07, 2019 at 01:24:09PM -0500, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch >> cases where we are expecting to fall through. >> >> This patch fixes the following warning: >> >> drivers/input/serio/libps2.c: In function ‘ps2_handle_ack’: >> drivers/input/serio/libps2.c:407:6: warning: this statement may fall through [-Wimplicit-fallthrough=] >> if (ps2dev->flags & PS2_FLAG_NAK) { >> ^ >> drivers/input/serio/libps2.c:417:2: note: here >> case 0x00: >> ^~~~ >> >> Warning level 3 was used: -Wimplicit-fallthrough=3 >> >> This patch is part of the ongoing efforts to enable >> -Wimplicit-fallthrough. >> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > > Applied, thank you. > Awesome. :) Thanks, Dmitry. -- Gustavo
diff --git a/drivers/input/serio/libps2.c b/drivers/input/serio/libps2.c index e6a07e68d1ff..22b8e05aa36c 100644 --- a/drivers/input/serio/libps2.c +++ b/drivers/input/serio/libps2.c @@ -409,6 +409,7 @@ bool ps2_handle_ack(struct ps2dev *ps2dev, u8 data) ps2dev->nak = PS2_RET_ERR; break; } + /* Fall through */ /* * Workaround for mice which don't ACK the Get ID command.
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/input/serio/libps2.c: In function ‘ps2_handle_ack’: drivers/input/serio/libps2.c:407:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (ps2dev->flags & PS2_FLAG_NAK) { ^ drivers/input/serio/libps2.c:417:2: note: here case 0x00: ^~~~ Warning level 3 was used: -Wimplicit-fallthrough=3 This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/input/serio/libps2.c | 1 + 1 file changed, 1 insertion(+)