[V2,1/6] spi: bcm2835: bcm2835_spi_transfer_one_poll remove unnecessary argument

Commit Message

Martin Sperl April 23, 2019, 8:15 p.m. UTC

From: Martin Sperl <[e-mail]>

Remove the unnecessary argument of xfer_time_us when calling
bcm2835_spi_transfer_one_poll.

Signed-off-by: Martin Sperl <[e-mail]>

Changelog:
  V1 -> V2: applied feedback by Stefan Wahren
            reorganized patchset
	    added extra rational, descriptions

---
 drivers/spi/spi-bcm2835.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--
2.11.0

Comments

Mark Brown May 8, 2019, 8:26 a.m. UTC | #1

On Tue, Apr 23, 2019 at 08:15:08PM +0000, [e-mail] wrote:
> From: Martin Sperl <[e-mail]>
> 
> Remove the unnecessary argument of xfer_time_us when calling
> bcm2835_spi_transfer_one_poll.
> 
> Signed-off-by: Martin Sperl <[e-mail]>
> 
> Changelog:
>   V1 -> V2: applied feedback by Stefan Wahren
>             reorganized patchset
> 	    added extra rational, descriptions
> 
> ---

As per SubmittingPatches the changelog should go after the ---.

Patch

diff --git a/drivers/spi/spi-bcm2835.c b/drivers/spi/spi-bcm2835.c
index 35aebdfd3b4e..ef7f8dc9f18e 100644
--- a/drivers/spi/spi-bcm2835.c
+++ b/drivers/spi/spi-bcm2835.c
@@ -725,8 +725,7 @@  static void bcm2835_dma_init(struct spi_master *master, struct device *dev)
 static int bcm2835_spi_transfer_one_poll(struct spi_master *master,
 					 struct spi_device *spi,
 					 struct spi_transfer *tfr,
-					 u32 cs,
-					 unsigned long long xfer_time_us)
+					 u32 cs)
 {
 	struct bcm2835_spi *bs = spi_master_get_devdata(master);
 	unsigned long timeout;
@@ -827,8 +826,7 @@  static int bcm2835_spi_transfer_one(struct spi_master *master,

 	/* for short requests run polling*/
 	if (xfer_time_us <= BCM2835_SPI_POLLING_LIMIT_US)
-		return bcm2835_spi_transfer_one_poll(master, spi, tfr,
-						     cs, xfer_time_us);
+		return bcm2835_spi_transfer_one_poll(master, spi, tfr, cs);

 	/* run in dma mode if conditions are right */
 	if (master->can_dma && bcm2835_spi_can_dma(master, spi, tfr))