| Message ID | 20190430044719.30720-2-chuanhua.han@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] i2c: imx: I2C Driver doesn't consider I2C_IPGCLK_SEL RCW bit when using ls1046a SoC | expand |
On Tue, Apr 30, 2019 at 12:47:19PM +0800, Chuanhua Han wrote: > For NXP ls1046a SoC, the i2c clock needs to be configured with the > appropriate bit of RCW, so we add the guts node (GUTS/DCFG global > utilities block) for the driver to read. > > Signed-off-by: Sumit Batra <sumit.batra@nxp.com> > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com> > --- > arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > index 373310e4c0ea..f88599df18bb 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > @@ -205,6 +205,11 @@ > status = "disabled"; > }; > > + guts: global-utilities@1ee0000 { > + compatible = "fsl,qoriq-device-config"; > + reg = <0x0 0x1ee0000 0x0 0x1000>; > + }; According to Documentation/devicetree/bindings/soc/fsl/guts.txt we have the following compatibles: "fsl,qoriq-device-config-1.0" "fsl,qoriq-device-config-2.0" "fsl,<chip>-device-config" "fsl,<chip>-guts" "fsl,qoriq-device-config" is none of them and I don't think you should give this SoC specific thing a generic compatible. "fsl,ls1046a-device-config" would be better. Sascha
> -----Original Message----- > From: Sascha Hauer <s.hauer@pengutronix.de> > Sent: 2019年5月6日 15:41 > To: Chuanhua Han <chuanhua.han@nxp.com> > Cc: shawnguo@kernel.org; Leo Li <leoyang.li@nxp.com>; robh+dt@kernel.org; > mark.rutland@arm.com; linux-kernel@vger.kernel.org; > linux-i2c@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > devicetree@vger.kernel.org; festevam@gmail.com; dl-linux-imx > <linux-imx@nxp.com>; wsa+renesas@sang-engineering.com; > u.kleine-koenig@pengutronix.de; eha@deif.com; linux@rempel-privat.de; > l.stach@pengutronix.de; peda@axentia.se; Sumit Batra > <sumit.batra@nxp.com> > Subject: [EXT] Re: [PATCH 2/2] arm64: dts: fsl: ls1046a: Add the guts node in > dts > > Caution: EXT Email > > On Tue, Apr 30, 2019 at 12:47:19PM +0800, Chuanhua Han wrote: > > For NXP ls1046a SoC, the i2c clock needs to be configured with the > > appropriate bit of RCW, so we add the guts node (GUTS/DCFG global > > utilities block) for the driver to read. > > > > Signed-off-by: Sumit Batra <sumit.batra@nxp.com> > > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com> > > --- > > arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > > b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > > index 373310e4c0ea..f88599df18bb 100644 > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > > @@ -205,6 +205,11 @@ > > status = "disabled"; > > }; > > > > + guts: global-utilities@1ee0000 { > > + compatible = "fsl,qoriq-device-config"; > > + reg = <0x0 0x1ee0000 0x0 0x1000>; > > + }; > > According to Documentation/devicetree/bindings/soc/fsl/guts.txt we have the > following compatibles: > > "fsl,qoriq-device-config-1.0" > "fsl,qoriq-device-config-2.0" > "fsl,<chip>-device-config" > "fsl,<chip>-guts" > > "fsl,qoriq-device-config" is none of them and I don't think you should give this > SoC specific thing a generic compatible. > "fsl,ls1046a-device-config" would be better. yes, you are right,I will modify it > > Sascha > > > -- > Pengutronix e.K. | > | > Industrial Linux Solutions | > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.pe > ngutronix.de%2F&data=02%7C01%7Cchuanhua.han%40nxp.com%7C139 > 23fe17a1d46dad7e708d6d1f63f41%7C686ea1d3bc2b4c6fa92cd99c5c301635 > %7C0%7C0%7C636927252885458344&sdata=RLeDiCtLJRYzOZQ4P8CN8g > hTUGNF%2FKA%2FT%2FtLSCrgEaE%3D&reserved=0 | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 > | > Amtsgericht Hildesheim, HRA 2686 | Fax: > +49-5121-206917-5555 |
> -----Original Message----- > From: Sascha Hauer <s.hauer@pengutronix.de> > Sent: 2019年5月6日 15:41 > To: Chuanhua Han <chuanhua.han@nxp.com> > Cc: shawnguo@kernel.org; Leo Li <leoyang.li@nxp.com>; robh+dt@kernel.org; > mark.rutland@arm.com; linux-kernel@vger.kernel.org; > linux-i2c@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > devicetree@vger.kernel.org; festevam@gmail.com; dl-linux-imx > <linux-imx@nxp.com>; wsa+renesas@sang-engineering.com; > u.kleine-koenig@pengutronix.de; eha@deif.com; linux@rempel-privat.de; > l.stach@pengutronix.de; peda@axentia.se; Sumit Batra > <sumit.batra@nxp.com> > Subject: [EXT] Re: [PATCH 2/2] arm64: dts: fsl: ls1046a: Add the guts node in > dts > > Caution: EXT Email > > On Tue, Apr 30, 2019 at 12:47:19PM +0800, Chuanhua Han wrote: > > For NXP ls1046a SoC, the i2c clock needs to be configured with the > > appropriate bit of RCW, so we add the guts node (GUTS/DCFG global > > utilities block) for the driver to read. > > > > Signed-off-by: Sumit Batra <sumit.batra@nxp.com> > > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com> > > --- > > arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > > b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > > index 373310e4c0ea..f88599df18bb 100644 > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > > @@ -205,6 +205,11 @@ > > status = "disabled"; > > }; > > > > + guts: global-utilities@1ee0000 { > > + compatible = "fsl,qoriq-device-config"; > > + reg = <0x0 0x1ee0000 0x0 0x1000>; > > + }; > > According to Documentation/devicetree/bindings/soc/fsl/guts.txt we have the > following compatibles: > > "fsl,qoriq-device-config-1.0" > "fsl,qoriq-device-config-2.0" > "fsl,<chip>-device-config" > "fsl,<chip>-guts" > > "fsl,qoriq-device-config" is none of them and I don't think you should give this > SoC specific thing a generic compatible. > "fsl,ls1046a-device-config" would be better. > Yes, you should be right > Sascha > > > -- > Pengutronix e.K. | > | > Industrial Linux Solutions | > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.pe > ngutronix.de%2F&data=02%7C01%7Cchuanhua.han%40nxp.com%7C139 > 23fe17a1d46dad7e708d6d1f63f41%7C686ea1d3bc2b4c6fa92cd99c5c301635 > %7C0%7C0%7C636927252885458344&sdata=RLeDiCtLJRYzOZQ4P8CN8g > hTUGNF%2FKA%2FT%2FtLSCrgEaE%3D&reserved=0 | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 > | > Amtsgericht Hildesheim, HRA 2686 | Fax: > +49-5121-206917-5555 |
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi index 373310e4c0ea..f88599df18bb 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi @@ -205,6 +205,11 @@ status = "disabled"; }; + guts: global-utilities@1ee0000 { + compatible = "fsl,qoriq-device-config"; + reg = <0x0 0x1ee0000 0x0 0x1000>; + }; + qspi: spi@1550000 { compatible = "fsl,ls1021a-qspi"; #address-cells = <1>;