| Message ID | 20190513134714.3124-4-wei.liu2@citrix.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Misc patches | expand |
>>> On 13.05.19 at 15:47, <wei.liu2@citrix.com> wrote: > --- a/README > +++ b/README > @@ -181,6 +181,10 @@ Various tools, such as pygrub, have the following runtime dependencies: > URL: http://www.python.org/ > Debian: python > > +Note that the build system expects `python` to be available. If your system > +only has `python2` or `python3` but not `python` (as in Linux From Scratch), > +you will need to create a symlink for it. Is creating a symlink indeed the only option? What about specifying PYTHON= on the make cmdline? I don't mean to say the set of workarounds needs to be exhaustive here, but perhaps add at least "e.g." if there are other options as well? Jan
On Mon, May 13, 2019 at 08:27:16AM -0600, Jan Beulich wrote: > >>> On 13.05.19 at 15:47, <wei.liu2@citrix.com> wrote: > > --- a/README > > +++ b/README > > @@ -181,6 +181,10 @@ Various tools, such as pygrub, have the following runtime dependencies: > > URL: http://www.python.org/ > > Debian: python > > > > +Note that the build system expects `python` to be available. If your system > > +only has `python2` or `python3` but not `python` (as in Linux From Scratch), > > +you will need to create a symlink for it. > > Is creating a symlink indeed the only option? What about specifying > PYTHON= on the make cmdline? I don't mean to say the set of > workarounds needs to be exhaustive here, but perhaps add at > least "e.g." if there are other options as well? Xen's build system is strange in that make A=B is not the same as A=B make . In practice this has bitten a few people in the past. That's why I opted to not mention that variant. But since you ask, I can add it to next version. Wei. > > Jan > >
On 5/13/19 2:47 PM, Wei Liu wrote: > The hypervisor build system requires `python`. To avoid putting too > much (confusing) information in README, mandate availability of > `python`. > > Signed-off-by: Wei Liu <wei.liu2@citrix.com> > --- > README | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/README b/README > index 23e4f7c3dc..a60ccf6e9c 100644 > --- a/README > +++ b/README > @@ -181,6 +181,10 @@ Various tools, such as pygrub, have the following runtime dependencies: > URL: http://www.python.org/ > Debian: python > > +Note that the build system expects `python` to be available. If your system > +only has `python2` or `python3` but not `python` (as in Linux From Scratch), > +you will need to create a symlink for it. Since we're not in a release crunch any more, it seems like updating ./configure to look for ""python3", "python2", and "python" (probably in that order) would be a better solution here. -George
On Mon, May 13, 2019 at 03:38:24PM +0100, George Dunlap wrote: > On 5/13/19 2:47 PM, Wei Liu wrote: > > The hypervisor build system requires `python`. To avoid putting too > > much (confusing) information in README, mandate availability of > > `python`. > > > > Signed-off-by: Wei Liu <wei.liu2@citrix.com> > > --- > > README | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/README b/README > > index 23e4f7c3dc..a60ccf6e9c 100644 > > --- a/README > > +++ b/README > > @@ -181,6 +181,10 @@ Various tools, such as pygrub, have the following runtime dependencies: > > URL: http://www.python.org/ > > Debian: python > > > > +Note that the build system expects `python` to be available. If your system > > +only has `python2` or `python3` but not `python` (as in Linux From Scratch), > > +you will need to create a symlink for it. > > Since we're not in a release crunch any more, it seems like updating > ./configure to look for ""python3", "python2", and "python" (probably in > that order) would be a better solution here. No, it is not about tools build. Hypervisor build depends on `python` but we don't want it to depend on configure. See "Hypervisor build can't work without `python` (Was: Re: Xen commit 9b0bc91b3 possibly removed too much info from README)" Wei. > > -George
diff --git a/README b/README index 23e4f7c3dc..a60ccf6e9c 100644 --- a/README +++ b/README @@ -181,6 +181,10 @@ Various tools, such as pygrub, have the following runtime dependencies: URL: http://www.python.org/ Debian: python +Note that the build system expects `python` to be available. If your system +only has `python2` or `python3` but not `python` (as in Linux From Scratch), +you will need to create a symlink for it. + Intel(R) Trusted Execution Technology Support =============================================
The hypervisor build system requires `python`. To avoid putting too much (confusing) information in README, mandate availability of `python`. Signed-off-by: Wei Liu <wei.liu2@citrix.com> --- README | 4 ++++ 1 file changed, 4 insertions(+)