diff mbox series

[v4,5/8] arm64: dts: allwinner: Add mali GPU supply for Pine H64

Message ID 20190512174608.10083-6-peron.clem@gmail.com (mailing list archive)
State New, archived
Headers show
Series Allwinner H6 Mali GPU support | expand

Commit Message

Clément Péron May 12, 2019, 5:46 p.m. UTC 
From: Clément Péron <peron.clem@gmail.com>

Enable and add supply to the Mali GPU node on the
Pine H64 board.

Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
 arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Chen-Yu Tsai May 14, 2019, 10:18 a.m. UTC | #1 
On Mon, May 13, 2019 at 2:28 AM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> On Sun, May 12, 2019 at 11:16 PM <peron.clem@gmail.com> wrote:
> >
> > From: Clément Péron <peron.clem@gmail.com>
> >
> > Enable and add supply to the Mali GPU node on the
> > Pine H64 board.
> >
> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > ---
> >  arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> > index 4802902e128f..e16a8c6738f9 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> > @@ -85,6 +85,11 @@
> >         status = "okay";
> >  };
> >
> > +&gpu {
> > +       mali-supply = <&reg_dcdcc>;
> > +       status = "okay";
> > +};
>
> I think we can squash all these board dts changes into single patch.

Yes. Please do so for all patches with the same changes applied to different
boards, and authored by the same person.

ChenYu
Clément Péron May 14, 2019, 3:22 p.m. UTC | #2 
Hi Jagan, Chen-Yu,

On Tue, 14 May 2019 at 12:18, Chen-Yu Tsai <wens@csie.org> wrote:
>
> On Mon, May 13, 2019 at 2:28 AM Jagan Teki <jagan@amarulasolutions.com> wrote:
> >
> > On Sun, May 12, 2019 at 11:16 PM <peron.clem@gmail.com> wrote:
> > >
> > > From: Clément Péron <peron.clem@gmail.com>
> > >
> > > Enable and add supply to the Mali GPU node on the
> > > Pine H64 board.
> > >
> > > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > > ---
> > >  arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> > > index 4802902e128f..e16a8c6738f9 100644
> > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
> > > @@ -85,6 +85,11 @@
> > >         status = "okay";
> > >  };
> > >
> > > +&gpu {
> > > +       mali-supply = <&reg_dcdcc>;
> > > +       status = "okay";
> > > +};
> >
> > I think we can squash all these board dts changes into single patch.
>
> Yes. Please do so for all patches with the same changes applied to different
> boards, and authored by the same person.

I thought it was required to have "smallest" patch as possible.
And it's also better for tracking "Tested-by" tag.

I will squash them in the next version.

Thanks,
Clement
>
> ChenYu
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
index 4802902e128f..e16a8c6738f9 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
@@ -85,6 +85,11 @@ 
 	status = "okay";
 };
 
+&gpu {
+	mali-supply = <&reg_dcdcc>;
+	status = "okay";
+};
+
 &hdmi {
 	status = "okay";
 };