| Message ID | 20190511012301.2661-1-natechancellor@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mfd: stmfx: Fix macro definition spelling | expand |
On 5/11/19 3:23 AM, Nathan Chancellor wrote: > Clang warns: > > In file included from drivers/mfd/stmfx.c:13: > include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a > header guard here, followed by #define of a different macro > [-Wheader-guard] > > Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver") > Link: https://github.com/ClangBuiltLinux/linux/issues/475 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Reviewed-by: Amelie Delaunay <amelie.delaunay@st.com> > --- > include/linux/mfd/stmfx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/mfd/stmfx.h b/include/linux/mfd/stmfx.h > index d890595b89b6..3c67983678ec 100644 > --- a/include/linux/mfd/stmfx.h > +++ b/include/linux/mfd/stmfx.h > @@ -5,7 +5,7 @@ > */ > > #ifndef MFD_STMFX_H > -#define MFX_STMFX_H > +#define MFD_STMFX_H > > #include <linux/regmap.h> > >
On Fri, 10 May 2019, Nathan Chancellor wrote: > Clang warns: > > In file included from drivers/mfd/stmfx.c:13: > include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a > header guard here, followed by #define of a different macro > [-Wheader-guard] > > Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver") > Link: https://github.com/ClangBuiltLinux/linux/issues/475 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > --- > include/linux/mfd/stmfx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks.
On Mon, May 13, 2019 at 08:30:59AM +0100, Lee Jones wrote: > On Fri, 10 May 2019, Nathan Chancellor wrote: > > > Clang warns: > > > > In file included from drivers/mfd/stmfx.c:13: > > include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a > > header guard here, followed by #define of a different macro > > [-Wheader-guard] > > > > Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver") > > Link: https://github.com/ClangBuiltLinux/linux/issues/475 > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > > --- > > include/linux/mfd/stmfx.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Applied, thanks. > > -- > Lee Jones [李琼斯] > Linaro Services Technical Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog Hi Lee, Thanks for picking it up. It seems this didn't make it into your MFD pull request for 5.2, was that intentional? It would be nice to avoid this warning. Thanks, Nathan
On Tue, 14 May 2019, Nathan Chancellor wrote: > On Mon, May 13, 2019 at 08:30:59AM +0100, Lee Jones wrote: > > On Fri, 10 May 2019, Nathan Chancellor wrote: > > > > > Clang warns: > > > > > > In file included from drivers/mfd/stmfx.c:13: > > > include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a > > > header guard here, followed by #define of a different macro > > > [-Wheader-guard] > > > > > > Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver") > > > Link: https://github.com/ClangBuiltLinux/linux/issues/475 > > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > > > --- > > > include/linux/mfd/stmfx.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Applied, thanks. > > > > Hi Lee, > > Thanks for picking it up. It seems this didn't make it into your MFD > pull request for 5.2, was that intentional? It would be nice to avoid > this warning. Hmm... no it was not intentional. Not sure what happened there. I will pick it up for the -rcs.
On Tue, May 14, 2019 at 07:54:04PM +0100, Lee Jones wrote: > On Tue, 14 May 2019, Nathan Chancellor wrote: > > > On Mon, May 13, 2019 at 08:30:59AM +0100, Lee Jones wrote: > > > On Fri, 10 May 2019, Nathan Chancellor wrote: > > > > > > > Clang warns: > > > > > > > > In file included from drivers/mfd/stmfx.c:13: > > > > include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a > > > > header guard here, followed by #define of a different macro > > > > [-Wheader-guard] > > > > > > > > Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver") > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/475 > > > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > > > > --- > > > > include/linux/mfd/stmfx.h | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Applied, thanks. > > > > > > > Hi Lee, > > > > Thanks for picking it up. It seems this didn't make it into your MFD > > pull request for 5.2, was that intentional? It would be nice to avoid > > this warning. > > Hmm... no it was not intentional. Not sure what happened there. > > I will pick it up for the -rcs. > > -- > Lee Jones [李琼斯] > Linaro Services Technical Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog Thank you, I appreciate it! Nathan
On Tue, May 14, 2019 at 07:54:04PM +0100, Lee Jones wrote: > On Tue, 14 May 2019, Nathan Chancellor wrote: > > > On Mon, May 13, 2019 at 08:30:59AM +0100, Lee Jones wrote: > > > On Fri, 10 May 2019, Nathan Chancellor wrote: > > > > > > > Clang warns: > > > > > > > > In file included from drivers/mfd/stmfx.c:13: > > > > include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a > > > > header guard here, followed by #define of a different macro > > > > [-Wheader-guard] > > > > > > > > Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver") > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/475 > > > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > > > > --- > > > > include/linux/mfd/stmfx.h | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Applied, thanks. > > > > > > > Hi Lee, > > > > Thanks for picking it up. It seems this didn't make it into your MFD > > pull request for 5.2, was that intentional? It would be nice to avoid > > this warning. > > Hmm... no it was not intentional. Not sure what happened there. > > I will pick it up for the -rcs. Hi Lee, Have you picked this up yet? I don't see it in -next or your public tree. Cheers, Nathan
diff --git a/include/linux/mfd/stmfx.h b/include/linux/mfd/stmfx.h index d890595b89b6..3c67983678ec 100644 --- a/include/linux/mfd/stmfx.h +++ b/include/linux/mfd/stmfx.h @@ -5,7 +5,7 @@ */ #ifndef MFD_STMFX_H -#define MFX_STMFX_H +#define MFD_STMFX_H #include <linux/regmap.h>
Clang warns: In file included from drivers/mfd/stmfx.c:13: include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a header guard here, followed by #define of a different macro [-Wheader-guard] Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver") Link: https://github.com/ClangBuiltLinux/linux/issues/475 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> --- include/linux/mfd/stmfx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)