| Message ID | 20190421131156.9631-1-exalm7659@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 9843f3e08e2144724be7148e08d77a195dea257a |
| Headers | show |
| Series | Input: synaptics - enable SMBus on ThinkPad E480 and E580 | expand |
Hi, Alexander. If your patch is ok after suspend/hibernation (aka s2ram/s2disk), write so and add Benjamin to the cc list: Benjamin Tissoires <benjamin.tissoires@redhat.com> It's likely he'll give reviewed-by to your patch. # I'm not a kernel developer; simply helping with this ps2 -> rmi4 issue. Regards, Teika From: Alexander Mikhaylenko <exalm7659@gmail.com> Subject: [PATCH] Input: synaptics - enable SMBus on ThinkPad E480 and E580 Date: Sun, 21 Apr 2019 18:11:56 +0500 > They are capable of using intertouch and it works well with > psmouse.synaptics_intertouch=1, so add them to the list. > > Without it, scrolling and gestures are jumpy, three-finger pinch gesture > doesn't work and three- or four-finger swipes sometimes get stuck. > > Signed-off-by: Alexander Mikhaylenko <exalm7659@gmail.com> > --- > drivers/input/mouse/synaptics.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c > index b6da0c1267e3..8e6077d8e434 100644 > --- a/drivers/input/mouse/synaptics.c > +++ b/drivers/input/mouse/synaptics.c > @@ -179,6 +179,8 @@ static const char * const smbus_pnp_ids[] = { > "LEN0096", /* X280 */ > "LEN0097", /* X280 -> ALPS trackpoint */ > "LEN200f", /* T450s */ > + "LEN2054", /* E480 */ > + "LEN2055", /* E580 */ > "SYN3052", /* HP EliteBook 840 G4 */ > "SYN3221", /* HP 15-ay000 */ > NULL > -- > 2.21.0 >
Yes, both work fine so far. In fact, I sometimes had non-working touchpad after suspend *without* psmouse.synaptics_intertouch=1, but never with it and/or with the patch applied. Thanks! (re-sending, I've accidentally sent it in HTML first) On Tue, May 14, 2019 at 5:11 PM, Teika Kazura <teika@gmx.com> wrote: > Hi, Alexander. If your patch is ok after suspend/hibernation (aka > s2ram/s2disk), write so and add Benjamin to the cc list: > Benjamin Tissoires <benjamin.tissoires@redhat.com> > > It's likely he'll give reviewed-by to your patch. > # I'm not a kernel developer; simply helping with this ps2 -> rmi4 > issue. > > Regards, > Teika > > From: Alexander Mikhaylenko <exalm7659@gmail.com> > Subject: [PATCH] Input: synaptics - enable SMBus on ThinkPad E480 and > E580 > Date: Sun, 21 Apr 2019 18:11:56 +0500 > >> They are capable of using intertouch and it works well with >> psmouse.synaptics_intertouch=1, so add them to the list. >> >> Without it, scrolling and gestures are jumpy, three-finger pinch >> gesture >> doesn't work and three- or four-finger swipes sometimes get stuck. >> >> Signed-off-by: Alexander Mikhaylenko <exalm7659@gmail.com> >> --- >> drivers/input/mouse/synaptics.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/input/mouse/synaptics.c >> b/drivers/input/mouse/synaptics.c >> index b6da0c1267e3..8e6077d8e434 100644 >> --- a/drivers/input/mouse/synaptics.c >> +++ b/drivers/input/mouse/synaptics.c >> @@ -179,6 +179,8 @@ static const char * const smbus_pnp_ids[] = { >> "LEN0096", /* X280 */ >> "LEN0097", /* X280 -> ALPS trackpoint */ >> "LEN200f", /* T450s */ >> + "LEN2054", /* E480 */ >> + "LEN2055", /* E580 */ >> "SYN3052", /* HP EliteBook 840 G4 */ >> "SYN3221", /* HP 15-ay000 */ >> NULL >> -- >> 2.21.0 >>
On Sun, Apr 21, 2019 at 3:27 PM Alexander Mikhaylenko <exalm7659@gmail.com> wrote: > > They are capable of using intertouch and it works well with > psmouse.synaptics_intertouch=1, so add them to the list. > > Without it, scrolling and gestures are jumpy, three-finger pinch gesture > doesn't work and three- or four-finger swipes sometimes get stuck. > > Signed-off-by: Alexander Mikhaylenko <exalm7659@gmail.com> > --- Based on comments about suspend/resume in the thread: Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Teika: note that you are welcome to provide a reviewed-by in any cases, even if you "are not a kernel developer", you know enough to say if this kind of patch is valid or not :) Cheers, Benjamin > drivers/input/mouse/synaptics.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c > index b6da0c1267e3..8e6077d8e434 100644 > --- a/drivers/input/mouse/synaptics.c > +++ b/drivers/input/mouse/synaptics.c > @@ -179,6 +179,8 @@ static const char * const smbus_pnp_ids[] = { > "LEN0096", /* X280 */ > "LEN0097", /* X280 -> ALPS trackpoint */ > "LEN200f", /* T450s */ > + "LEN2054", /* E480 */ > + "LEN2055", /* E580 */ > "SYN3052", /* HP EliteBook 840 G4 */ > "SYN3221", /* HP 15-ay000 */ > NULL > -- > 2.21.0 >
[resending with proper email of Dmitry] On Wed, May 15, 2019 at 9:02 AM Benjamin Tissoires <benjamin.tissoires@gmail.com> wrote: > > On Sun, Apr 21, 2019 at 3:27 PM Alexander Mikhaylenko > <exalm7659@gmail.com> wrote: > > > > They are capable of using intertouch and it works well with > > psmouse.synaptics_intertouch=1, so add them to the list. > > > > Without it, scrolling and gestures are jumpy, three-finger pinch gesture > > doesn't work and three- or four-finger swipes sometimes get stuck. > > > > Signed-off-by: Alexander Mikhaylenko <exalm7659@gmail.com> > > --- > > Based on comments about suspend/resume in the thread: > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > > Teika: note that you are welcome to provide a reviewed-by in any > cases, even if you "are not a kernel developer", you know enough to > say if this kind of patch is valid or not :) > > Cheers, > Benjamin > > > drivers/input/mouse/synaptics.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c > > index b6da0c1267e3..8e6077d8e434 100644 > > --- a/drivers/input/mouse/synaptics.c > > +++ b/drivers/input/mouse/synaptics.c > > @@ -179,6 +179,8 @@ static const char * const smbus_pnp_ids[] = { > > "LEN0096", /* X280 */ > > "LEN0097", /* X280 -> ALPS trackpoint */ > > "LEN200f", /* T450s */ > > + "LEN2054", /* E480 */ > > + "LEN2055", /* E580 */ > > "SYN3052", /* HP EliteBook 840 G4 */ > > "SYN3221", /* HP 15-ay000 */ > > NULL > > -- > > 2.21.0 > >
On Wed, May 15, 2019 at 09:03:39AM +0200, Benjamin Tissoires wrote: > [resending with proper email of Dmitry] > > On Wed, May 15, 2019 at 9:02 AM Benjamin Tissoires > <benjamin.tissoires@gmail.com> wrote: > > > > On Sun, Apr 21, 2019 at 3:27 PM Alexander Mikhaylenko > > <exalm7659@gmail.com> wrote: > > > > > > They are capable of using intertouch and it works well with > > > psmouse.synaptics_intertouch=1, so add them to the list. > > > > > > Without it, scrolling and gestures are jumpy, three-finger pinch gesture > > > doesn't work and three- or four-finger swipes sometimes get stuck. > > > > > > Signed-off-by: Alexander Mikhaylenko <exalm7659@gmail.com> Applied, thank you. > > > --- > > > > Based on comments about suspend/resume in the thread: > > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > > > > Teika: note that you are welcome to provide a reviewed-by in any > > cases, even if you "are not a kernel developer", you know enough to > > say if this kind of patch is valid or not :) > > > > Cheers, > > Benjamin > > > > > drivers/input/mouse/synaptics.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c > > > index b6da0c1267e3..8e6077d8e434 100644 > > > --- a/drivers/input/mouse/synaptics.c > > > +++ b/drivers/input/mouse/synaptics.c > > > @@ -179,6 +179,8 @@ static const char * const smbus_pnp_ids[] = { > > > "LEN0096", /* X280 */ > > > "LEN0097", /* X280 -> ALPS trackpoint */ > > > "LEN200f", /* T450s */ > > > + "LEN2054", /* E480 */ > > > + "LEN2055", /* E580 */ > > > "SYN3052", /* HP EliteBook 840 G4 */ > > > "SYN3221", /* HP 15-ay000 */ > > > NULL > > > -- > > > 2.21.0 > > >
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index b6da0c1267e3..8e6077d8e434 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -179,6 +179,8 @@ static const char * const smbus_pnp_ids[] = { "LEN0096", /* X280 */ "LEN0097", /* X280 -> ALPS trackpoint */ "LEN200f", /* T450s */ + "LEN2054", /* E480 */ + "LEN2055", /* E580 */ "SYN3052", /* HP EliteBook 840 G4 */ "SYN3221", /* HP 15-ay000 */ NULL
They are capable of using intertouch and it works well with psmouse.synaptics_intertouch=1, so add them to the list. Without it, scrolling and gestures are jumpy, three-finger pinch gesture doesn't work and three- or four-finger swipes sometimes get stuck. Signed-off-by: Alexander Mikhaylenko <exalm7659@gmail.com> --- drivers/input/mouse/synaptics.c | 2 ++ 1 file changed, 2 insertions(+)