| Message ID | 1558019883-12397-1-git-send-email-sunpeng.li@amd.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add DP MST AUX devices | expand |
Hi, could we (and for future versions of this series and others) get a respin of this that's actually rebased against drm-tip? That is the defacto standard branch to do development on, and otherwise anyone trying to test these patches has to resolve merge conflicts (along with maintainers). The branch this appears to be based off of doesn't even have the new kref scheme for branch devices and ports. On Thu, 2019-05-16 at 11:17 -0400, sunpeng.li@amd.com wrote: > From: Leo Li <sunpeng.li@amd.com> > > This series adds support for MST AUX devices. > > A more descriptive 'mstpath' attribute is also added to MST connector > devices. In addition, the DP aux device is made to be a child of the > corresponding connector's device where possible (*). This allows udev > rules to provide descriptive symlinks to the AUX devices. > > (*) This can only be done on drivers that register their connector and > aux devices via drm_connector_register() and drm_dp_aux_register() > respectively. The connector also needs to be registered before the aux > device. > > Leo Li (6): > drm/dp: Use non-cyclic idr > drm/dp-mst: Use connector kdev as aux device parent > drm/sysfs: Add mstpath attribute to connector devices > drm/amd/display: Use connector kdev as aux device parent > drm/bridge/analogix-anx78xx: Use connector kdev as aux device parent > drm/nouveau: Use connector kdev as aux device parent > > Ville Syrjälä (1): > drm/dp_mst: Register AUX devices for MST ports > > .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- > drivers/gpu/drm/bridge/analogix-anx78xx.c | 22 ++--- > drivers/gpu/drm/drm_dp_aux_dev.c | 17 +++- > drivers/gpu/drm/drm_dp_mst_topology.c | 106 > ++++++++++++++++++--- > drivers/gpu/drm/drm_sysfs.c | 23 +++++ > drivers/gpu/drm/nouveau/nouveau_connector.c | 2 +- > include/drm/drm_dp_helper.h | 4 + > include/drm/drm_dp_mst_helper.h | 6 ++ > 8 files changed, 152 insertions(+), 30 deletions(-) >
Whoops-one more thing I forgot to mention. This is just personal preference for me, but if you're ccing me on any of the patches in the series feel free to just do it for all of them. Makes my inbox a little less confusing to look at On Thu, 2019-05-16 at 15:54 -0400, Lyude Paul wrote: > Hi, could we (and for future versions of this series and others) get a > respin > of this that's actually rebased against drm-tip? That is the defacto > standard > branch to do development on, and otherwise anyone trying to test these > patches > has to resolve merge conflicts (along with maintainers). The branch this > appears to be based off of doesn't even have the new kref scheme for branch > devices and ports. > > On Thu, 2019-05-16 at 11:17 -0400, sunpeng.li@amd.com wrote: > > From: Leo Li <sunpeng.li@amd.com> > > > > This series adds support for MST AUX devices. > > > > A more descriptive 'mstpath' attribute is also added to MST connector > > devices. In addition, the DP aux device is made to be a child of the > > corresponding connector's device where possible (*). This allows udev > > rules to provide descriptive symlinks to the AUX devices. > > > > (*) This can only be done on drivers that register their connector and > > aux devices via drm_connector_register() and drm_dp_aux_register() > > respectively. The connector also needs to be registered before the aux > > device. > > > > Leo Li (6): > > drm/dp: Use non-cyclic idr > > drm/dp-mst: Use connector kdev as aux device parent > > drm/sysfs: Add mstpath attribute to connector devices > > drm/amd/display: Use connector kdev as aux device parent > > drm/bridge/analogix-anx78xx: Use connector kdev as aux device parent > > drm/nouveau: Use connector kdev as aux device parent > > > > Ville Syrjälä (1): > > drm/dp_mst: Register AUX devices for MST ports > > > > .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- > > drivers/gpu/drm/bridge/analogix-anx78xx.c | 22 ++--- > > drivers/gpu/drm/drm_dp_aux_dev.c | 17 +++- > > drivers/gpu/drm/drm_dp_mst_topology.c | 106 > > ++++++++++++++++++--- > > drivers/gpu/drm/drm_sysfs.c | 23 +++++ > > drivers/gpu/drm/nouveau/nouveau_connector.c | 2 +- > > include/drm/drm_dp_helper.h | 4 + > > include/drm/drm_dp_mst_helper.h | 6 ++ > > 8 files changed, 152 insertions(+), 30 deletions(-) > >
On 2019-05-16 3:54 p.m., Lyude Paul wrote: > [CAUTION: External Email] > > Hi, could we (and for future versions of this series and others) get a respin > of this that's actually rebased against drm-tip? That is the defacto standard > branch to do development on, and otherwise anyone trying to test these patches > has to resolve merge conflicts (along with maintainers). The branch this > appears to be based off of doesn't even have the new kref scheme for branch > devices and ports. > Sorry, this was laziness on my part :) Rebasing this now. Leo > On Thu, 2019-05-16 at 11:17 -0400, sunpeng.li@amd.com wrote: >> From: Leo Li <sunpeng.li@amd.com> >> >> This series adds support for MST AUX devices. >> >> A more descriptive 'mstpath' attribute is also added to MST connector >> devices. In addition, the DP aux device is made to be a child of the >> corresponding connector's device where possible (*). This allows udev >> rules to provide descriptive symlinks to the AUX devices. >> >> (*) This can only be done on drivers that register their connector and >> aux devices via drm_connector_register() and drm_dp_aux_register() >> respectively. The connector also needs to be registered before the aux >> device. >> >> Leo Li (6): >> drm/dp: Use non-cyclic idr >> drm/dp-mst: Use connector kdev as aux device parent >> drm/sysfs: Add mstpath attribute to connector devices >> drm/amd/display: Use connector kdev as aux device parent >> drm/bridge/analogix-anx78xx: Use connector kdev as aux device parent >> drm/nouveau: Use connector kdev as aux device parent >> >> Ville Syrjälä (1): >> drm/dp_mst: Register AUX devices for MST ports >> >> .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- >> drivers/gpu/drm/bridge/analogix-anx78xx.c | 22 ++--- >> drivers/gpu/drm/drm_dp_aux_dev.c | 17 +++- >> drivers/gpu/drm/drm_dp_mst_topology.c | 106 >> ++++++++++++++++++--- >> drivers/gpu/drm/drm_sysfs.c | 23 +++++ >> drivers/gpu/drm/nouveau/nouveau_connector.c | 2 +- >> include/drm/drm_dp_helper.h | 4 + >> include/drm/drm_dp_mst_helper.h | 6 ++ >> 8 files changed, 152 insertions(+), 30 deletions(-) >> > -- > Cheers, > Lyude Paul >
From: Leo Li <sunpeng.li@amd.com> This series adds support for MST AUX devices. A more descriptive 'mstpath' attribute is also added to MST connector devices. In addition, the DP aux device is made to be a child of the corresponding connector's device where possible (*). This allows udev rules to provide descriptive symlinks to the AUX devices. (*) This can only be done on drivers that register their connector and aux devices via drm_connector_register() and drm_dp_aux_register() respectively. The connector also needs to be registered before the aux device. Leo Li (6): drm/dp: Use non-cyclic idr drm/dp-mst: Use connector kdev as aux device parent drm/sysfs: Add mstpath attribute to connector devices drm/amd/display: Use connector kdev as aux device parent drm/bridge/analogix-anx78xx: Use connector kdev as aux device parent drm/nouveau: Use connector kdev as aux device parent Ville Syrjälä (1): drm/dp_mst: Register AUX devices for MST ports .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- drivers/gpu/drm/bridge/analogix-anx78xx.c | 22 ++--- drivers/gpu/drm/drm_dp_aux_dev.c | 17 +++- drivers/gpu/drm/drm_dp_mst_topology.c | 106 ++++++++++++++++++--- drivers/gpu/drm/drm_sysfs.c | 23 +++++ drivers/gpu/drm/nouveau/nouveau_connector.c | 2 +- include/drm/drm_dp_helper.h | 4 + include/drm/drm_dp_mst_helper.h | 6 ++ 8 files changed, 152 insertions(+), 30 deletions(-)