mbox series

[v2,0/3] drm/panfrost: drm_gem_map_offset() helper

Message ID 20190516141447.46839-1-steven.price@arm.com (mailing list archive)
Headers show
Series drm/panfrost: drm_gem_map_offset() helper | expand

Message

Steven Price May 16, 2019, 2:14 p.m. UTC 
Panfrost has a re-implementation of drm_gem_dumb_map_offset() with an
extra bug regarding the handling of imported buffers. However we don't
really want Panfrost calling _dumb functions because it's not a KMS
driver.

This series renames drm_gem_dumb_map_offset() to drop the '_dumb' and
introduces a shmem helper to wrap it. This means that the shmem
implementation can be kept in sync with the semantics the
drm_gem_shmem_mmap() callback provides.

v1: https://lore.kernel.org/lkml/20190513143244.16478-1-steven.price@arm.com/
Changes since v1:
 * Rename drm_gem_dumb_map_offset to drop _dumb
 * Add a shmem helper

Steven Price (3):
  drm/gem: Rename drm_gem_dumb_map_offset() to drm_gem_map_offset()
  drm: shmem: Add drm_gem_shmem_map_offset() wrapper
  drm/panfrost: Use drm_gem_shmem_map_offset()

 drivers/gpu/drm/drm_dumb_buffers.c      |  4 ++--
 drivers/gpu/drm/drm_gem.c               |  6 +++---
 drivers/gpu/drm/drm_gem_shmem_helper.c  | 20 ++++++++++++++++++++
 drivers/gpu/drm/exynos/exynos_drm_gem.c |  3 +--
 drivers/gpu/drm/panfrost/panfrost_drv.c | 16 ++--------------
 include/drm/drm_gem.h                   |  4 ++--
 include/drm/drm_gem_shmem_helper.h      |  2 ++
 7 files changed, 32 insertions(+), 23 deletions(-)

Comments

Alyssa Rosenzweig May 16, 2019, 3:36 p.m. UTC | #1 
Providing maintainers more aware of the substance review it and ok it,
patches 1-2 are:

	Acked-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>

Patch 3 should be:

	Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>