| Message ID | 1558403523-22079-1-git-send-email-jane.chu@oracle.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 135e53514ef2cb200b616bf3fa4272cfa6c39291 |
| Headers | show |
| Series | [v2] mm, memory-failure: clarify error message | expand |
On Mon, May 20, 2019 at 07:52:03PM -0600, Jane Chu wrote: > Some user who install SIGBUS handler that does longjmp out > therefore keeping the process alive is confused by the error > message > "[188988.765862] Memory failure: 0x1840200: Killing > cellsrv:33395 due to hardware memory corruption" > Slightly modify the error message to improve clarity. > > Signed-off-by: Jane Chu <jane.chu@oracle.com> Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> Thanks!
On 05/21/2019 07:22 AM, Jane Chu wrote: > Some user who install SIGBUS handler that does longjmp out > therefore keeping the process alive is confused by the error > message > "[188988.765862] Memory failure: 0x1840200: Killing > cellsrv:33395 due to hardware memory corruption" > Slightly modify the error message to improve clarity. > > Signed-off-by: Jane Chu <jane.chu@oracle.com> Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
> Some user who install SIGBUS handler that does longjmp out > therefore keeping the process alive is confused by the error > message > "[188988.765862] Memory failure: 0x1840200: Killing > cellsrv:33395 due to hardware memory corruption" > Slightly modify the error message to improve clarity. > > Signed-off-by: Jane Chu <jane.chu@oracle.com> > --- > mm/memory-failure.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index fc8b517..c4f4bcd 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -216,7 +216,7 @@ static int kill_proc(struct to_kill *tk, unsigned long > pfn, int flags) > short addr_lsb = tk->size_shift; > int ret; > > - pr_err("Memory failure: %#lx: Killing %s:%d due to hardware memory > corruption\n", > + pr_err("Memory failure: %#lx: Sending SIGBUS to %s:%d due to hardware > memory corruption\n", > pfn, t->comm, t->pid); > > if ((flags & MF_ACTION_REQUIRED) && t->mm == current->mm) { > -- > 1.8.3.1 This error message is helpful. Acked-by: Pankaj Gupta <pagupta@redhat.com> > > _______________________________________________ > Linux-nvdimm mailing list > Linux-nvdimm@lists.01.org > https://lists.01.org/mailman/listinfo/linux-nvdimm >
diff --git a/mm/memory-failure.c b/mm/memory-failure.c index fc8b517..c4f4bcd 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -216,7 +216,7 @@ static int kill_proc(struct to_kill *tk, unsigned long pfn, int flags) short addr_lsb = tk->size_shift; int ret; - pr_err("Memory failure: %#lx: Killing %s:%d due to hardware memory corruption\n", + pr_err("Memory failure: %#lx: Sending SIGBUS to %s:%d due to hardware memory corruption\n", pfn, t->comm, t->pid); if ((flags & MF_ACTION_REQUIRED) && t->mm == current->mm) {
Some user who install SIGBUS handler that does longjmp out therefore keeping the process alive is confused by the error message "[188988.765862] Memory failure: 0x1840200: Killing cellsrv:33395 due to hardware memory corruption" Slightly modify the error message to improve clarity. Signed-off-by: Jane Chu <jane.chu@oracle.com> --- mm/memory-failure.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)