diff mbox series

HID: logitech-hidpp: Add support for the S510 remote control

Message ID 20190512103602.4754-1-hdegoede@redhat.com (mailing list archive)
State Mainlined
Commit 2409877d386de709606ca7eecf7c10d2838525a1
Delegated to: Jiri Kosina
Headers show
Series HID: logitech-hidpp: Add support for the S510 remote control | expand

Commit Message

Hans de Goede May 12, 2019, 10:36 a.m. UTC
The S510 remote-control shows up as a second keyboard (keypad) on the
receiver. It has a scroll-wheel, which normally sends wheel event
originating from the mouse's evdev node.

Add a HIDPP_QUIRK_KBD_SCROLL_WHEEL quirk for it, so that the wheel events
properly originate from the evdev node of the remote control itself.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/hid/hid-logitech-hidpp.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Jiri Kosina May 22, 2019, 11:20 a.m. UTC | #1
On Sun, 12 May 2019, Hans de Goede wrote:

> The S510 remote-control shows up as a second keyboard (keypad) on the
> receiver. It has a scroll-wheel, which normally sends wheel event
> originating from the mouse's evdev node.
> 
> Add a HIDPP_QUIRK_KBD_SCROLL_WHEEL quirk for it, so that the wheel events
> properly originate from the evdev node of the remote control itself.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/hid/hid-logitech-hidpp.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
> index b99619d64080..14c84e1189a4 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -3747,6 +3747,9 @@ static const struct hid_device_id hidpp_devices[] = {
>  	{ /* Keyboard MX3200 (Y-RAV80) */
>  	  L27MHZ_DEVICE(0x005c),
>  	  .driver_data = HIDPP_QUIRK_KBD_ZOOM_WHEEL },
> +	{ /* S510 Media Remote */
> +	  L27MHZ_DEVICE(0x00fe),
> +	  .driver_data = HIDPP_QUIRK_KBD_SCROLL_WHEEL },

Queued in for-5.2/fixes, thanks Hans.
diff mbox series

Patch

diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index b99619d64080..14c84e1189a4 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -3747,6 +3747,9 @@  static const struct hid_device_id hidpp_devices[] = {
 	{ /* Keyboard MX3200 (Y-RAV80) */
 	  L27MHZ_DEVICE(0x005c),
 	  .driver_data = HIDPP_QUIRK_KBD_ZOOM_WHEEL },
+	{ /* S510 Media Remote */
+	  L27MHZ_DEVICE(0x00fe),
+	  .driver_data = HIDPP_QUIRK_KBD_SCROLL_WHEEL },
 
 	{ L27MHZ_DEVICE(HID_ANY_ID) },