| Message ID | 20190520235009.16734-1-megous@megous.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add support for Orange Pi 3 | expand |
Hello Sergei, On Tue, May 21, 2019 at 12:27:24PM +0300, Sergei Shtylyov wrote: > Hello! > > On 21.05.2019 2:50, megous@megous.com wrote: > > > From: Icenowy Zheng <icenowy@aosc.io> > > > > The PHY selection bit also exists on SoCs without an internal PHY; if it's > > set to 1 (internal PHY, default value) then the MAC will not make use of > > any PHY such SoCs. > ^ "on" or "with" missing? It's missing 'on'. thank you, Ondrej > > This problem appears when adapting for H6, which has no real internal PHY > > (the "internal PHY" on H6 is not on-die, but on a co-packaged AC200 chip, > > connected via RMII interface at GPIO bank A). > > > > Force the PHY selection bit to 0 when the SOC doesn't have an internal PHY, > > to address the problem of a wrong default value. > > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > > Signed-off-by: Ondrej Jirman <megous@megous.com> > [...] > > MBR, Sergei
From: Ondrej Jirman <megous@megous.com> This series implements support for Xunlong Orange Pi 3 board. Unfortunately, this board needs some small driver patches, so I have split the boards DT patch into chunks that require patches for drivers in various subsystems. Suggested merging plan/dependencies: - stmmac patches are needed for ethernet support (patches 1-3) - these should be ready now - HDMI support (patches 4-6) - needs DT and driver review Changes in v2: - added dt-bindings documentation for the board's compatible string (suggested by Clement) - addressed checkpatch warnings and code formatting issues (on Maxime's suggestions) - stmmac: dropped useless parenthesis, reworded description of the patch (suggested by Sergei) - drop useles dev_info() about the selected io bias voltage - docummented io voltage bias selection variant macros - wifi: marked WiFi DTS patch and realted mmc1_pins as "DO NOT MERGE", because wifi depends on H6 RTC support that's not merged yet (suggested by Clement) - added missing signed-of-bys - changed &usb2otg dr_mode to otg, and added a note about VBUS - improved wording of HDMI driver's DDC power supply patch Changes in v3: - dropped already applied patches - changed pinctrl I/O bias selection constants to enum and renamed - added /omit-if-no-ref/ to mmc1_pins - made mmc1_pins default pinconf for mmc1 in H6 dtsi - move ddc-supply to HDMI connector node, updated patch descriptions, changed dt-bindings docs Changes in v4: - fix checkpatch warnings/style issues - use enum in struct sunxi_desc_function for io_bias_cfg_variant - collected acked-by's - fix compile error in drivers/pinctrl/sunxi/pinctrl-sun9i-a80-r.c:156 caused by missing conversion from has_io_bias_cfg struct member (I've kept the acked-by, because it's a trivial change, but feel free to object.) (reported by Martin A. on github) I did not have A80 pinctrl enabled for some reason, so I did not catch this sooner. - dropped brcm firmware patch (was already applied) - dropped the wifi dts patch (will re-send after H6 RTC gets merged, along with bluetooth support, in a separate series) Changes in v5: - dropped already applied patches (pinctrl patches, mmc1 pinconf patch) - rename GMAC-3V3 -> GMAC-3V to match the schematic (Jagan) - changed hdmi-connector's ddc-supply property to ddc-en-gpios (Rob Herring) Please take a look. thank you and regards, Ondrej Jirman Icenowy Zheng (2): net: stmmac: sun8i: add support for Allwinner H6 EMAC net: stmmac: sun8i: force select external PHY when no internal one Ondrej Jirman (4): arm64: dts: allwinner: orange-pi-3: Enable ethernet dt-bindings: display: hdmi-connector: Support DDC bus enable drm: sun4i: Add support for enabling DDC I2C bus to sun8i_dw_hdmi glue arm64: dts: allwinner: orange-pi-3: Enable HDMI output .../display/connector/hdmi-connector.txt | 1 + .../dts/allwinner/sun50i-h6-orangepi-3.dts | 70 +++++++++++++++++++ drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 55 ++++++++++++++- drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h | 3 + .../net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 21 ++++++ 5 files changed, 147 insertions(+), 3 deletions(-)