mbox series

[net-next,v2,0/4] ENETC: support hardware timestamping

Message ID 20190523023451.2933-1-yangbo.lu@nxp.com (mailing list archive)
Headers show
Series ENETC: support hardware timestamping | expand

Message

Yangbo Lu May 23, 2019, 2:33 a.m. UTC 
This patch-set is to support hardware timestamping for ENETC
and also to add ENETC 1588 timer device tree node for ls1028a.

Because the ENETC RX BD ring dynamic allocation has not been
supported and it is too expensive to use extended RX BDs
if timestamping is not used, a Kconfig option is used to
enable extended RX BDs in order to support hardware
timestamping. This option will be removed once RX BD
ring dynamic allocation is implemented.

Yangbo Lu (4):
  enetc: add hardware timestamping support
  enetc: add get_ts_info interface for ethtool
  dt-binding: ptp_qoriq: support ENETC PTP compatible
  arm64: dts: fsl: ls1028a: add ENETC 1588 timer node

 .../devicetree/bindings/ptp/ptp-qoriq.txt     |   1 +
 .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi |   6 +
 drivers/net/ethernet/freescale/enetc/Kconfig  |  10 ++
 drivers/net/ethernet/freescale/enetc/enetc.c  | 158 +++++++++++++++++-
 drivers/net/ethernet/freescale/enetc/enetc.h  |  15 +-
 .../ethernet/freescale/enetc/enetc_ethtool.c  |  31 ++++
 .../net/ethernet/freescale/enetc/enetc_hw.h   |  13 ++
 .../net/ethernet/freescale/enetc/enetc_pf.c   |   1 +
 .../net/ethernet/freescale/enetc/enetc_ptp.c  |   5 +
 .../net/ethernet/freescale/enetc/enetc_vf.c   |   1 +
 10 files changed, 235 insertions(+), 6 deletions(-)

Comments

Richard Cochran May 23, 2019, 1:48 p.m. UTC | #1 
On Thu, May 23, 2019 at 02:33:24AM +0000, Y.b. Lu wrote:
> This patch-set is to support hardware timestamping for ENETC
> and also to add ENETC 1588 timer device tree node for ls1028a.

Please, in the future, summarize the changes from the last series in
the cover letter.  It helps the reviewers to focus.

Thanks,
Richard
Yangbo Lu May 24, 2019, 2:20 a.m. UTC | #2 
> -----Original Message-----
> From: Richard Cochran <richardcochran@gmail.com>
> Sent: Thursday, May 23, 2019 9:49 PM
> To: Y.b. Lu <yangbo.lu@nxp.com>
> Cc: netdev@vger.kernel.org; David Miller <davem@davemloft.net>; Claudiu
> Manoil <claudiu.manoil@nxp.com>; Shawn Guo <shawnguo@kernel.org>; Rob
> Herring <robh+dt@kernel.org>; Alexandru Marginean
> <alexandru.marginean@nxp.com>; devicetree@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net-next v2, 0/4] ENETC: support hardware timestamping
> 
> On Thu, May 23, 2019 at 02:33:24AM +0000, Y.b. Lu wrote:
> > This patch-set is to support hardware timestamping for ENETC and also
> > to add ENETC 1588 timer device tree node for ls1028a.
> 
> Please, in the future, summarize the changes from the last series in the cover
> letter.  It helps the reviewers to focus.

[Y.b. Lu] Sorry Richard. Will summarize all changes in cover letter in the future, besides change notes on each patch.
Thanks.

> 
> Thanks,
> Richard
David Miller May 24, 2019, 8:16 p.m. UTC | #3 
From: "Y.b. Lu" <yangbo.lu@nxp.com>
Date: Thu, 23 May 2019 02:33:24 +0000

> This patch-set is to support hardware timestamping for ENETC
> and also to add ENETC 1588 timer device tree node for ls1028a.
> 
> Because the ENETC RX BD ring dynamic allocation has not been
> supported and it is too expensive to use extended RX BDs
> if timestamping is not used, a Kconfig option is used to
> enable extended RX BDs in order to support hardware
> timestamping. This option will be removed once RX BD
> ring dynamic allocation is implemented.

Series applied.