| Message ID | 20190505105112.22691-1-yuval.shaia@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/rdma: Delete unused headers inclusion | expand |
On 5/5/19 1:51 PM, Yuval Shaia wrote: > This is a trivial cleanup patch. > > Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com> > --- > hw/rdma/rdma_backend.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c > index d1660b6474..05f6b03221 100644 > --- a/hw/rdma/rdma_backend.c > +++ b/hw/rdma/rdma_backend.c > @@ -14,16 +14,9 @@ > */ > > #include "qemu/osdep.h" > -#include "sysemu/sysemu.h" > -#include "qapi/error.h" > -#include "qapi/qmp/qlist.h" > -#include "qapi/qmp/qnum.h" > #include "qapi/qapi-events-rdma.h" > > #include <infiniband/verbs.h> > -#include <infiniband/umad_types.h> > -#include <infiniband/umad.h> > -#include <rdma/rdma_user_cm.h> > > #include "contrib/rdmacm-mux/rdmacm-mux.h" > #include "trace.h" > Reviewed-by: Kamal Heib <kheib@redhat.com>
Looks stuck. Let's try qemu-trivial. Yuval Shaia <yuval.shaia@oracle.com> writes: > This is a trivial cleanup patch. > > Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com> > --- > hw/rdma/rdma_backend.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c > index d1660b6474..05f6b03221 100644 > --- a/hw/rdma/rdma_backend.c > +++ b/hw/rdma/rdma_backend.c > @@ -14,16 +14,9 @@ > */ > > #include "qemu/osdep.h" > -#include "sysemu/sysemu.h" > -#include "qapi/error.h" > -#include "qapi/qmp/qlist.h" > -#include "qapi/qmp/qnum.h" > #include "qapi/qapi-events-rdma.h" > > #include <infiniband/verbs.h> > -#include <infiniband/umad_types.h> > -#include <infiniband/umad.h> > -#include <rdma/rdma_user_cm.h> > > #include "contrib/rdmacm-mux/rdmacm-mux.h" > #include "trace.h"
Hi Markus, On 5/23/19 6:24 PM, Markus Armbruster wrote: > Looks stuck. Let's try qemu-trivial. Thanks, that is a great idea. I didn't want to send a single-patch pull request, especially while another is waiting for reviews. Anyway, trivial queue can be used indeed. Thanks, Marcel > > Yuval Shaia <yuval.shaia@oracle.com> writes: > >> This is a trivial cleanup patch. >> >> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com> >> --- >> hw/rdma/rdma_backend.c | 7 ------- >> 1 file changed, 7 deletions(-) >> >> diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c >> index d1660b6474..05f6b03221 100644 >> --- a/hw/rdma/rdma_backend.c >> +++ b/hw/rdma/rdma_backend.c >> @@ -14,16 +14,9 @@ >> */ >> >> #include "qemu/osdep.h" >> -#include "sysemu/sysemu.h" >> -#include "qapi/error.h" >> -#include "qapi/qmp/qlist.h" >> -#include "qapi/qmp/qnum.h" >> #include "qapi/qapi-events-rdma.h" >> >> #include <infiniband/verbs.h> >> -#include <infiniband/umad_types.h> >> -#include <infiniband/umad.h> >> -#include <rdma/rdma_user_cm.h> >> >> #include "contrib/rdmacm-mux/rdmacm-mux.h" >> #include "trace.h"
On 24/05/2019 07:29, Marcel Apfelbaum wrote: > Hi Markus, > > On 5/23/19 6:24 PM, Markus Armbruster wrote: >> Looks stuck. Let's try qemu-trivial. > > Thanks, that is a great idea. > > I didn't want to send a single-patch pull request, > especially while another is waiting for reviews. > Anyway, trivial queue can be used indeed. Applied to my trivial-patches branch. Thanks, Laurent > Thanks, > Marcel > >> >> Yuval Shaia <yuval.shaia@oracle.com> writes: >> >>> This is a trivial cleanup patch. >>> >>> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com> >>> --- >>> hw/rdma/rdma_backend.c | 7 ------- >>> 1 file changed, 7 deletions(-) >>> >>> diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c >>> index d1660b6474..05f6b03221 100644 >>> --- a/hw/rdma/rdma_backend.c >>> +++ b/hw/rdma/rdma_backend.c >>> @@ -14,16 +14,9 @@ >>> */ >>> #include "qemu/osdep.h" >>> -#include "sysemu/sysemu.h" >>> -#include "qapi/error.h" >>> -#include "qapi/qmp/qlist.h" >>> -#include "qapi/qmp/qnum.h" >>> #include "qapi/qapi-events-rdma.h" >>> #include <infiniband/verbs.h> >>> -#include <infiniband/umad_types.h> >>> -#include <infiniband/umad.h> >>> -#include <rdma/rdma_user_cm.h> >>> #include "contrib/rdmacm-mux/rdmacm-mux.h" >>> #include "trace.h" > >
diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c index d1660b6474..05f6b03221 100644 --- a/hw/rdma/rdma_backend.c +++ b/hw/rdma/rdma_backend.c @@ -14,16 +14,9 @@ */ #include "qemu/osdep.h" -#include "sysemu/sysemu.h" -#include "qapi/error.h" -#include "qapi/qmp/qlist.h" -#include "qapi/qmp/qnum.h" #include "qapi/qapi-events-rdma.h" #include <infiniband/verbs.h> -#include <infiniband/umad_types.h> -#include <infiniband/umad.h> -#include <rdma/rdma_user_cm.h> #include "contrib/rdmacm-mux/rdmacm-mux.h" #include "trace.h"
This is a trivial cleanup patch. Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com> --- hw/rdma/rdma_backend.c | 7 ------- 1 file changed, 7 deletions(-)