| Message ID | 20190524040633.16854-1-nicoleotsuka@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Optimize dma_*_from_contiguous calls | expand |
On Thu, May 23, 2019 at 10:08 PM Nicolin Chen <nicoleotsuka@gmail.com> wrote: > > [ Per discussion at v1, we decide to add two new functions and start > replacing callers one by one. For this series, it only touches the > dma-direct part. And instead of merging two PATCHes, I still keep > them separate so that we may easily revert PATCH-2 if anything bad > happens as last time -- PATCH-1 is supposed to be a safe cleanup. ] > > This series of patches try to optimize dma_*_from_contiguous calls: > PATCH-1 abstracts two new functions and applies to dma-direct.c file. > PATCH-2 saves single pages and reduce fragmentations from CMA area. > > Please check their commit messages for detail changelog. > > Nicolin Chen (2): > dma-contiguous: Abstract dma_{alloc,free}_contiguous() > dma-contiguous: Use fallback alloc_pages for single pages > > include/linux/dma-contiguous.h | 11 +++++++ > kernel/dma/contiguous.c | 57 ++++++++++++++++++++++++++++++++++ > kernel/dma/direct.c | 24 +++----------- > 3 files changed, 72 insertions(+), 20 deletions(-) Thanks Nicolin. Tested on a HiSilicon D06 system. Tested-by: dann frazier <dann.frazier@canonical.com>
Thanks, applied to dma-mapping for-next. Can you also send a conversion of drivers/iommu/dma-iommu.c to your new helpers against this tree? http://git.infradead.org/users/hch/dma-mapping.git/shortlog/refs/heads/for-next
On Tue, May 28, 2019 at 08:04:24AM +0200, Christoph Hellwig wrote: > Thanks, > > applied to dma-mapping for-next. > > Can you also send a conversion of drivers/iommu/dma-iommu.c to your > new helpers against this tree? > > http://git.infradead.org/users/hch/dma-mapping.git/shortlog/refs/heads/for-next I can. There is a reported regression with !CONFIG_DMA_CMA now so I will do that after a fix is merged and the whole thing is stable. Thank you
[ Per discussion at v1, we decide to add two new functions and start replacing callers one by one. For this series, it only touches the dma-direct part. And instead of merging two PATCHes, I still keep them separate so that we may easily revert PATCH-2 if anything bad happens as last time -- PATCH-1 is supposed to be a safe cleanup. ] This series of patches try to optimize dma_*_from_contiguous calls: PATCH-1 abstracts two new functions and applies to dma-direct.c file. PATCH-2 saves single pages and reduce fragmentations from CMA area. Please check their commit messages for detail changelog. Nicolin Chen (2): dma-contiguous: Abstract dma_{alloc,free}_contiguous() dma-contiguous: Use fallback alloc_pages for single pages include/linux/dma-contiguous.h | 11 +++++++ kernel/dma/contiguous.c | 57 ++++++++++++++++++++++++++++++++++ kernel/dma/direct.c | 24 +++----------- 3 files changed, 72 insertions(+), 20 deletions(-)