| Message ID | 20190522162443.5780-1-srinivas.kandagatla@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soundwire: stream: fix out of boundary access on port properties | expand |
On 5/22/19 11:24 AM, Srinivas Kandagatla wrote: > Assigning local iterator to array element and using it again for > indexing would cross the array boundary. > Fix this by directly referring array element without using the local > variable. The change is valid and indeed the code could never work as is. I vaguely recall providing this feedback as well in an earlier version. Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > drivers/soundwire/stream.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c > index d01060dbee96..544925ff0b40 100644 > --- a/drivers/soundwire/stream.c > +++ b/drivers/soundwire/stream.c > @@ -1406,9 +1406,7 @@ struct sdw_dpn_prop *sdw_get_slave_dpn_prop(struct sdw_slave *slave, > } > > for (i = 0; i < num_ports; i++) { > - dpn_prop = &dpn_prop[i]; > - > - if (dpn_prop->num == port_num) > + if (dpn_prop[i].num == port_num) > return &dpn_prop[i]; > } > >
On 22-05-19, 17:24, Srinivas Kandagatla wrote: > Assigning local iterator to array element and using it again for > indexing would cross the array boundary. > Fix this by directly referring array element without using the local > variable. Applied, thanks
diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c index d01060dbee96..544925ff0b40 100644 --- a/drivers/soundwire/stream.c +++ b/drivers/soundwire/stream.c @@ -1406,9 +1406,7 @@ struct sdw_dpn_prop *sdw_get_slave_dpn_prop(struct sdw_slave *slave, } for (i = 0; i < num_ports; i++) { - dpn_prop = &dpn_prop[i]; - - if (dpn_prop->num == port_num) + if (dpn_prop[i].num == port_num) return &dpn_prop[i]; }
Assigning local iterator to array element and using it again for indexing would cross the array boundary. Fix this by directly referring array element without using the local variable. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> --- drivers/soundwire/stream.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)