mbox series

[v5,00/17] GuC 32.0.3

Message ID 20190527183613.17076-1-michal.wajdeczko@intel.com (mailing list archive)
Headers show
Series GuC 32.0.3 | expand

Message

Michal Wajdeczko May 27, 2019, 6:35 p.m. UTC 
New GuC firmwares (for SKL, BXT, KBL, GLK, ICL) with updated ABI interface.

v2: only HuC authentication is supported
v3: never allow to turn on GuC submission mode 
v4: rebased + newer HuC + GLK
v5: squashed + last minutes small fixups

Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Martin Peres <martin.peres@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk> 
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Tony Ye <tony.ye@intel.com>

Michal Wajdeczko (15):
  drm/i915/guc: Change platform default GuC mode
  drm/i915/guc: Don't allow GuC submission
  drm/i915/guc: Updates for GuC 32.0.3 firmware
  drm/i915/guc: Reset GuC ADS during sanitize
  drm/i915/guc: Always ask GuC to update power domain states
  drm/i915/guc: Define GuC firmware version for Geminilake
  drm/i915/huc: Define HuC firmware version for Geminilake
  drm/i915/guc: New GuC interrupt register for Gen11
  drm/i915/guc: New GuC scratch registers for Gen11
  drm/i915/huc: New HuC status register for Gen11
  drm/i915/guc: Update GuC CTB response definition
  drm/i915/guc: Enable GuC CTB communication on Gen11
  drm/i915/guc: Define GuC firmware version for Icelake
  drm/i915/huc: Define HuC firmware version for Icelake
  HAX: Turn on GuC/HuC auto mode

Oscar Mateo (2):
  drm/i915/guc: Create vfuncs for the GuC interrupts control functions
  drm/i915/guc: Correctly handle GuC interrupts on Gen11

 drivers/gpu/drm/i915/gt/intel_engine.h      |   2 +
 drivers/gpu/drm/i915/gt/intel_engine_cs.c   |   9 +-
 drivers/gpu/drm/i915/i915_irq.c             |  59 +++++-
 drivers/gpu/drm/i915/i915_irq.h             |   3 +
 drivers/gpu/drm/i915/i915_params.h          |   2 +-
 drivers/gpu/drm/i915/i915_pci.c             |   1 +
 drivers/gpu/drm/i915/i915_reg.h             |   4 +
 drivers/gpu/drm/i915/intel_guc.c            | 121 ++++++------
 drivers/gpu/drm/i915/intel_guc.h            |   8 +-
 drivers/gpu/drm/i915/intel_guc_ads.c        | 167 ++++++++++------
 drivers/gpu/drm/i915/intel_guc_ads.h        |   1 +
 drivers/gpu/drm/i915/intel_guc_ct.c         |   2 +-
 drivers/gpu/drm/i915/intel_guc_fw.c         |  97 ++++++----
 drivers/gpu/drm/i915/intel_guc_fwif.h       | 199 +++++++++-----------
 drivers/gpu/drm/i915/intel_guc_reg.h        |  25 +++
 drivers/gpu/drm/i915/intel_guc_submission.c |   4 -
 drivers/gpu/drm/i915/intel_huc.c            |  26 ++-
 drivers/gpu/drm/i915/intel_huc.h            |   7 +
 drivers/gpu/drm/i915/intel_huc_fw.c         |  24 +++
 drivers/gpu/drm/i915/intel_uc.c             |  51 +++--
 drivers/gpu/drm/i915/intel_uc_fw.c          |  20 +-
 21 files changed, 530 insertions(+), 302 deletions(-)

Comments

Chris Wilson May 28, 2019, 9:23 a.m. UTC | #1 
Quoting Michal Wajdeczko (2019-05-27 19:35:56)
> New GuC firmwares (for SKL, BXT, KBL, GLK, ICL) with updated ABI interface.

All reviewed/acked, and I trust the failures will be fixed in time, so
pushed. Thanks.
-Chris
Petri Latvala May 28, 2019, 9:40 a.m. UTC | #2 
On Tue, May 28, 2019 at 10:23:24AM +0100, Chris Wilson wrote:
> Quoting Michal Wajdeczko (2019-05-27 19:35:56)
> > New GuC firmwares (for SKL, BXT, KBL, GLK, ICL) with updated ABI interface.
> 
> All reviewed/acked, and I trust the failures will be fixed in time, so
> pushed. Thanks.
> -Chris


But without telling Martin to file cibuglog filters for known issues?
Chris Wilson May 28, 2019, 9:45 a.m. UTC | #3 
Quoting Petri Latvala (2019-05-28 10:40:31)
> On Tue, May 28, 2019 at 10:23:24AM +0100, Chris Wilson wrote:
> > Quoting Michal Wajdeczko (2019-05-27 19:35:56)
> > > New GuC firmwares (for SKL, BXT, KBL, GLK, ICL) with updated ABI interface.
> > 
> > All reviewed/acked, and I trust the failures will be fixed in time, so
> > pushed. Thanks.
> > -Chris
> 
> 
> But without telling Martin to file cibuglog filters for known issues?

fi-icl-guc should remain suppressed.
fi-apl-guc should be retired.
-Chris
Martin Peres May 28, 2019, 9:48 a.m. UTC | #4 
On 28/05/2019 12:45, Chris Wilson wrote:
> Quoting Petri Latvala (2019-05-28 10:40:31)
>> On Tue, May 28, 2019 at 10:23:24AM +0100, Chris Wilson wrote:
>>> Quoting Michal Wajdeczko (2019-05-27 19:35:56)
>>>> New GuC firmwares (for SKL, BXT, KBL, GLK, ICL) with updated ABI interface.
>>>
>>> All reviewed/acked, and I trust the failures will be fixed in time, so
>>> pushed. Thanks.
>>> -Chris
>>
>>
>> But without telling Martin to file cibuglog filters for known issues?
> 
> fi-icl-guc should remain suppressed.
> fi-apl-guc should be retired.

This is something to be discussed *before* merging. I suppressed all the
guc platforms (apl, cfl, icl, kbl, skl).

Let's hope that it does not affect the shards...

Martin
Saarinen, Jani May 28, 2019, 10:28 a.m. UTC | #5 
Hi,

> -----Original Message-----
> From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf Of Chris
> Wilson
> Sent: tiistai 28. toukokuuta 2019 12.46
> To: Latvala, Petri <petri.latvala@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH v5 00/17] GuC 32.0.3
> 
> Quoting Petri Latvala (2019-05-28 10:40:31)
> > On Tue, May 28, 2019 at 10:23:24AM +0100, Chris Wilson wrote:
> > > Quoting Michal Wajdeczko (2019-05-27 19:35:56)
> > > > New GuC firmwares (for SKL, BXT, KBL, GLK, ICL) with updated ABI interface.
> > >
> > > All reviewed/acked, and I trust the failures will be fixed in time,
> > > so pushed. Thanks.
> > > -Chris
> >
> >
> > But without telling Martin to file cibuglog filters for known issues?
> 
> fi-icl-guc should remain suppressed.
> fi-apl-guc should be retired.
Meaning to get to without guc usage ? 

> -Chris
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx