| Message ID | 20190528063544.17408-1-plaes@plaes.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND] ARM: dts: sun7i: olimex-lime2: Enable ac and power supplies | expand |
Hi, On Tue, 2019-05-28 at 09:35 +0300, Priit Laes wrote: > Lime2 has battery connector so enable these supplies. Out of curiosity, what is reported to userspace when no battery is attached? Looks good otherwise: Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> Cheers, Paul > Signed-off-by: Priit Laes <plaes@plaes.org> > --- > arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > index 9c8eecf4337a..9001b5527615 100644 > --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > @@ -206,6 +206,14 @@ > > #include "axp209.dtsi" > > +&ac_power_supply { > + status = "okay"; > +}; > + > +&battery_power_supply { > + status = "okay"; > +}; > + > ®_dcdc2 { > regulator-always-on; > regulator-min-microvolt = <1000000>; > -- > 2.11.0 >
On Tue, May 28, 2019 at 02:58:57PM +0200, Paul Kocialkowski wrote: > Hi, > > On Tue, 2019-05-28 at 09:35 +0300, Priit Laes wrote: > > Lime2 has battery connector so enable these supplies. > > Out of curiosity, what is reported to userspace when no battery is > attached? Data from /sys/class/power_supply/axp20x-battery: [snip] $ for i in $(ls -1); do echo "cat $i"; cat $i; done cat capacity 100 cat constant_charge_current 1200000 cat constant_charge_current_max 1200000 cat current_now 0 cat health Good cat online 0 cat present 0 cat status Not charging cat type Battery cat uevent POWER_SUPPLY_NAME=axp20x-battery POWER_SUPPLY_PRESENT=0 POWER_SUPPLY_ONLINE=0 POWER_SUPPLY_STATUS=Not charging POWEROSUPPLY_VOLTAGE_NOW=0 POWER_SUPPLY_CURRENT_NOW=0 POWER_SUPPLY_CON/TANT_CHARGE_CURRENT=1200000 POWER_SUPPLY_CONSTANT_CHARGE_CURRENT_MAX=1200000 POWER_SUPPLY_HEALTH=Good POWER_SUPPLY_VOLTAGE_MAXODESIGN=4200000 POWEROSUPPLY_VOLTAGE_MIN_DESIGN=2900000 POWER_SUPPLY_CAPACITY=100 cat voltage_max_design 4200000 cat voltage_min_design 2900000 cat voltage_now 0 [/snip] > Looks good otherwise: > Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> > > Cheers, > > Paul > > > Signed-off-by: Priit Laes <plaes@plaes.org> > > --- > > arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > > index 9c8eecf4337a..9001b5527615 100644 > > --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > > +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > > @@ -206,6 +206,14 @@ > > > > #include "axp209.dtsi" > > > > +&ac_power_supply { > > + status = "okay"; > > +}; > > + > > +&battery_power_supply { > > + status = "okay"; > > +}; > > + > > ®_dcdc2 { > > regulator-always-on; > > regulator-min-microvolt = <1000000>; > > -- > > 2.11.0 > > > -- > Paul Kocialkowski, Bootlin > Embedded Linux and kernel engineering > https://bootlin.com >
On Tue, May 28, 2019 at 09:35:44AM +0300, Priit Laes wrote: > Lime2 has battery connector so enable these supplies. > > Signed-off-by: Priit Laes <plaes@plaes.org> Applied, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts index 9c8eecf4337a..9001b5527615 100644 --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts @@ -206,6 +206,14 @@ #include "axp209.dtsi" +&ac_power_supply { + status = "okay"; +}; + +&battery_power_supply { + status = "okay"; +}; + ®_dcdc2 { regulator-always-on; regulator-min-microvolt = <1000000>;
Lime2 has battery connector so enable these supplies. Signed-off-by: Priit Laes <plaes@plaes.org> --- arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 8 ++++++++ 1 file changed, 8 insertions(+)