diff mbox series

IB/mlx5: Limit to 64-bit builds

Message ID 1559216144-2085-1-git-send-email-linux@roeck-us.net (mailing list archive)
State Rejected
Delegated to: Jason Gunthorpe
Headers show
Series IB/mlx5: Limit to 64-bit builds | expand

Commit Message

Guenter Roeck May 30, 2019, 11:35 a.m. UTC
32-bit builds fail with errors such as

ERROR: "__udivdi3" [drivers/infiniband/hw/mlx5/mlx5_ib.ko] undefined!

Fixes: 25c13324d03d ("IB/mlx5: Add steering SW ICM device memory type")
Cc: Ariel Levkovich <lariel@mellanox.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/infiniband/hw/mlx5/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Leon Romanovsky May 30, 2019, 12:22 p.m. UTC | #1
On Thu, May 30, 2019 at 04:35:44AM -0700, Guenter Roeck wrote:
> 32-bit builds fail with errors such as
>
> ERROR: "__udivdi3" [drivers/infiniband/hw/mlx5/mlx5_ib.ko] undefined!

It is fixed in rdma-rc.
https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=wip/jgg-for-rc&id=37eb86c4507abcb14fc346863e83aa8751aa4675

Thanks

>
> Fixes: 25c13324d03d ("IB/mlx5: Add steering SW ICM device memory type")
> Cc: Ariel Levkovich <lariel@mellanox.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  drivers/infiniband/hw/mlx5/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/mlx5/Kconfig b/drivers/infiniband/hw/mlx5/Kconfig
> index ea248def4556..574b97da7a43 100644
> --- a/drivers/infiniband/hw/mlx5/Kconfig
> +++ b/drivers/infiniband/hw/mlx5/Kconfig
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  config MLX5_INFINIBAND
>  	tristate "Mellanox 5th generation network adapters (ConnectX series) support"
> -	depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE
> +	depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE && 64BIT
>  	---help---
>  	  This driver provides low-level InfiniBand support for
>  	  Mellanox Connect-IB PCI Express host channel adapters (HCAs).
> --
> 2.7.4
>
Guenter Roeck May 30, 2019, 12:37 p.m. UTC | #2
On 5/30/19 5:22 AM, Leon Romanovsky wrote:
> On Thu, May 30, 2019 at 04:35:44AM -0700, Guenter Roeck wrote:
>> 32-bit builds fail with errors such as
>>
>> ERROR: "__udivdi3" [drivers/infiniband/hw/mlx5/mlx5_ib.ko] undefined!
> 
> It is fixed in rdma-rc.
> https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=wip/jgg-for-rc&id=37eb86c4507abcb14fc346863e83aa8751aa4675
> 

Excellent, and sorry for the noise.

Guenter

> Thanks
> 
>>
>> Fixes: 25c13324d03d ("IB/mlx5: Add steering SW ICM device memory type")
>> Cc: Ariel Levkovich <lariel@mellanox.com>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>>   drivers/infiniband/hw/mlx5/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/infiniband/hw/mlx5/Kconfig b/drivers/infiniband/hw/mlx5/Kconfig
>> index ea248def4556..574b97da7a43 100644
>> --- a/drivers/infiniband/hw/mlx5/Kconfig
>> +++ b/drivers/infiniband/hw/mlx5/Kconfig
>> @@ -1,7 +1,7 @@
>>   # SPDX-License-Identifier: GPL-2.0-only
>>   config MLX5_INFINIBAND
>>   	tristate "Mellanox 5th generation network adapters (ConnectX series) support"
>> -	depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE
>> +	depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE && 64BIT
>>   	---help---
>>   	  This driver provides low-level InfiniBand support for
>>   	  Mellanox Connect-IB PCI Express host channel adapters (HCAs).
>> --
>> 2.7.4
>>
>
diff mbox series

Patch

diff --git a/drivers/infiniband/hw/mlx5/Kconfig b/drivers/infiniband/hw/mlx5/Kconfig
index ea248def4556..574b97da7a43 100644
--- a/drivers/infiniband/hw/mlx5/Kconfig
+++ b/drivers/infiniband/hw/mlx5/Kconfig
@@ -1,7 +1,7 @@ 
 # SPDX-License-Identifier: GPL-2.0-only
 config MLX5_INFINIBAND
 	tristate "Mellanox 5th generation network adapters (ConnectX series) support"
-	depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE
+	depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE && 64BIT
 	---help---
 	  This driver provides low-level InfiniBand support for
 	  Mellanox Connect-IB PCI Express host channel adapters (HCAs).