diff mbox series

[RFC,1/8] nl80211: add 6GHz band definition to enum nl80211_band

Message ID 1558353645-18119-2-git-send-email-arend.vanspriel@broadcom.com (mailing list archive)
State RFC
Delegated to: Johannes Berg
Headers show
Series nl80211: add 6GHz band support | expand

Commit Message

Arend van Spriel May 20, 2019, noon UTC 
In the 802.11ax specification a new band is introduced, which
is also proposed by FCC for unlicensed use. This band is referred
to as 6GHz spanning frequency range from 5925 to 7125 MHz.

Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
Reviewed-by: Leon Zegers <leon.zegers@broadcom.com>
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
---
 include/uapi/linux/nl80211.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jeff Johnson May 30, 2019, 2:53 p.m. UTC | #1 
On 2019-05-20 05:00, Arend van Spriel wrote:
> [...snip...]
>  enum nl80211_band {
>  	NL80211_BAND_2GHZ,
>  	NL80211_BAND_5GHZ,
> +	NL80211_BAND_6GHZ,
>  	NL80211_BAND_60GHZ,
> 
>  	NUM_NL80211_BANDS,

Is it not a concern that this changes the value of NL80211_BAND_60GHZ 
and hence will break any ABI which expects the current value?
Arend van Spriel May 30, 2019, 4:07 p.m. UTC | #2 
On May 30, 2019 4:53:13 PM Jeff Johnson <jjohnson@codeaurora.org> wrote:

> On 2019-05-20 05:00, Arend van Spriel wrote:
>> [...snip...]
>>  enum nl80211_band {
>>  	NL80211_BAND_2GHZ,
>>  	NL80211_BAND_5GHZ,
>> +	NL80211_BAND_6GHZ,
>>  	NL80211_BAND_60GHZ,
>> 
>>  	NUM_NL80211_BANDS,
>
> Is it not a concern that this changes the value of NL80211_BAND_60GHZ
> and hence will break any ABI which expects the current value?

Sigh! Obviously that is a concern. Johannes already mentioned it.

Thanks,
Arend
Jeff Johnson May 30, 2019, 5:43 p.m. UTC | #3 
On 2019-05-30 09:07, Arend Van Spriel wrote:
> Sigh! Obviously that is a concern. Johannes already mentioned it.

Sorry, overlooked his comment on the [0/8] patch. I'll climb back under 
my rock.
Arend van Spriel May 30, 2019, 5:52 p.m. UTC | #4 
On May 30, 2019 7:43:27 PM Jeff Johnson <jjohnson@codeaurora.org> wrote:

> On 2019-05-30 09:07, Arend Van Spriel wrote:
>> Sigh! Obviously that is a concern. Johannes already mentioned it.
>
> Sorry, overlooked his comment on the [0/8] patch. I'll climb back under
> my rock.

No need to do that. It is mainly me feeling stupid about making such a 
mistake that makes me sigh ;-)

Regards,
Arend
diff mbox series

Patch

diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
index 6f09d1500..5ea3c8c 100644
--- a/include/uapi/linux/nl80211.h
+++ b/include/uapi/linux/nl80211.h
@@ -4515,6 +4515,7 @@  enum nl80211_txrate_gi {
  * enum nl80211_band - Frequency band
  * @NL80211_BAND_2GHZ: 2.4 GHz ISM band
  * @NL80211_BAND_5GHZ: around 5 GHz band (4.9 - 5.7 GHz)
+ * @NL80211_BAND_6GHZ: around 6 GHz band (5.9 - 7.2 GHz)
  * @NL80211_BAND_60GHZ: around 60 GHz band (58.32 - 69.12 GHz)
  * @NUM_NL80211_BANDS: number of bands, avoid using this in userspace
  *	since newer kernel versions may support more bands
@@ -4522,6 +4523,7 @@  enum nl80211_txrate_gi {
 enum nl80211_band {
 	NL80211_BAND_2GHZ,
 	NL80211_BAND_5GHZ,
+	NL80211_BAND_6GHZ,
 	NL80211_BAND_60GHZ,
 
 	NUM_NL80211_BANDS,