| Message ID | 20190530190438.9571-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 587a7126779b32a6c8983ae567d987c1a0c7a5dc |
| Headers | show |
| Series | xen-netback: remove redundant assignment to err | expand |
On Thu, May 30, 2019 at 08:04:38PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variable err is assigned with the value -ENOMEM that is never > read and it is re-assigned a new value later on. The assignment is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Acked-by: Wei Liu <wei.liu2@citrix.com> > --- > drivers/net/xen-netback/interface.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c > index 783198844dd7..240f762b3749 100644 > --- a/drivers/net/xen-netback/interface.c > +++ b/drivers/net/xen-netback/interface.c > @@ -633,7 +633,7 @@ int xenvif_connect_data(struct xenvif_queue *queue, > unsigned int rx_evtchn) > { > struct task_struct *task; > - int err = -ENOMEM; > + int err; > > BUG_ON(queue->tx_irq); > BUG_ON(queue->task); > -- > 2.20.1 >
From: Colin King <colin.king@canonical.com> Date: Thu, 30 May 2019 20:04:38 +0100 > From: Colin Ian King <colin.king@canonical.com> > > The variable err is assigned with the value -ENOMEM that is never > read and it is re-assigned a new value later on. The assignment is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Applied to net-next.
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c index 783198844dd7..240f762b3749 100644 --- a/drivers/net/xen-netback/interface.c +++ b/drivers/net/xen-netback/interface.c @@ -633,7 +633,7 @@ int xenvif_connect_data(struct xenvif_queue *queue, unsigned int rx_evtchn) { struct task_struct *task; - int err = -ENOMEM; + int err; BUG_ON(queue->tx_irq); BUG_ON(queue->task);