| Message ID | 20190508073331.27475-1-drinkcat@chromium.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | pinctrl: mediatek: mt8183: Add support for wake sources | expand |
On Wed, May 8, 2019 at 9:33 AM Nicolas Boichat <drinkcat@chromium.org> wrote: > This adds support for wake sources in pinctrl-mtk-common-v2, and > pinctrl-mt8183. Without this patch, all interrupts that are left > enabled on suspend act as wake sources (and wake sources without > interrupt enabled do not). > > Changes since v1: > - Move changes from mtk-common-v2 to mtk-pinctrl-paris, as > recommended by Sean, to keep better separation between eint > and pinctrl-common features. > > Nicolas Boichat (2): > pinctrl: mediatek: Add pm_ops to pinctrl-paris > pinctrl: mediatek: mt8183: Add mtk_pinctrl_paris_pm_ops All seems to look fair to me, but I need some official ACK from Sean on these. I see there is some discussion on a related patch set which also has two patches so I am a but confused how mature the two patch sets are? Are they at all related? Yours, Linus Walleij
On Thu, May 16, 2019 at 7:55 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Wed, May 8, 2019 at 9:33 AM Nicolas Boichat <drinkcat@chromium.org> wrote: > > > This adds support for wake sources in pinctrl-mtk-common-v2, and > > pinctrl-mt8183. Without this patch, all interrupts that are left > > enabled on suspend act as wake sources (and wake sources without > > interrupt enabled do not). > > > > Changes since v1: > > - Move changes from mtk-common-v2 to mtk-pinctrl-paris, as > > recommended by Sean, to keep better separation between eint > > and pinctrl-common features. > > > > Nicolas Boichat (2): > > pinctrl: mediatek: Add pm_ops to pinctrl-paris > > pinctrl: mediatek: mt8183: Add mtk_pinctrl_paris_pm_ops > > All seems to look fair to me, but I need some official ACK from > Sean on these. > > I see there is some discussion on a related patch set which > also has two patches so I am a but confused how mature the > two patch sets are? Are they at all related? They are somewhat related, but I don't think this depends on the other series. This series adds support for wake on mt8183, and makes it similar to, say, mt8173. The other patch series fixes issues that affect all mtk pinctrl variants (i.e. I think mt8173 pinctrl on current mainline has similar issues). It's not impossible that the answer to the other series is that we need to refactor code, but in that case, if we merge this first, we'd just have to clean up one more pinctrl variant. Thanks, > Yours, > Linus Walleij
On Thu, May 16, 2019 at 4:56 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Wed, May 8, 2019 at 9:33 AM Nicolas Boichat <drinkcat@chromium.org> wrote: > > > This adds support for wake sources in pinctrl-mtk-common-v2, and > > pinctrl-mt8183. Without this patch, all interrupts that are left > > enabled on suspend act as wake sources (and wake sources without > > interrupt enabled do not). > > > > Changes since v1: > > - Move changes from mtk-common-v2 to mtk-pinctrl-paris, as > > recommended by Sean, to keep better separation between eint > > and pinctrl-common features. > > > > Nicolas Boichat (2): > > pinctrl: mediatek: Add pm_ops to pinctrl-paris > > pinctrl: mediatek: mt8183: Add mtk_pinctrl_paris_pm_ops > > All seems to look fair to me, but I need some official ACK from > Sean on these. > sure, it looks good to me and thanks for Nicolas' help Acked-by: Sean Wang <sean.wang@kernel.org> > I see there is some discussion on a related patch set which > also has two patches so I am a but confused how mature the > two patch sets are? Are they at all related? > > Yours, > Linus Walleij
On Wed, May 8, 2019 at 9:33 AM Nicolas Boichat <drinkcat@chromium.org> wrote: > This adds support for wake sources in pinctrl-mtk-common-v2, and > pinctrl-mt8183. Without this patch, all interrupts that are left > enabled on suspend act as wake sources (and wake sources without > interrupt enabled do not). > > Changes since v1: > - Move changes from mtk-common-v2 to mtk-pinctrl-paris, as > recommended by Sean, to keep better separation between eint > and pinctrl-common features. Both patches applied with Sean's ACK! Yours, Linus Walleij