| Message ID | 20190509211353.213194-1-gwendal@chromium.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Update cros_ec_commands.h | expand |
Lee, I verified and merged the changes on the kernels (3.18, 4.4 and 4.14) used on chromebook using a squashed version of these patches. (crrev.com/c/1583322, crrev.com/c/1583385, crrev.com/c/1583321 respectively) Please let me know if you have any questions. Thanks, Gwendal. On Thu, May 9, 2019 at 2:14 PM Gwendal Grignou <gwendal@chromium.org> wrote: > > The interface between CrosEC embedded controller and the host, > described by cros_ec_commands.h, as diverged from what the embedded > controller really support. > > The source of thruth is at > https://chromium.googlesource.com/chromiumos/platform/ec/+/master/include/ec_commands.h > > That include file is converted to remove ACPI and Embedded only code. > > From now on, cros_ec_commands.h will be automatically generated from > the file above, do not modify directly. > > Fell free to squash the commits below. > > Changes in v3: > - Rebase after commit 81888d8ab1532 ("mfd: cros_ec: Update the EC feature codes") > - Add Acked-by: Benson Leung <bleung@chromium.org> > > Changes in v2: > - Move I2S changes at the end of the patchset, squashed with change in > sound/soc/codecs/cros_ec_codec.c to match new interface. > - Add Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > > Gwendal Grignou (30): > mfd: cros_ec: Update license term > mfd: cros_ec: Zero BUILD_ macro > mfd: cros_ec: set comments properly > mfd: cros_ec: add ec_align macros > mfd: cros_ec: Define commands as 4-digit UPPER CASE hex values > mfd: cros_ec: use BIT macro > mfd: cros_ec: Update ACPI interface definition > mfd: cros_ec: move HDMI CEC API definition > mfd: cros_ec: Remove zero-size structs > mfd: cros_ec: Add Flash V2 commands API > mfd: cros_ec: Add PWM_SET_DUTY API > mfd: cros_ec: Add lightbar v2 API > mfd: cros_ec: Expand hash API > mfd: cros_ec: Add EC transport protocol v4 > mfd: cros_ec: Complete MEMS sensor API > mfd: cros_ec: Fix event processing API > mfd: cros_ec: Add fingerprint API > mfd: cros_ec: Fix temperature API > mfd: cros_ec: Complete Power and USB PD API > mfd: cros_ec: Add API for keyboard testing > mfd: cros_ec: Add Hibernate API > mfd: cros_ec: Add Smart Battery Firmware update API > mfd: cros_ec: Add I2C passthru protection API > mfd: cros_ec: Add API for EC-EC communication > mfd: cros_ec: Add API for Touchpad support > mfd: cros_ec: Add API for Fingerprint support > mfd: cros_ec: Add API for rwsig > mfd: cros_ec: Add SKU ID and Secure storage API > mfd: cros_ec: Add Management API entry points > mfd: cros_ec: Update I2S API > > include/linux/mfd/cros_ec_commands.h | 3658 ++++++++++++++++++++------ > sound/soc/codecs/cros_ec_codec.c | 8 +- > 2 files changed, 2915 insertions(+), 751 deletions(-) > > -- > 2.21.0.1020.gf2820cf01a-goog >
On Fri, 17 May 2019, Gwendal Grignou wrote: > Lee, > > I verified and merged the changes on the kernels (3.18, 4.4 and 4.14) > used on chromebook using a squashed version of these patches. > (crrev.com/c/1583322, crrev.com/c/1583385, crrev.com/c/1583321 > respectively) > Please let me know if you have any questions. Is no one else from Chromium going to review? These seem like quite important changes.
Le jeudi 09 mai 2019 à 14:13 -0700, Gwendal Grignou a écrit : > The interface between CrosEC embedded controller and the host, > described by cros_ec_commands.h, as diverged from what the embedded > controller really support. > > The source of thruth is at > https://chromium.googlesource.com/chromiumos/platform/ec/+/master/include/ec_commands.h > > That include file is converted to remove ACPI and Embedded only code. Hi, I reviewed patches of the series and they looks good to me. Reviewed-by: Fabien Lahoudere <fabien.lahoudere@collabora.com>
Hi Lee, On Sat, May 18, 2019 at 07:39:49AM +0100, Lee Jones wrote: > On Fri, 17 May 2019, Gwendal Grignou wrote: > > > Lee, > > > > I verified and merged the changes on the kernels (3.18, 4.4 and 4.14) > > used on chromebook using a squashed version of these patches. > > (crrev.com/c/1583322, crrev.com/c/1583385, crrev.com/c/1583321 > > respectively) > > Please let me know if you have any questions. > > Is no one else from Chromium going to review? > > These seem like quite important changes. > I've gone ahead and acked the whole series. Enric and I are OK with this going in for 5.3, and as Gwendal mentioned, he's landed these changes into our production kernels for Chrome OS as well, so this is what we want to sync on. Let me know if you have any other concerns. Thanks, Benson
On Tue, 21 May 2019, Benson Leung wrote: > Hi Lee, > > On Sat, May 18, 2019 at 07:39:49AM +0100, Lee Jones wrote: > > On Fri, 17 May 2019, Gwendal Grignou wrote: > > > > > Lee, > > > > > > I verified and merged the changes on the kernels (3.18, 4.4 and 4.14) > > > used on chromebook using a squashed version of these patches. > > > (crrev.com/c/1583322, crrev.com/c/1583385, crrev.com/c/1583321 > > > respectively) > > > Please let me know if you have any questions. > > > > Is no one else from Chromium going to review? > > > > These seem like quite important changes. > > > > I've gone ahead and acked the whole series. Enric and I are OK with this going > in for 5.3, and as Gwendal mentioned, he's landed these changes into our > production kernels for Chrome OS as well, so this is what we want to sync on. Wonderful, thank you. > Let me know if you have any other concerns. > > Thanks, > Benson >
On Tue, 21 May 2019, Fabien Lahoudere wrote: > Le jeudi 09 mai 2019 à 14:13 -0700, Gwendal Grignou a écrit : > > The interface between CrosEC embedded controller and the host, > > described by cros_ec_commands.h, as diverged from what the embedded > > controller really support. > > > > The source of thruth is at > > https://chromium.googlesource.com/chromiumos/platform/ec/+/master/include/ec_commands.h > > > > That include file is converted to remove ACPI and Embedded only code. > > Hi, > > I reviewed patches of the series and they looks good to me. > > Reviewed-by: Fabien Lahoudere <fabien.lahoudere@collabora.com> Thanks Fabien.
On Thu, 09 May 2019, Gwendal Grignou wrote: > The interface between CrosEC embedded controller and the host, > described by cros_ec_commands.h, as diverged from what the embedded > controller really support. > > The source of thruth is at > https://chromium.googlesource.com/chromiumos/platform/ec/+/master/include/ec_commands.h > > That include file is converted to remove ACPI and Embedded only code. > > From now on, cros_ec_commands.h will be automatically generated from > the file above, do not modify directly. > > Fell free to squash the commits below. > > Changes in v3: > - Rebase after commit 81888d8ab1532 ("mfd: cros_ec: Update the EC feature codes") > - Add Acked-by: Benson Leung <bleung@chromium.org> > > Changes in v2: > - Move I2S changes at the end of the patchset, squashed with change in > sound/soc/codecs/cros_ec_codec.c to match new interface. > - Add Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > > Gwendal Grignou (30): > mfd: cros_ec: Update license term > mfd: cros_ec: Zero BUILD_ macro > mfd: cros_ec: set comments properly > mfd: cros_ec: add ec_align macros > mfd: cros_ec: Define commands as 4-digit UPPER CASE hex values > mfd: cros_ec: use BIT macro > mfd: cros_ec: Update ACPI interface definition > mfd: cros_ec: move HDMI CEC API definition > mfd: cros_ec: Remove zero-size structs > mfd: cros_ec: Add Flash V2 commands API > mfd: cros_ec: Add PWM_SET_DUTY API > mfd: cros_ec: Add lightbar v2 API > mfd: cros_ec: Expand hash API > mfd: cros_ec: Add EC transport protocol v4 > mfd: cros_ec: Complete MEMS sensor API > mfd: cros_ec: Fix event processing API > mfd: cros_ec: Add fingerprint API > mfd: cros_ec: Fix temperature API > mfd: cros_ec: Complete Power and USB PD API > mfd: cros_ec: Add API for keyboard testing > mfd: cros_ec: Add Hibernate API > mfd: cros_ec: Add Smart Battery Firmware update API > mfd: cros_ec: Add I2C passthru protection API > mfd: cros_ec: Add API for EC-EC communication > mfd: cros_ec: Add API for Touchpad support > mfd: cros_ec: Add API for Fingerprint support > mfd: cros_ec: Add API for rwsig > mfd: cros_ec: Add SKU ID and Secure storage API > mfd: cros_ec: Add Management API entry points > mfd: cros_ec: Update I2S API > > include/linux/mfd/cros_ec_commands.h | 3658 ++++++++++++++++++++------ > sound/soc/codecs/cros_ec_codec.c | 8 +- > 2 files changed, 2915 insertions(+), 751 deletions(-) Okay, I'm ready to apply this now. Could you collect all of the Acks you received and submit a RESEND please?
The interface between CrosEC embedded controller and the host, described by cros_ec_commands.h, as diverged from what the embedded controller really support. The source of thruth is at https://chromium.googlesource.com/chromiumos/platform/ec/+/master/include/ec_commands.h That include file is converted to remove ACPI and Embedded only code. From now on, cros_ec_commands.h will be automatically generated from the file above, do not modify directly. Fell free to squash the commits below. Changes in v3: - Rebase after commit 81888d8ab1532 ("mfd: cros_ec: Update the EC feature codes") - Add Acked-by: Benson Leung <bleung@chromium.org> Changes in v2: - Move I2S changes at the end of the patchset, squashed with change in sound/soc/codecs/cros_ec_codec.c to match new interface. - Add Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> Gwendal Grignou (30): mfd: cros_ec: Update license term mfd: cros_ec: Zero BUILD_ macro mfd: cros_ec: set comments properly mfd: cros_ec: add ec_align macros mfd: cros_ec: Define commands as 4-digit UPPER CASE hex values mfd: cros_ec: use BIT macro mfd: cros_ec: Update ACPI interface definition mfd: cros_ec: move HDMI CEC API definition mfd: cros_ec: Remove zero-size structs mfd: cros_ec: Add Flash V2 commands API mfd: cros_ec: Add PWM_SET_DUTY API mfd: cros_ec: Add lightbar v2 API mfd: cros_ec: Expand hash API mfd: cros_ec: Add EC transport protocol v4 mfd: cros_ec: Complete MEMS sensor API mfd: cros_ec: Fix event processing API mfd: cros_ec: Add fingerprint API mfd: cros_ec: Fix temperature API mfd: cros_ec: Complete Power and USB PD API mfd: cros_ec: Add API for keyboard testing mfd: cros_ec: Add Hibernate API mfd: cros_ec: Add Smart Battery Firmware update API mfd: cros_ec: Add I2C passthru protection API mfd: cros_ec: Add API for EC-EC communication mfd: cros_ec: Add API for Touchpad support mfd: cros_ec: Add API for Fingerprint support mfd: cros_ec: Add API for rwsig mfd: cros_ec: Add SKU ID and Secure storage API mfd: cros_ec: Add Management API entry points mfd: cros_ec: Update I2S API include/linux/mfd/cros_ec_commands.h | 3658 ++++++++++++++++++++------ sound/soc/codecs/cros_ec_codec.c | 8 +- 2 files changed, 2915 insertions(+), 751 deletions(-)