| Message ID | 20190531092101.28772-2-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | [1/2,next] RDMA/hns: fix comparison of unsigned long variable 'end' with less than zero | expand |
On Fri, May 31, 2019 at 10:21:01AM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > A previous change incorrectly changed the inverted logic and logically > negated the readl rather than the shifted readl result. Fix this by > adding in missing parentheses around the expression that needs to be > logically negated. > > Addresses-Coverity: ("Logically dead code") > Fixes: 669cefb654cb ("RDMA/hns: Remove jiffies operation in disable interrupt context") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/infiniband/hw/hns/hns_roce_hem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to for-next, thanks Jason
diff --git a/drivers/infiniband/hw/hns/hns_roce_hem.c b/drivers/infiniband/hw/hns/hns_roce_hem.c index b3641aeff27a..a8e9329cbf4e 100644 --- a/drivers/infiniband/hw/hns/hns_roce_hem.c +++ b/drivers/infiniband/hw/hns/hns_roce_hem.c @@ -378,7 +378,7 @@ static int hns_roce_set_hem(struct hns_roce_dev *hr_dev, end = HW_SYNC_TIMEOUT_MSECS; while (end > 0) { - if (!readl(bt_cmd) >> BT_CMD_SYNC_SHIFT) + if (!(readl(bt_cmd) >> BT_CMD_SYNC_SHIFT)) break; mdelay(HW_SYNC_SLEEP_TIME_INTERVAL);