| Message ID | 20190607085643.932-2-srinivas.kandagatla@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soundwire: Add support to Qualcomm SoundWire master | expand |
On 2019-06-07 10:56, Srinivas Kandagatla wrote: > On platforms which have smart speaker amplifiers connected via > soundwire and modeled as aux devices in ASoC, in such usecases machine > driver should be able to get sdw master stream from dai so that it can > use the runtime stream to setup slave streams. > > soundwire already as a set function, get function would provide more > flexibility to above configurations. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > include/sound/soc-dai.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/sound/soc-dai.h b/include/sound/soc-dai.h > index f5d70041108f..9f90b936fd9a 100644 > --- a/include/sound/soc-dai.h > +++ b/include/sound/soc-dai.h > @@ -177,6 +177,7 @@ struct snd_soc_dai_ops { > > int (*set_sdw_stream)(struct snd_soc_dai *dai, > void *stream, int direction); > + void *(*get_sdw_stream)(struct snd_soc_dai *dai, int direction); > /* > * DAI digital mute - optional. > * Called by soc-core to minimise any pops. > @@ -385,4 +386,13 @@ static inline int snd_soc_dai_set_sdw_stream(struct snd_soc_dai *dai, > return -ENOTSUPP; > } > > +static inline void *snd_soc_dai_get_sdw_stream(struct snd_soc_dai *dai, int direction) Exceeds character limit? > +{ > + if (dai->driver->ops->get_sdw_stream) > + return dai->driver->ops->get_sdw_stream(dai, direction); > + else > + return NULL; set_ equivalent returns -ENOTSUPP instead. ERR_PTR seems to make more sense here. > + Unnecessary newline. > +} > + > #endif >
Thanks for taking time to review, On 08/06/2019 20:22, Cezary Rojewski wrote: > On 2019-06-07 10:56, Srinivas Kandagatla wrote: >> On platforms which have smart speaker amplifiers connected via >> soundwire and modeled as aux devices in ASoC, in such usecases machine >> driver should be able to get sdw master stream from dai so that it can >> use the runtime stream to setup slave streams. >> >> soundwire already as a set function, get function would provide more >> flexibility to above configurations. >> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> --- >> include/sound/soc-dai.h | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/include/sound/soc-dai.h b/include/sound/soc-dai.h >> index f5d70041108f..9f90b936fd9a 100644 >> --- a/include/sound/soc-dai.h >> +++ b/include/sound/soc-dai.h >> @@ -177,6 +177,7 @@ struct snd_soc_dai_ops { >> int (*set_sdw_stream)(struct snd_soc_dai *dai, >> void *stream, int direction); >> + void *(*get_sdw_stream)(struct snd_soc_dai *dai, int direction); >> /* >> * DAI digital mute - optional. >> * Called by soc-core to minimise any pops. >> @@ -385,4 +386,13 @@ static inline int >> snd_soc_dai_set_sdw_stream(struct snd_soc_dai *dai, >> return -ENOTSUPP; >> } >> +static inline void *snd_soc_dai_get_sdw_stream(struct snd_soc_dai >> *dai, int direction) > > Exceeds character limit? > >> +{ >> + if (dai->driver->ops->get_sdw_stream) >> + return dai->driver->ops->get_sdw_stream(dai, direction); >> + else >> + return NULL; > > set_ equivalent returns -ENOTSUPP instead. > ERR_PTR seems to make more sense here. > >> + > > Unnecessary newline. I agree with all the comment, will fix this in next version. thanks, srini > >> +} >> + >> #endif >>
On 07-06-19, 09:56, Srinivas Kandagatla wrote: > On platforms which have smart speaker amplifiers connected via > soundwire and modeled as aux devices in ASoC, in such usecases machine > driver should be able to get sdw master stream from dai so that it can > use the runtime stream to setup slave streams. > > soundwire already as a set function, get function would provide more > flexibility to above configurations. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > include/sound/soc-dai.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/sound/soc-dai.h b/include/sound/soc-dai.h > index f5d70041108f..9f90b936fd9a 100644 > --- a/include/sound/soc-dai.h > +++ b/include/sound/soc-dai.h > @@ -177,6 +177,7 @@ struct snd_soc_dai_ops { > > int (*set_sdw_stream)(struct snd_soc_dai *dai, > void *stream, int direction); > + void *(*get_sdw_stream)(struct snd_soc_dai *dai, int direction); So who would be calling this API? Machine or someone else?
On 10/06/2019 05:34, Vinod Koul wrote: > On 07-06-19, 09:56, Srinivas Kandagatla wrote: >> On platforms which have smart speaker amplifiers connected via >> soundwire and modeled as aux devices in ASoC, in such usecases machine >> driver should be able to get sdw master stream from dai so that it can >> use the runtime stream to setup slave streams. >> >> soundwire already as a set function, get function would provide more >> flexibility to above configurations. >> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> --- >> include/sound/soc-dai.h | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/include/sound/soc-dai.h b/include/sound/soc-dai.h >> index f5d70041108f..9f90b936fd9a 100644 >> --- a/include/sound/soc-dai.h >> +++ b/include/sound/soc-dai.h >> @@ -177,6 +177,7 @@ struct snd_soc_dai_ops { >> >> int (*set_sdw_stream)(struct snd_soc_dai *dai, >> void *stream, int direction); >> + void *(*get_sdw_stream)(struct snd_soc_dai *dai, int direction); > > So who would be calling this API? Machine or someone else? From Machine driver in my case where smart speaker amplifiers are modeled as aux device which is also dai less. --srini >
diff --git a/include/sound/soc-dai.h b/include/sound/soc-dai.h index f5d70041108f..9f90b936fd9a 100644 --- a/include/sound/soc-dai.h +++ b/include/sound/soc-dai.h @@ -177,6 +177,7 @@ struct snd_soc_dai_ops { int (*set_sdw_stream)(struct snd_soc_dai *dai, void *stream, int direction); + void *(*get_sdw_stream)(struct snd_soc_dai *dai, int direction); /* * DAI digital mute - optional. * Called by soc-core to minimise any pops. @@ -385,4 +386,13 @@ static inline int snd_soc_dai_set_sdw_stream(struct snd_soc_dai *dai, return -ENOTSUPP; } +static inline void *snd_soc_dai_get_sdw_stream(struct snd_soc_dai *dai, int direction) +{ + if (dai->driver->ops->get_sdw_stream) + return dai->driver->ops->get_sdw_stream(dai, direction); + else + return NULL; + +} + #endif
On platforms which have smart speaker amplifiers connected via soundwire and modeled as aux devices in ASoC, in such usecases machine driver should be able to get sdw master stream from dai so that it can use the runtime stream to setup slave streams. soundwire already as a set function, get function would provide more flexibility to above configurations. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> --- include/sound/soc-dai.h | 10 ++++++++++ 1 file changed, 10 insertions(+)