| Message ID | 20190610024254.9830-1-tytso@mit.edu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ext4/035: skip this test if DAX is in use | expand |
On Sun, Jun 09, 2019 at 10:42:54PM -0400, Theodore Ts'o wrote: > This test creates a file system with a 1k block size. Since there are > no architectures with a 1k page size, test file system can never be s/test file system/the test file system/ > mounted with DAX enabled, causing the test to fail. Sorry, typo. - Ted
on 2019/06/10 10:53, Theodore Ts'o wrote: > On Sun, Jun 09, 2019 at 10:42:54PM -0400, Theodore Ts'o wrote: >> This test creates a file system with a 1k block size. Since there are >> no architectures with a 1k page size, test file system can never be > s/test file system/the test file system/ > >> mounted with DAX enabled, causing the test to fail. Looks good to me. Feel free to add: Reviewed-by: Yang Xu<xuyang2018.jy@cn.fujitsu.com> > Sorry, typo. > > - Ted > > >
diff --git a/tests/ext4/035 b/tests/ext4/035 index ac5f38e0..05867402 100755 --- a/tests/ext4/035 +++ b/tests/ext4/035 @@ -36,6 +36,7 @@ _cleanup() _supported_fs ext4 _supported_os Linux _require_scratch +_exclude_scratch_mount_option dax _require_command "$RESIZE2FS_PROG" resize2fs rm -f $seqres.full
This test creates a file system with a 1k block size. Since there are no architectures with a 1k page size, test file system can never be mounted with DAX enabled, causing the test to fail. Signed-off-by: Theodore Ts'o <tytso@mit.edu> Cc: Yang Xu <xuyang2018.jy@cn.fujitsu.com> --- tests/ext4/035 | 1 + 1 file changed, 1 insertion(+)