| Message ID | 1560053972-32273-1-git-send-email-agross@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0763d0c2273a3c72247d325c48fbac3d918d6b87 |
| Headers | show |
| Series | arm64: qcom: qcs404: Add reset-cells to GCC node | expand |
On Sat, Jun 08, 2019 at 11:19:32PM -0500, Andy Gross wrote: > This patch adds a reset-cells property to the gcc controller on the QCS404. > Without this in place, we get warnings like the following if nodes reference > a gcc reset: > > arch/arm64/boot/dts/qcom/qcs404.dtsi:261.38-310.5: Warning (resets_property): > /soc@0/remoteproc@b00000: Missing property '#reset-cells' in node > /soc@0/clock-controller@1800000 or bad phandle (referred from resets[0]) > also defined at arch/arm64/boot/dts/qcom/qcs404-evb.dtsi:82.18-84.3 > DTC arch/arm64/boot/dts/qcom/qcs404-evb-4000.dtb > arch/arm64/boot/dts/qcom/qcs404.dtsi:261.38-310.5: Warning (resets_property): > /soc@0/remoteproc@b00000: Missing property '#reset-cells' in node > /soc@0/clock-controller@1800000 or bad phandle (referred from resets[0]) > also defined at arch/arm64/boot/dts/qcom/qcs404-evb.dtsi:82.18-84.3 > > Signed-off-by: Andy Gross <agross@kernel.org> > --- > arch/arm64/boot/dts/qcom/qcs404.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi > index 342788a..086cadb 100644 > --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi > +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi > @@ -426,6 +426,7 @@ > compatible = "qcom,gcc-qcs404"; > reg = <0x01800000 0x80000>; > #clock-cells = <1>; > + #reset-cells = <1>; > > assigned-clocks = <&gcc GCC_APSS_AHB_CLK_SRC>; > assigned-clock-rates = <19200000>; > -- > 2.7.4 > Reviewed-by: Niklas Cassel <niklas.cassel@linaro.org>
On 08-06-19, 23:19, Andy Gross wrote: > This patch adds a reset-cells property to the gcc controller on the QCS404. > Without this in place, we get warnings like the following if nodes reference > a gcc reset: > > arch/arm64/boot/dts/qcom/qcs404.dtsi:261.38-310.5: Warning (resets_property): > /soc@0/remoteproc@b00000: Missing property '#reset-cells' in node > /soc@0/clock-controller@1800000 or bad phandle (referred from resets[0]) > also defined at arch/arm64/boot/dts/qcom/qcs404-evb.dtsi:82.18-84.3 > DTC arch/arm64/boot/dts/qcom/qcs404-evb-4000.dtb > arch/arm64/boot/dts/qcom/qcs404.dtsi:261.38-310.5: Warning (resets_property): > /soc@0/remoteproc@b00000: Missing property '#reset-cells' in node > /soc@0/clock-controller@1800000 or bad phandle (referred from resets[0]) > also defined at arch/arm64/boot/dts/qcom/qcs404-evb.dtsi:82.18-84.3 Reviewed-by: Vinod Koul <vkoul@kernel.org>
On Sat, Jun 08, 2019 at 11:19:32PM -0500, Andy Gross wrote: > This patch adds a reset-cells property to the gcc controller on the QCS404. > Without this in place, we get warnings like the following if nodes reference > a gcc reset: > > arch/arm64/boot/dts/qcom/qcs404.dtsi:261.38-310.5: Warning (resets_property): > /soc@0/remoteproc@b00000: Missing property '#reset-cells' in node > /soc@0/clock-controller@1800000 or bad phandle (referred from resets[0]) > also defined at arch/arm64/boot/dts/qcom/qcs404-evb.dtsi:82.18-84.3 > DTC arch/arm64/boot/dts/qcom/qcs404-evb-4000.dtb > arch/arm64/boot/dts/qcom/qcs404.dtsi:261.38-310.5: Warning (resets_property): > /soc@0/remoteproc@b00000: Missing property '#reset-cells' in node > /soc@0/clock-controller@1800000 or bad phandle (referred from resets[0]) > also defined at arch/arm64/boot/dts/qcom/qcs404-evb.dtsi:82.18-84.3 > > Signed-off-by: Andy Gross <agross@kernel.org> Applied to arm/dt. Thanks! -Olof
diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi index 342788a..086cadb 100644 --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi @@ -426,6 +426,7 @@ compatible = "qcom,gcc-qcs404"; reg = <0x01800000 0x80000>; #clock-cells = <1>; + #reset-cells = <1>; assigned-clocks = <&gcc GCC_APSS_AHB_CLK_SRC>; assigned-clock-rates = <19200000>;
This patch adds a reset-cells property to the gcc controller on the QCS404. Without this in place, we get warnings like the following if nodes reference a gcc reset: arch/arm64/boot/dts/qcom/qcs404.dtsi:261.38-310.5: Warning (resets_property): /soc@0/remoteproc@b00000: Missing property '#reset-cells' in node /soc@0/clock-controller@1800000 or bad phandle (referred from resets[0]) also defined at arch/arm64/boot/dts/qcom/qcs404-evb.dtsi:82.18-84.3 DTC arch/arm64/boot/dts/qcom/qcs404-evb-4000.dtb arch/arm64/boot/dts/qcom/qcs404.dtsi:261.38-310.5: Warning (resets_property): /soc@0/remoteproc@b00000: Missing property '#reset-cells' in node /soc@0/clock-controller@1800000 or bad phandle (referred from resets[0]) also defined at arch/arm64/boot/dts/qcom/qcs404-evb.dtsi:82.18-84.3 Signed-off-by: Andy Gross <agross@kernel.org> --- arch/arm64/boot/dts/qcom/qcs404.dtsi | 1 + 1 file changed, 1 insertion(+)