| Message ID | 20190604072340.12224-1-damien.lemoal@wdc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block: force select mq-deadline for zoned block devices | expand |
On 2019/06/04 16:23, Damien Le Moal wrote: > In most use cases of zoned block devices (aka SMR disks), the > mq-deadline scheduler is mandatory as it implements sequential write > command processing guarantees with zone write locking. So make sure that > this scheduler is always enabled if CONFIG_BLK_DEV_ZONED is selected. > > Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> > --- > block/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/block/Kconfig b/block/Kconfig > index 1b220101a9cb..2466dcc3ef1d 100644 > --- a/block/Kconfig > +++ b/block/Kconfig > @@ -73,6 +73,7 @@ config BLK_DEV_INTEGRITY > > config BLK_DEV_ZONED > bool "Zoned block device support" > + select MQ_IOSCHED_DEADLINE > ---help--- > Block layer zoned block device support. This option enables > support for ZAC/ZBC host-managed and host-aware zoned block devices. > Ping... Any comment on this one ?
Looks good to me, I did make sure that when selecting ZBD option from menuconfig MQ gets selected automatically, from make menuconfig command. Tested-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> On 06/11/2019 02:31 AM, Damien Le Moal wrote: > On 2019/06/04 16:23, Damien Le Moal wrote: >> In most use cases of zoned block devices (aka SMR disks), the >> mq-deadline scheduler is mandatory as it implements sequential write >> command processing guarantees with zone write locking. So make sure that >> this scheduler is always enabled if CONFIG_BLK_DEV_ZONED is selected. >> >> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> >> --- >> block/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/block/Kconfig b/block/Kconfig >> index 1b220101a9cb..2466dcc3ef1d 100644 >> --- a/block/Kconfig >> +++ b/block/Kconfig >> @@ -73,6 +73,7 @@ config BLK_DEV_INTEGRITY >> >> config BLK_DEV_ZONED >> bool "Zoned block device support" >> + select MQ_IOSCHED_DEADLINE >> ---help--- >> Block layer zoned block device support. This option enables >> support for ZAC/ZBC host-managed and host-aware zoned block devices. >> > > Ping... Any comment on this one ? > >
On Tue, Jun 4, 2019 at 3:24 PM Damien Le Moal <damien.lemoal@wdc.com> wrote: > > In most use cases of zoned block devices (aka SMR disks), the > mq-deadline scheduler is mandatory as it implements sequential write > command processing guarantees with zone write locking. So make sure that > this scheduler is always enabled if CONFIG_BLK_DEV_ZONED is selected. > > Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> > --- > block/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/block/Kconfig b/block/Kconfig > index 1b220101a9cb..2466dcc3ef1d 100644 > --- a/block/Kconfig > +++ b/block/Kconfig > @@ -73,6 +73,7 @@ config BLK_DEV_INTEGRITY > > config BLK_DEV_ZONED > bool "Zoned block device support" > + select MQ_IOSCHED_DEADLINE > ---help--- > Block layer zoned block device support. This option enables > support for ZAC/ZBC host-managed and host-aware zoned block devices. > -- > 2.21.0 > Looks fine: Reviewed-by: Ming Lei <ming.lei@redhat.com>
On 6/4/19 1:23 AM, Damien Le Moal wrote: > In most use cases of zoned block devices (aka SMR disks), the > mq-deadline scheduler is mandatory as it implements sequential write > command processing guarantees with zone write locking. So make sure that > this scheduler is always enabled if CONFIG_BLK_DEV_ZONED is selected. Applied, thanks.
diff --git a/block/Kconfig b/block/Kconfig index 1b220101a9cb..2466dcc3ef1d 100644 --- a/block/Kconfig +++ b/block/Kconfig @@ -73,6 +73,7 @@ config BLK_DEV_INTEGRITY config BLK_DEV_ZONED bool "Zoned block device support" + select MQ_IOSCHED_DEADLINE ---help--- Block layer zoned block device support. This option enables support for ZAC/ZBC host-managed and host-aware zoned block devices.
In most use cases of zoned block devices (aka SMR disks), the mq-deadline scheduler is mandatory as it implements sequential write command processing guarantees with zone write locking. So make sure that this scheduler is always enabled if CONFIG_BLK_DEV_ZONED is selected. Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> --- block/Kconfig | 1 + 1 file changed, 1 insertion(+)