| Message ID | a709f57d-6909-8550-3932-d84e0b5bc3ef@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [GIT,PULL] omapdrm changes for 5.3 | expand |
On Tue, Jun 11, 2019 at 11:05:40AM +0300, Tomi Valkeinen wrote: > Hi Dave, > > Please pull omapdrm changes for 5.3. > > Tomi > > The following changes since commit 396f9acaffd87e44b8b02bc60f06dc949b832b7e: > > Merge branch 'drm-next-5.3' of git://people.freedesktop.org/~agd5f/linux into drm-next (2019-06-06 14:28:26 +1000) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git tags/omapdrm-5.3 > > for you to fetch changes up to 1bb418bffdd6f95a41e8e59be63933bc84fde13c: > > drm/omap: add support for manually updated displays (2019-06-10 17:04:15 +0300) > > ---------------------------------------------------------------- > omapdrm changes for 5.3 > > - Add support for DSI command mode displays Thanks, pulled. > > ---------------------------------------------------------------- > Emil Velikov (1): > drm/omap: remove open-coded drm_invalid_op() > > Kefeng Wang (1): > drm/omap: Use dev_get_drvdata() > > Sebastian Reichel (4): > drm/omap: use DRM_DEBUG_DRIVER instead of CORE > drm/omap: don't check dispc timings for DSI > drm/omap: add framedone interrupt support > drm/omap: add support for manually updated displays This seems to reinvent drm_atomic_helper_dirty(), I've cc'ed you on a doc patch. Also the fbdev dirty stuff seems to be missing here, you might want to look at Noralf's generic fbdev stuff to take care of all of this for you. Cheers, Daniel > > Thomas Meyer (1): > drm/omap: Make sure device_id tables are NULL terminated > > drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 18 +-- > drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c | 1 + > drivers/gpu/drm/omapdrm/omap_crtc.c | 180 ++++++++++++++++++++++-- > drivers/gpu/drm/omapdrm/omap_crtc.h | 2 + > drivers/gpu/drm/omapdrm/omap_drv.c | 16 +-- > drivers/gpu/drm/omapdrm/omap_drv.h | 4 +- > drivers/gpu/drm/omapdrm/omap_fb.c | 19 +++ > drivers/gpu/drm/omapdrm/omap_irq.c | 25 ++++ > drivers/gpu/drm/omapdrm/omap_irq.h | 1 + > 9 files changed, 228 insertions(+), 38 deletions(-) > > > -- > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Hi Daniel, On Tue, Jun 11, 2019 at 01:30:51PM +0200, Daniel Vetter wrote: > On Tue, Jun 11, 2019 at 11:05:40AM +0300, Tomi Valkeinen wrote: > > Hi Dave, > > > > Please pull omapdrm changes for 5.3. > > > > Tomi > > > > The following changes since commit 396f9acaffd87e44b8b02bc60f06dc949b832b7e: > > > > Merge branch 'drm-next-5.3' of git://people.freedesktop.org/~agd5f/linux into drm-next (2019-06-06 14:28:26 +1000) > > > > are available in the Git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git tags/omapdrm-5.3 > > > > for you to fetch changes up to 1bb418bffdd6f95a41e8e59be63933bc84fde13c: > > > > drm/omap: add support for manually updated displays (2019-06-10 17:04:15 +0300) > > > > ---------------------------------------------------------------- > > omapdrm changes for 5.3 > > > > - Add support for DSI command mode displays > > Thanks, pulled. Finally :) > > ---------------------------------------------------------------- > > Emil Velikov (1): > > drm/omap: remove open-coded drm_invalid_op() > > > > Kefeng Wang (1): > > drm/omap: Use dev_get_drvdata() > > > > Sebastian Reichel (4): > > drm/omap: use DRM_DEBUG_DRIVER instead of CORE > > drm/omap: don't check dispc timings for DSI > > drm/omap: add framedone interrupt support > > drm/omap: add support for manually updated displays > > This seems to reinvent drm_atomic_helper_dirty(), I've cc'ed you on a doc > patch. Also the fbdev dirty stuff seems to be missing here, you might want > to look at Noralf's generic fbdev stuff to take care of all of this for > you. Thanks, I already noticed the patch series adding this, but did not yet find enough time to check the details. The omapdrm patches predate this work. The plan was to get the above work merged first, so that it's easier to catch regressions and unblock community work on Droid 4. My plan was to first convert the DSI part from omapdrm to use mipi_dsi_device and drm_panel API and then look at drm_atomic_helper_dirtyfb afterwards. -- Sebastian
On Tue, Jun 11, 2019 at 06:19:21PM +0200, Sebastian Reichel wrote: > Hi Daniel, > > On Tue, Jun 11, 2019 at 01:30:51PM +0200, Daniel Vetter wrote: > > On Tue, Jun 11, 2019 at 11:05:40AM +0300, Tomi Valkeinen wrote: > > > Hi Dave, > > > > > > Please pull omapdrm changes for 5.3. > > > > > > Tomi > > > > > > The following changes since commit 396f9acaffd87e44b8b02bc60f06dc949b832b7e: > > > > > > Merge branch 'drm-next-5.3' of git://people.freedesktop.org/~agd5f/linux into drm-next (2019-06-06 14:28:26 +1000) > > > > > > are available in the Git repository at: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git tags/omapdrm-5.3 > > > > > > for you to fetch changes up to 1bb418bffdd6f95a41e8e59be63933bc84fde13c: > > > > > > drm/omap: add support for manually updated displays (2019-06-10 17:04:15 +0300) > > > > > > ---------------------------------------------------------------- > > > omapdrm changes for 5.3 > > > > > > - Add support for DSI command mode displays > > > > Thanks, pulled. > > Finally :) Hm why? Pull is less than a day old, and I didn't see an older one that Dave or me missed ... > > > ---------------------------------------------------------------- > > > Emil Velikov (1): > > > drm/omap: remove open-coded drm_invalid_op() > > > > > > Kefeng Wang (1): > > > drm/omap: Use dev_get_drvdata() > > > > > > Sebastian Reichel (4): > > > drm/omap: use DRM_DEBUG_DRIVER instead of CORE > > > drm/omap: don't check dispc timings for DSI > > > drm/omap: add framedone interrupt support > > > drm/omap: add support for manually updated displays > > > > This seems to reinvent drm_atomic_helper_dirty(), I've cc'ed you on a doc > > patch. Also the fbdev dirty stuff seems to be missing here, you might want > > to look at Noralf's generic fbdev stuff to take care of all of this for > > you. > > Thanks, I already noticed the patch series adding this, but did not > yet find enough time to check the details. The omapdrm patches > predate this work. The plan was to get the above work merged first, > so that it's easier to catch regressions and unblock community work > on Droid 4. > > My plan was to first convert the DSI part from omapdrm to use > mipi_dsi_device and drm_panel API and then look at drm_atomic_helper_dirtyfb > afterwards. Using drm_atomic_helper_dirty should essentially be a "remove a pile of lines, replace with one" kind of patch. For an example, see the one Gerd just posted for virtio. It's pretty low-hanging fruit :-) I think the bigger fish to fry is switching over to the generic fbdev emulation. -Daniel
On 11/06/2019 20:36, Daniel Vetter wrote: >>>> omapdrm changes for 5.3 >>>> >>>> - Add support for DSI command mode displays >>> >>> Thanks, pulled. >> >> Finally :) > > Hm why? Pull is less than a day old, and I didn't see an older one that > Dave or me missed ... That was directed at me =). I've been reluctant to merge the DSI command mode support, as it's based on the omapdrm specific driver model, instead of drm bridges/panels. Especially as Laurent has been creating huge patch serieses converting omapdrm to the drm bridge/panel model, I've been worried about conflicts and making Laurent's work more difficult. So... The DSI command mode series has been floating around for a long time. Tomi
Hi Dave, Please pull omapdrm changes for 5.3. Tomi The following changes since commit 396f9acaffd87e44b8b02bc60f06dc949b832b7e: Merge branch 'drm-next-5.3' of git://people.freedesktop.org/~agd5f/linux into drm-next (2019-06-06 14:28:26 +1000) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git tags/omapdrm-5.3 for you to fetch changes up to 1bb418bffdd6f95a41e8e59be63933bc84fde13c: drm/omap: add support for manually updated displays (2019-06-10 17:04:15 +0300) ---------------------------------------------------------------- omapdrm changes for 5.3 - Add support for DSI command mode displays ---------------------------------------------------------------- Emil Velikov (1): drm/omap: remove open-coded drm_invalid_op() Kefeng Wang (1): drm/omap: Use dev_get_drvdata() Sebastian Reichel (4): drm/omap: use DRM_DEBUG_DRIVER instead of CORE drm/omap: don't check dispc timings for DSI drm/omap: add framedone interrupt support drm/omap: add support for manually updated displays Thomas Meyer (1): drm/omap: Make sure device_id tables are NULL terminated drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 18 +-- drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c | 1 + drivers/gpu/drm/omapdrm/omap_crtc.c | 180 ++++++++++++++++++++++-- drivers/gpu/drm/omapdrm/omap_crtc.h | 2 + drivers/gpu/drm/omapdrm/omap_drv.c | 16 +-- drivers/gpu/drm/omapdrm/omap_drv.h | 4 +- drivers/gpu/drm/omapdrm/omap_fb.c | 19 +++ drivers/gpu/drm/omapdrm/omap_irq.c | 25 ++++ drivers/gpu/drm/omapdrm/omap_irq.h | 1 + 9 files changed, 228 insertions(+), 38 deletions(-)