[0/2] Improve test code coverage on jt/partial-clone-missing-ref-delta-base

Message

Jonathan Tan June 11, 2019, 9:06 p.m. UTC

This series is on jt/partial-clone-missing-ref-delta-base.

Patch 1 is a cleanup, and patch 2 improves test code coverage. Thanks to
Stolee for the code coverage report.

I have checked this by running `make coverage` then `make cover_db_html`
on both "next" and this series, and comparing the output - the
relevant line indeed shows up as uncovered on "next", and covered on
this.

Jonathan Tan (2):
  t5616: use correct flag to check object is missing
  t5616: cover case of client having delta base

 t/t5616-partial-clone.sh | 41 ++++++++++++++++++++++++++++------------
 1 file changed, 29 insertions(+), 12 deletions(-)

Comments

Derrick Stolee June 12, 2019, 2:39 a.m. UTC | #1

On 6/11/2019 5:06 PM, Jonathan Tan wrote:
> This series is on jt/partial-clone-missing-ref-delta-base.
> 
> Patch 1 is a cleanup, and patch 2 improves test code coverage. Thanks to
> Stolee for the code coverage report.
> 
> I have checked this by running `make coverage` then `make cover_db_html`
> on both "next" and this series, and comparing the output - the
> relevant line indeed shows up as uncovered on "next", and covered on
> this.

Thanks for the additional tests, Jonathan! The update in PATCH 2 looks
like it took a bit of work, so thanks for your efforts there!

LGTM.

-Stolee