| Message ID | 1559804984-24698-1-git-send-email-kelvin.cao@microchip.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Redundant steps removal and bug fix of ntb_hw_switchtec | expand |
On Thu, Jun 06, 2019 at 03:09:41PM +0800, Kelvin Cao wrote: > Hi, Everyone, > > This patch series remove redundant steps and fix one bug of the > ntb_hw_switchtec module. > > When a re-initialization is caused by a link event, the driver will > re-setup the shared memory windows. But at that time, the shared memory > is still valid, and it's unnecessary to free, reallocate and then > initialize it again. Remove these redundant steps. > > In case of NTB crosslink topology, the setting of shared memory window > in the virtual partition doesn't reset on peer's reboot. So skip the > re-setup of shared memory window for that case. > > Switchtec does not support setting multiple MWs simultaneously. However, > there's a race condition when a re-initialization is caused by a link > event, the driver will re-setup the shared memory window asynchronously > and this races with the client setting up its memory windows on the > link up event. Fix this by ensure do the entire initialization in a work > queue and signal the client once it's done. > > Regard, > Kelvin > > -- > > Changed since v1: > - It's a second resend of v1 Sorry for the delay. The series is now in the ntb branch. We've missed window for 5.2, but it will be in the 5.3 pull request. Thanks, Jon > -- > > Joey Zhang (2): > ntb_hw_switchtec: Remove redundant steps of > switchtec_ntb_reinit_peer() function > ntb_hw_switchtec: Fix setup MW with failure bug > > Wesley Sheng (1): > ntb_hw_switchtec: Skip unnecessary re-setup of shared memory window > for crosslink case > > drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 80 +++++++++++++++++++++------------- > 1 file changed, 49 insertions(+), 31 deletions(-) > > -- > 2.7.4 >
Hi, Everyone, This patch series remove redundant steps and fix one bug of the ntb_hw_switchtec module. When a re-initialization is caused by a link event, the driver will re-setup the shared memory windows. But at that time, the shared memory is still valid, and it's unnecessary to free, reallocate and then initialize it again. Remove these redundant steps. In case of NTB crosslink topology, the setting of shared memory window in the virtual partition doesn't reset on peer's reboot. So skip the re-setup of shared memory window for that case. Switchtec does not support setting multiple MWs simultaneously. However, there's a race condition when a re-initialization is caused by a link event, the driver will re-setup the shared memory window asynchronously and this races with the client setting up its memory windows on the link up event. Fix this by ensure do the entire initialization in a work queue and signal the client once it's done. Regard, Kelvin -- Changed since v1: - It's a second resend of v1 -- Joey Zhang (2): ntb_hw_switchtec: Remove redundant steps of switchtec_ntb_reinit_peer() function ntb_hw_switchtec: Fix setup MW with failure bug Wesley Sheng (1): ntb_hw_switchtec: Skip unnecessary re-setup of shared memory window for crosslink case drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 80 +++++++++++++++++++++------------- 1 file changed, 49 insertions(+), 31 deletions(-)