Message ID | 20190616142836.10614-1-ysato@users.sourceforge.jp (mailing list archive) |
---|---|
Headers | show |
Series | Add RX archtecture support | expand |
Patchew URL: https://patchew.org/QEMU/20190616142836.10614-1-ysato@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support Type: series Message-id: 20190616142836.10614-1-ysato@users.sourceforge.jp === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20190616142836.10614-1-ysato@users.sourceforge.jp -> patchew/20190616142836.10614-1-ysato@users.sourceforge.jp Switched to a new branch 'test' 233b18cbe7 BootLinuxConsoleTest: Test the RX-Virt machine 904297282a MAINTAINERS: Add RX 43952adb47 Add rx-softmmu fb8cc7379b hw/registerfields.h: Add 8bit and 16bit register macros 300109d593 qemu/bitops.h: Add extract8 and extract16 298abac567 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core b836e3b146 hw/rx: Honor -accel qtest 781b6ec24c target/rx: Move rx_load_image to rx-virt. 9577f3d230 hw/rx: RX Target hardware definition 891f2de8d8 hw/char: RX62N serial communication interface (SCI) 3495206576 hw/timer: RX62N internal timer modules a905f500b4 hw/intc: RX62N interrupt controller (ICUa) ece449ed10 target/rx: Dump bytes for each insn during disassembly b95c9bad6b target/rx: Collect all bytes during disassembly 3dff5695a3 target/rx: Emit all disassembly in one prt() 704fec54d9 target/rx: Use prt_ldmi for XCHG_mr disassembly 7396e2ece1 target/rx: Replace operand with prt_ldmi in disassembler 60b13915e5 target/rx: Disassemble rx_index_addr into a string d41d01e403 target/rx: RX disassembler 85b88c8cd4 target/rx: simplify rx_cpu_class_by_name 376f2b05c3 target/rx: Follow the change of tcg. d86020dcdb target/rx: CPU definition 014cc684fa target/rx: TCG helper 4c5f19b6e4 target/rx: TCG translation === OUTPUT BEGIN === 1/24 Checking commit 4c5f19b6e47c (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 1/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/24 Checking commit 014cc684fafc (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 649 lines checked Patch 2/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/24 Checking commit d86020dcdb96 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 645 lines checked Patch 3/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/24 Checking commit 376f2b05c385 (target/rx: Follow the change of tcg.) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 total: 0 errors, 1 warnings, 121 lines checked Patch 4/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/24 Checking commit 85b88c8cd4f0 (target/rx: simplify rx_cpu_class_by_name) 6/24 Checking commit d41d01e40305 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 6/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/24 Checking commit 60b13915e559 (target/rx: Disassemble rx_index_addr into a string) 8/24 Checking commit 7396e2ece1ed (target/rx: Replace operand with prt_ldmi in disassembler) 9/24 Checking commit 704fec54d904 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 10/24 Checking commit 3dff5695a3a3 (target/rx: Emit all disassembly in one prt()) 11/24 Checking commit b95c9bad6bb6 (target/rx: Collect all bytes during disassembly) 12/24 Checking commit ece449ed1087 (target/rx: Dump bytes for each insn during disassembly) 13/24 Checking commit a905f500b42f (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 13/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/24 Checking commit 3495206576c5 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 839 lines checked Patch 14/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/24 Checking commit 891f2de8d83b (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 15/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/24 Checking commit 9577f3d2304d (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 457 lines checked Patch 16/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/24 Checking commit 781b6ec24c97 (target/rx: Move rx_load_image to rx-virt.) 18/24 Checking commit b836e3b14641 (hw/rx: Honor -accel qtest) 19/24 Checking commit 298abac5672b (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/24 Checking commit 300109d593d8 (qemu/bitops.h: Add extract8 and extract16) 21/24 Checking commit fb8cc7379bdd (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value within @rawlines in concatenation (.) or string at ./scripts/checkpatch.pl line 2467. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 21/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/24 Checking commit 43952adb472b (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61: new file mode 100644 total: 0 errors, 1 warnings, 73 lines checked Patch 22/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/24 Checking commit 904297282a7f (MAINTAINERS: Add RX) 24/24 Checking commit 233b18cbe7b0 (BootLinuxConsoleTest: Test the RX-Virt machine) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190616142836.10614-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190616142836.10614-1-ysato@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support Message-id: 20190616142836.10614-1-ysato@users.sourceforge.jp Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' ddea93d BootLinuxConsoleTest: Test the RX-Virt machine 74f0940 MAINTAINERS: Add RX f3106ec Add rx-softmmu 1da40c3 hw/registerfields.h: Add 8bit and 16bit register macros dd11e46 qemu/bitops.h: Add extract8 and extract16 8a27bba hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 710d25f hw/rx: Honor -accel qtest 8e145d9 target/rx: Move rx_load_image to rx-virt. 14b0bc0 hw/rx: RX Target hardware definition cad9f7e hw/char: RX62N serial communication interface (SCI) 655bc26 hw/timer: RX62N internal timer modules 2309a1e hw/intc: RX62N interrupt controller (ICUa) 3ce6f15 target/rx: Dump bytes for each insn during disassembly ecaf009 target/rx: Collect all bytes during disassembly da34fac target/rx: Emit all disassembly in one prt() 84dc86b target/rx: Use prt_ldmi for XCHG_mr disassembly 5ff8a73 target/rx: Replace operand with prt_ldmi in disassembler 16dddb8 target/rx: Disassemble rx_index_addr into a string 77fa9a2 target/rx: RX disassembler a3b3f57 target/rx: simplify rx_cpu_class_by_name e93acbf target/rx: Follow the change of tcg. bc35b11 target/rx: CPU definition 14b01de target/rx: TCG helper a804cd0 target/rx: TCG translation === OUTPUT BEGIN === 1/24 Checking commit a804cd0b4fd9 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 1/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/24 Checking commit 14b01de07ded (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 649 lines checked Patch 2/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/24 Checking commit bc35b111d3a8 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 645 lines checked Patch 3/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/24 Checking commit e93acbf0f80d (target/rx: Follow the change of tcg.) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 total: 0 errors, 1 warnings, 121 lines checked Patch 4/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/24 Checking commit a3b3f57d12ee (target/rx: simplify rx_cpu_class_by_name) 6/24 Checking commit 77fa9a20f924 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 6/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/24 Checking commit 16dddb8ce3b2 (target/rx: Disassemble rx_index_addr into a string) 8/24 Checking commit 5ff8a73eff90 (target/rx: Replace operand with prt_ldmi in disassembler) 9/24 Checking commit 84dc86be8458 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 10/24 Checking commit da34fac0381b (target/rx: Emit all disassembly in one prt()) 11/24 Checking commit ecaf00999e83 (target/rx: Collect all bytes during disassembly) 12/24 Checking commit 3ce6f15d90a7 (target/rx: Dump bytes for each insn during disassembly) 13/24 Checking commit 2309a1e755d6 (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 13/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/24 Checking commit 655bc261bf4f (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 839 lines checked Patch 14/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/24 Checking commit cad9f7ebe6b7 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 15/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/24 Checking commit 14b0bc079779 (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 457 lines checked Patch 16/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/24 Checking commit 8e145d92702b (target/rx: Move rx_load_image to rx-virt.) 18/24 Checking commit 710d25f068a8 (hw/rx: Honor -accel qtest) 19/24 Checking commit 8a27bba4074b (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/24 Checking commit dd11e4699dff (qemu/bitops.h: Add extract8 and extract16) 21/24 Checking commit 1da40c39cf3f (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2467. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 21/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/24 Checking commit f3106ec3c30f (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61: new file mode 100644 total: 0 errors, 1 warnings, 73 lines checked Patch 22/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/24 Checking commit 74f09405da49 (MAINTAINERS: Add RX) 24/24 Checking commit ddea93d70b87 (BootLinuxConsoleTest: Test the RX-Virt machine) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190616142836.10614-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190616142836.10614-1-ysato@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support Type: series Message-id: 20190616142836.10614-1-ysato@users.sourceforge.jp === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu t [tag update] patchew/20190616142836.10614-1-ysato@users.sourceforge.jp -> patchew/20190616142836.10614-1-ysato@users.sourceforge.jp Switched to a new branch 'test' 403c350609 BootLinuxConsoleTest: Test the RX-Virt machine 98f6fb5e89 MAINTAINERS: Add RX 4252de2062 Add rx-softmmu 95d29650e9 hw/registerfields.h: Add 8bit and 16bit register macros 9e3ce57c55 qemu/bitops.h: Add extract8 and extract16 dc04a4b224 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core cc47cf664c hw/rx: Honor -accel qtest ceb71505f3 target/rx: Move rx_load_image to rx-virt. f20d5cc761 hw/rx: RX Target hardware definition c37736b76c hw/char: RX62N serial communication interface (SCI) 8176ccfbcc hw/timer: RX62N internal timer modules d9a5c82129 hw/intc: RX62N interrupt controller (ICUa) 8809801630 target/rx: Dump bytes for each insn during disassembly e91060b6fc target/rx: Collect all bytes during disassembly 2e5775b8de target/rx: Emit all disassembly in one prt() 0c2a07b318 target/rx: Use prt_ldmi for XCHG_mr disassembly 5f427555c5 target/rx: Replace operand with prt_ldmi in disassembler a837728954 target/rx: Disassemble rx_index_addr into a string 4501fa194e target/rx: RX disassembler 107b638962 target/rx: simplify rx_cpu_class_by_name 108dd5166a target/rx: Follow the change of tcg. 7e87ad503c target/rx: CPU definition f34c576ead target/rx: TCG helper 4b7f3bbe5f target/rx: TCG translation === OUTPUT BEGIN === 1/24 Checking commit 4b7f3bbe5f8a (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 1/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/24 Checking commit f34c576eadb5 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 649 lines checked Patch 2/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/24 Checking commit 7e87ad503c0d (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 645 lines checked Patch 3/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/24 Checking commit 108dd5166a69 (target/rx: Follow the change of tcg.) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 total: 0 errors, 1 warnings, 121 lines checked Patch 4/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/24 Checking commit 107b63896230 (target/rx: simplify rx_cpu_class_by_name) 6/24 Checking commit 4501fa194ece (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 6/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/24 Checking commit a83772895452 (target/rx: Disassemble rx_index_addr into a string) 8/24 Checking commit 5f427555c5a6 (target/rx: Replace operand with prt_ldmi in disassembler) 9/24 Checking commit 0c2a07b318aa (target/rx: Use prt_ldmi for XCHG_mr disassembly) 10/24 Checking commit 2e5775b8dec1 (target/rx: Emit all disassembly in one prt()) 11/24 Checking commit e91060b6fc95 (target/rx: Collect all bytes during disassembly) 12/24 Checking commit 880980163031 (target/rx: Dump bytes for each insn during disassembly) 13/24 Checking commit d9a5c8212987 (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 13/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/24 Checking commit 8176ccfbcca6 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 839 lines checked Patch 14/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/24 Checking commit c37736b76c65 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 15/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/24 Checking commit f20d5cc76168 (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 457 lines checked Patch 16/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/24 Checking commit ceb71505f397 (target/rx: Move rx_load_image to rx-virt.) 18/24 Checking commit cc47cf664c91 (hw/rx: Honor -accel qtest) 19/24 Checking commit dc04a4b224e3 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/24 Checking commit 9e3ce57c5563 (qemu/bitops.h: Add extract8 and extract16) 21/24 Checking commit 95d29650e976 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value within @rawlines in concatenation (.) or string at ./scripts/checkpatch.pl line 2467. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 21/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/24 Checking commit 4252de2062f3 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61: new file mode 100644 total: 0 errors, 1 warnings, 73 lines checked Patch 22/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/24 Checking commit 98f6fb5e8959 (MAINTAINERS: Add RX) 24/24 Checking commit 403c3506091d (BootLinuxConsoleTest: Test the RX-Virt machine) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190616142836.10614-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190616142836.10614-1-ysato@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support Message-id: 20190616142836.10614-1-ysato@users.sourceforge.jp Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 0c27dd8 BootLinuxConsoleTest: Test the RX-Virt machine 2a6876d MAINTAINERS: Add RX d251bcb Add rx-softmmu 74589c9 hw/registerfields.h: Add 8bit and 16bit register macros d79dcb1 qemu/bitops.h: Add extract8 and extract16 7b48c06 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core f57add5 hw/rx: Honor -accel qtest 6250788 target/rx: Move rx_load_image to rx-virt. 7023958 hw/rx: RX Target hardware definition 02ccff2 hw/char: RX62N serial communication interface (SCI) 82f9b2f hw/timer: RX62N internal timer modules d5bbed0 hw/intc: RX62N interrupt controller (ICUa) 70acbbd target/rx: Dump bytes for each insn during disassembly 2e7845e target/rx: Collect all bytes during disassembly 78b4585 target/rx: Emit all disassembly in one prt() 4f2586f target/rx: Use prt_ldmi for XCHG_mr disassembly 85b4ce9 target/rx: Replace operand with prt_ldmi in disassembler 33933e5 target/rx: Disassemble rx_index_addr into a string 72b9045 target/rx: RX disassembler 8ce563c target/rx: simplify rx_cpu_class_by_name 7f2e05e target/rx: Follow the change of tcg. 065893f target/rx: CPU definition 5f160a0 target/rx: TCG helper 24091fb target/rx: TCG translation === OUTPUT BEGIN === 1/24 Checking commit 24091fb702bb (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 1/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/24 Checking commit 5f160a0c4667 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 649 lines checked Patch 2/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/24 Checking commit 065893fc208c (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 645 lines checked Patch 3/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/24 Checking commit 7f2e05e35322 (target/rx: Follow the change of tcg.) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 total: 0 errors, 1 warnings, 121 lines checked Patch 4/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/24 Checking commit 8ce563cdcaed (target/rx: simplify rx_cpu_class_by_name) 6/24 Checking commit 72b9045c8042 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 6/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/24 Checking commit 33933e5f814b (target/rx: Disassemble rx_index_addr into a string) 8/24 Checking commit 85b4ce969b9f (target/rx: Replace operand with prt_ldmi in disassembler) 9/24 Checking commit 4f2586f683be (target/rx: Use prt_ldmi for XCHG_mr disassembly) 10/24 Checking commit 78b4585ca396 (target/rx: Emit all disassembly in one prt()) 11/24 Checking commit 2e7845e0912b (target/rx: Collect all bytes during disassembly) 12/24 Checking commit 70acbbdd2844 (target/rx: Dump bytes for each insn during disassembly) 13/24 Checking commit d5bbed0bb689 (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 13/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/24 Checking commit 82f9b2f0f2d1 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 839 lines checked Patch 14/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/24 Checking commit 02ccff275fb2 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 15/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/24 Checking commit 70239586c4f4 (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 457 lines checked Patch 16/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/24 Checking commit 625078837bc8 (target/rx: Move rx_load_image to rx-virt.) 18/24 Checking commit f57add58ea62 (hw/rx: Honor -accel qtest) 19/24 Checking commit 7b48c064789d (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/24 Checking commit d79dcb1d3979 (qemu/bitops.h: Add extract8 and extract16) 21/24 Checking commit 74589c9da34e (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2467. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 21/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/24 Checking commit d251bcb5eb98 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61: new file mode 100644 total: 0 errors, 1 warnings, 73 lines checked Patch 22/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/24 Checking commit 2a6876dc18fd (MAINTAINERS: Add RX) 24/24 Checking commit 0c27dd8686ef (BootLinuxConsoleTest: Test the RX-Virt machine) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190616142836.10614-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190616142836.10614-1-ysato@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support Type: series Message-id: 20190616142836.10614-1-ysato@users.sourceforge.jp === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu t [tag update] patchew/20190616142836.10614-1-ysato@users.sourceforge.jp -> patchew/20190616142836.10614-1-ysato@users.sourceforge.jp Switched to a new branch 'test' cff80b5d1e BootLinuxConsoleTest: Test the RX-Virt machine 2afa3191c4 MAINTAINERS: Add RX 2581cfc04d Add rx-softmmu 2190818c28 hw/registerfields.h: Add 8bit and 16bit register macros 997230fa9e qemu/bitops.h: Add extract8 and extract16 3481b34b73 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core c5d63912aa hw/rx: Honor -accel qtest ad820302f8 target/rx: Move rx_load_image to rx-virt. 387d306c14 hw/rx: RX Target hardware definition 6f8b3aff27 hw/char: RX62N serial communication interface (SCI) 465e8e3419 hw/timer: RX62N internal timer modules 6f0b3c6dda hw/intc: RX62N interrupt controller (ICUa) 56bdfb0467 target/rx: Dump bytes for each insn during disassembly 747fb3b0c1 target/rx: Collect all bytes during disassembly a00d8b4c86 target/rx: Emit all disassembly in one prt() 2923ce8078 target/rx: Use prt_ldmi for XCHG_mr disassembly db364b4e70 target/rx: Replace operand with prt_ldmi in disassembler ab02b67a15 target/rx: Disassemble rx_index_addr into a string 43ba920a8c target/rx: RX disassembler c77e3d7ee3 target/rx: simplify rx_cpu_class_by_name cb783ec841 target/rx: Follow the change of tcg. ceb39de01c target/rx: CPU definition 56775c6167 target/rx: TCG helper 900643e454 target/rx: TCG translation === OUTPUT BEGIN === 1/24 Checking commit 900643e454ec (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 1/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/24 Checking commit 56775c6167e1 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 649 lines checked Patch 2/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/24 Checking commit ceb39de01c83 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 645 lines checked Patch 3/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/24 Checking commit cb783ec8417f (target/rx: Follow the change of tcg.) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 total: 0 errors, 1 warnings, 121 lines checked Patch 4/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/24 Checking commit c77e3d7ee3fd (target/rx: simplify rx_cpu_class_by_name) 6/24 Checking commit 43ba920a8c9c (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 6/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/24 Checking commit ab02b67a153e (target/rx: Disassemble rx_index_addr into a string) 8/24 Checking commit db364b4e7075 (target/rx: Replace operand with prt_ldmi in disassembler) 9/24 Checking commit 2923ce807857 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 10/24 Checking commit a00d8b4c8652 (target/rx: Emit all disassembly in one prt()) 11/24 Checking commit 747fb3b0c178 (target/rx: Collect all bytes during disassembly) 12/24 Checking commit 56bdfb0467c9 (target/rx: Dump bytes for each insn during disassembly) 13/24 Checking commit 6f0b3c6ddafc (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 13/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/24 Checking commit 465e8e3419e0 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 839 lines checked Patch 14/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/24 Checking commit 6f8b3aff27d3 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 15/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/24 Checking commit 387d306c1415 (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 457 lines checked Patch 16/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/24 Checking commit ad820302f891 (target/rx: Move rx_load_image to rx-virt.) 18/24 Checking commit c5d63912aa3e (hw/rx: Honor -accel qtest) 19/24 Checking commit 3481b34b7332 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/24 Checking commit 997230fa9e74 (qemu/bitops.h: Add extract8 and extract16) 21/24 Checking commit 2190818c28f8 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value within @rawlines in concatenation (.) or string at ./scripts/checkpatch.pl line 2467. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 21/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/24 Checking commit 2581cfc04de5 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61: new file mode 100644 total: 0 errors, 1 warnings, 73 lines checked Patch 22/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/24 Checking commit 2afa3191c4f3 (MAINTAINERS: Add RX) 24/24 Checking commit cff80b5d1ebb (BootLinuxConsoleTest: Test the RX-Virt machine) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190616142836.10614-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190616142836.10614-1-ysato@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190616142836.10614-1-ysato@users.sourceforge.jp Type: series Subject: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 63acf99 BootLinuxConsoleTest: Test the RX-Virt machine 55c11a3 MAINTAINERS: Add RX e70d51d Add rx-softmmu 92d29e0 hw/registerfields.h: Add 8bit and 16bit register macros daf1337 qemu/bitops.h: Add extract8 and extract16 2d9c0d6 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core ce5f6c3 hw/rx: Honor -accel qtest a22cc3b target/rx: Move rx_load_image to rx-virt. 8736a61 hw/rx: RX Target hardware definition dc2af92 hw/char: RX62N serial communication interface (SCI) f3d48c1 hw/timer: RX62N internal timer modules 4a32817 hw/intc: RX62N interrupt controller (ICUa) 99e0a91 target/rx: Dump bytes for each insn during disassembly 92fc3b3 target/rx: Collect all bytes during disassembly ba396eb target/rx: Emit all disassembly in one prt() e0ed57b target/rx: Use prt_ldmi for XCHG_mr disassembly 44ee1c7 target/rx: Replace operand with prt_ldmi in disassembler c62d37a target/rx: Disassemble rx_index_addr into a string 7f19f36 target/rx: RX disassembler 0998f1a target/rx: simplify rx_cpu_class_by_name b5e3446 target/rx: Follow the change of tcg. 5338b4d target/rx: CPU definition 3f32ebc target/rx: TCG helper af95d40 target/rx: TCG translation === OUTPUT BEGIN === 1/24 Checking commit af95d40319c1 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 1/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/24 Checking commit 3f32ebceb081 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 649 lines checked Patch 2/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/24 Checking commit 5338b4d31288 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 645 lines checked Patch 3/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/24 Checking commit b5e3446977c2 (target/rx: Follow the change of tcg.) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 total: 0 errors, 1 warnings, 121 lines checked Patch 4/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/24 Checking commit 0998f1ad7b92 (target/rx: simplify rx_cpu_class_by_name) 6/24 Checking commit 7f19f364a358 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 6/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/24 Checking commit c62d37a04fd1 (target/rx: Disassemble rx_index_addr into a string) 8/24 Checking commit 44ee1c75bf83 (target/rx: Replace operand with prt_ldmi in disassembler) 9/24 Checking commit e0ed57b911f8 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 10/24 Checking commit ba396eb8d526 (target/rx: Emit all disassembly in one prt()) 11/24 Checking commit 92fc3b3987e0 (target/rx: Collect all bytes during disassembly) 12/24 Checking commit 99e0a9185550 (target/rx: Dump bytes for each insn during disassembly) 13/24 Checking commit 4a32817f6463 (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 13/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/24 Checking commit f3d48c1450ab (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 839 lines checked Patch 14/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/24 Checking commit dc2af9256d00 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 15/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/24 Checking commit 8736a613a5c4 (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 457 lines checked Patch 16/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/24 Checking commit a22cc3bcd07b (target/rx: Move rx_load_image to rx-virt.) 18/24 Checking commit ce5f6c3b497e (hw/rx: Honor -accel qtest) 19/24 Checking commit 2d9c0d66093a (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/24 Checking commit daf1337ffd47 (qemu/bitops.h: Add extract8 and extract16) 21/24 Checking commit 92d29e02f00c (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2467. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 21/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/24 Checking commit e70d51decf77 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61: new file mode 100644 total: 0 errors, 1 warnings, 73 lines checked Patch 22/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/24 Checking commit 55c11a37d1e4 (MAINTAINERS: Add RX) 24/24 Checking commit 63acf9992300 (BootLinuxConsoleTest: Test the RX-Virt machine) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190616142836.10614-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190616142836.10614-1-ysato@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support Type: series Message-id: 20190616142836.10614-1-ysato@users.sourceforge.jp === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu t [tag update] patchew/20190616142836.10614-1-ysato@users.sourceforge.jp -> patchew/20190616142836.10614-1-ysato@users.sourceforge.jp Switched to a new branch 'test' 6cf003324f BootLinuxConsoleTest: Test the RX-Virt machine 5b245d8608 MAINTAINERS: Add RX a0f72f1c22 Add rx-softmmu 29cee4bf91 hw/registerfields.h: Add 8bit and 16bit register macros 4dc22f4709 qemu/bitops.h: Add extract8 and extract16 6faffcc70c hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 8525a12c35 hw/rx: Honor -accel qtest 1a73fe6b98 target/rx: Move rx_load_image to rx-virt. abe443904a hw/rx: RX Target hardware definition 65bcf6380e hw/char: RX62N serial communication interface (SCI) 1c2b600c8d hw/timer: RX62N internal timer modules 492f670463 hw/intc: RX62N interrupt controller (ICUa) ee55183b75 target/rx: Dump bytes for each insn during disassembly adf1747a39 target/rx: Collect all bytes during disassembly af8bf138f1 target/rx: Emit all disassembly in one prt() f5cc42e0d3 target/rx: Use prt_ldmi for XCHG_mr disassembly 10551aa38a target/rx: Replace operand with prt_ldmi in disassembler cd70c31a2d target/rx: Disassemble rx_index_addr into a string 9ca9b0f1b7 target/rx: RX disassembler 006b47f9ab target/rx: simplify rx_cpu_class_by_name c63cb5a1ca target/rx: Follow the change of tcg. eeca36e3d4 target/rx: CPU definition ce69a0fc32 target/rx: TCG helper 9407cbd6df target/rx: TCG translation === OUTPUT BEGIN === 1/24 Checking commit 9407cbd6df21 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 1/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/24 Checking commit ce69a0fc32ce (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 649 lines checked Patch 2/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/24 Checking commit eeca36e3d4cb (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 645 lines checked Patch 3/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/24 Checking commit c63cb5a1ca57 (target/rx: Follow the change of tcg.) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 total: 0 errors, 1 warnings, 121 lines checked Patch 4/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/24 Checking commit 006b47f9aba0 (target/rx: simplify rx_cpu_class_by_name) 6/24 Checking commit 9ca9b0f1b7bf (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 6/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/24 Checking commit cd70c31a2d67 (target/rx: Disassemble rx_index_addr into a string) 8/24 Checking commit 10551aa38ab8 (target/rx: Replace operand with prt_ldmi in disassembler) 9/24 Checking commit f5cc42e0d3c9 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 10/24 Checking commit af8bf138f119 (target/rx: Emit all disassembly in one prt()) 11/24 Checking commit adf1747a39dc (target/rx: Collect all bytes during disassembly) 12/24 Checking commit ee55183b7577 (target/rx: Dump bytes for each insn during disassembly) 13/24 Checking commit 492f670463db (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 13/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/24 Checking commit 1c2b600c8dbb (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 839 lines checked Patch 14/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/24 Checking commit 65bcf6380ee0 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 15/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/24 Checking commit abe443904a61 (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 457 lines checked Patch 16/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/24 Checking commit 1a73fe6b985d (target/rx: Move rx_load_image to rx-virt.) 18/24 Checking commit 8525a12c3571 (hw/rx: Honor -accel qtest) 19/24 Checking commit 6faffcc70c79 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/24 Checking commit 4dc22f47093f (qemu/bitops.h: Add extract8 and extract16) 21/24 Checking commit 29cee4bf91ce (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value within @rawlines in concatenation (.) or string at ./scripts/checkpatch.pl line 2467. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 21/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/24 Checking commit a0f72f1c22ea (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61: new file mode 100644 total: 0 errors, 1 warnings, 73 lines checked Patch 22/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/24 Checking commit 5b245d860873 (MAINTAINERS: Add RX) 24/24 Checking commit 6cf003324f44 (BootLinuxConsoleTest: Test the RX-Virt machine) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190616142836.10614-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Sun, 16 Jun 2019 08:18:18 -0700 (PDT) no-reply@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20190616142836.10614-1-ysato@users.sourceforge.jp/ > > to fix MAINTAINERS warning, you can add new entry there at the first patch that introduces new directory/file and get rid of 23/24 patch > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support > Type: series > Message-id: 20190616142836.10614-1-ysato@users.sourceforge.jp > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > ./scripts/checkpatch.pl --mailback base.. > === TEST SCRIPT END === > > From https://github.com/patchew-project/qemu > * [new tag] patchew/20190616142836.10614-1-ysato@users.sourceforge.jp -> patchew/20190616142836.10614-1-ysato@users.sourceforge.jp > Switched to a new branch 'test' > 233b18cbe7 BootLinuxConsoleTest: Test the RX-Virt machine > 904297282a MAINTAINERS: Add RX > 43952adb47 Add rx-softmmu > fb8cc7379b hw/registerfields.h: Add 8bit and 16bit register macros > 300109d593 qemu/bitops.h: Add extract8 and extract16 > 298abac567 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core > b836e3b146 hw/rx: Honor -accel qtest > 781b6ec24c target/rx: Move rx_load_image to rx-virt. > 9577f3d230 hw/rx: RX Target hardware definition > 891f2de8d8 hw/char: RX62N serial communication interface (SCI) > 3495206576 hw/timer: RX62N internal timer modules > a905f500b4 hw/intc: RX62N interrupt controller (ICUa) > ece449ed10 target/rx: Dump bytes for each insn during disassembly > b95c9bad6b target/rx: Collect all bytes during disassembly > 3dff5695a3 target/rx: Emit all disassembly in one prt() > 704fec54d9 target/rx: Use prt_ldmi for XCHG_mr disassembly > 7396e2ece1 target/rx: Replace operand with prt_ldmi in disassembler > 60b13915e5 target/rx: Disassemble rx_index_addr into a string > d41d01e403 target/rx: RX disassembler > 85b88c8cd4 target/rx: simplify rx_cpu_class_by_name > 376f2b05c3 target/rx: Follow the change of tcg. > d86020dcdb target/rx: CPU definition > 014cc684fa target/rx: TCG helper > 4c5f19b6e4 target/rx: TCG translation > > === OUTPUT BEGIN === > 1/24 Checking commit 4c5f19b6e47c (target/rx: TCG translation) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #20: > new file mode 100644 > > total: 0 errors, 1 warnings, 3065 lines checked > > Patch 1/24 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 2/24 Checking commit 014cc684fafc (target/rx: TCG helper) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #20: > new file mode 100644 > > total: 0 errors, 1 warnings, 649 lines checked > > Patch 2/24 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 3/24 Checking commit d86020dcdb96 (target/rx: CPU definition) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #20: > new file mode 100644 > > total: 0 errors, 1 warnings, 645 lines checked > > Patch 3/24 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 4/24 Checking commit 376f2b05c385 (target/rx: Follow the change of tcg.) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #15: > new file mode 100644 > > total: 0 errors, 1 warnings, 121 lines checked > > Patch 4/24 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 5/24 Checking commit 85b88c8cd4f0 (target/rx: simplify rx_cpu_class_by_name) > 6/24 Checking commit d41d01e40305 (target/rx: RX disassembler) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #38: > new file mode 100644 > > total: 0 errors, 1 warnings, 1497 lines checked > > Patch 6/24 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 7/24 Checking commit 60b13915e559 (target/rx: Disassemble rx_index_addr into a string) > 8/24 Checking commit 7396e2ece1ed (target/rx: Replace operand with prt_ldmi in disassembler) > 9/24 Checking commit 704fec54d904 (target/rx: Use prt_ldmi for XCHG_mr disassembly) > 10/24 Checking commit 3dff5695a3a3 (target/rx: Emit all disassembly in one prt()) > 11/24 Checking commit b95c9bad6bb6 (target/rx: Collect all bytes during disassembly) > 12/24 Checking commit ece449ed1087 (target/rx: Dump bytes for each insn during disassembly) > 13/24 Checking commit a905f500b42f (hw/intc: RX62N interrupt controller (ICUa)) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #40: > new file mode 100644 > > total: 0 errors, 1 warnings, 442 lines checked > > Patch 13/24 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 14/24 Checking commit 3495206576c5 (hw/timer: RX62N internal timer modules) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #50: > new file mode 100644 > > total: 0 errors, 1 warnings, 839 lines checked > > Patch 14/24 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 15/24 Checking commit 891f2de8d83b (hw/char: RX62N serial communication interface (SCI)) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #43: > new file mode 100644 > > total: 0 errors, 1 warnings, 398 lines checked > > Patch 15/24 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 16/24 Checking commit 9577f3d2304d (hw/rx: RX Target hardware definition) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #21: > new file mode 100644 > > total: 0 errors, 1 warnings, 457 lines checked > > Patch 16/24 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 17/24 Checking commit 781b6ec24c97 (target/rx: Move rx_load_image to rx-virt.) > 18/24 Checking commit b836e3b14641 (hw/rx: Honor -accel qtest) > 19/24 Checking commit 298abac5672b (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) > 20/24 Checking commit 300109d593d8 (qemu/bitops.h: Add extract8 and extract16) > 21/24 Checking commit fb8cc7379bdd (hw/registerfields.h: Add 8bit and 16bit register macros) > Use of uninitialized value within @rawlines in concatenation (.) or string at ./scripts/checkpatch.pl line 2467. > ERROR: Macros with multiple statements should be enclosed in a do - while loop > #27: FILE: include/hw/registerfields.h:25: > +#define REG8(reg, addr) \ > + enum { A_ ## reg = (addr) }; \ > + enum { R_ ## reg = (addr) }; > > ERROR: Macros with multiple statements should be enclosed in a do - while loop > #31: FILE: include/hw/registerfields.h:29: > +#define REG16(reg, addr) \ > + enum { A_ ## reg = (addr) }; \ > + enum { R_ ## reg = (addr) / 2 }; > > total: 2 errors, 0 warnings, 56 lines checked > > Patch 21/24 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > 22/24 Checking commit 43952adb472b (Add rx-softmmu) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #61: > new file mode 100644 > > total: 0 errors, 1 warnings, 73 lines checked > > Patch 22/24 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 23/24 Checking commit 904297282a7f (MAINTAINERS: Add RX) > 24/24 Checking commit 233b18cbe7b0 (BootLinuxConsoleTest: Test the RX-Virt machine) > === OUTPUT END === > > Test command exited with code: 1 > > > The full log is available at > http://patchew.org/logs/20190616142836.10614-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message. > --- > Email generated automatically by Patchew [https://patchew.org/]. > Please send your feedback to patchew-devel@redhat.com