| Message ID | 20190617093601.34511-1-andrew.murray@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | clocksource/arm_arch_timer: remove unused return type | expand |
On 17/06/2019 10:36, Andrew Murray wrote: > The function 'arch_timer_set_evtstrm_feature' has no return statement > despite its prototype - let's change the function prototype to return > void. This matches the equivalent arm64 implementation. > > fixes: 11e34eca5d0a ("clocksource/arm_arch_timer: Extract elf_hwcap use to arch-helper") nit: tags start with a capital letter. > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Andrew Murray <andrew.murray@arm.com> > --- > arch/arm/include/asm/arch_timer.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/include/asm/arch_timer.h b/arch/arm/include/asm/arch_timer.h > index ae533caec1e9..99175812d903 100644 > --- a/arch/arm/include/asm/arch_timer.h > +++ b/arch/arm/include/asm/arch_timer.h > @@ -125,7 +125,7 @@ static inline void arch_timer_set_cntkctl(u32 cntkctl) > isb(); > } > > -static inline bool arch_timer_set_evtstrm_feature(void) > +static inline void arch_timer_set_evtstrm_feature(void) > { > elf_hwcap |= HWCAP_EVTSTRM; > } > Acked-by: Marc Zyngier <marc.zyngier@arm.com> M.
On Mon, Jun 17, 2019 at 10:45:24AM +0100, Marc Zyngier wrote: > On 17/06/2019 10:36, Andrew Murray wrote: > > The function 'arch_timer_set_evtstrm_feature' has no return statement > > despite its prototype - let's change the function prototype to return > > void. This matches the equivalent arm64 implementation. > > > > fixes: 11e34eca5d0a ("clocksource/arm_arch_timer: Extract elf_hwcap use to arch-helper") > > nit: tags start with a capital letter. Thanks - I'll remember next time. Andrew Murray > > > Reported-by: kbuild test robot <lkp@intel.com> > > Signed-off-by: Andrew Murray <andrew.murray@arm.com> > > --- > > arch/arm/include/asm/arch_timer.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/include/asm/arch_timer.h b/arch/arm/include/asm/arch_timer.h > > index ae533caec1e9..99175812d903 100644 > > --- a/arch/arm/include/asm/arch_timer.h > > +++ b/arch/arm/include/asm/arch_timer.h > > @@ -125,7 +125,7 @@ static inline void arch_timer_set_cntkctl(u32 cntkctl) > > isb(); > > } > > > > -static inline bool arch_timer_set_evtstrm_feature(void) > > +static inline void arch_timer_set_evtstrm_feature(void) > > { > > elf_hwcap |= HWCAP_EVTSTRM; > > } > > > > Acked-by: Marc Zyngier <marc.zyngier@arm.com> > > M. > -- > Jazz is not dead. It just smells funny...
On 17/06/2019 11:36, Andrew Murray wrote: > The function 'arch_timer_set_evtstrm_feature' has no return statement > despite its prototype - let's change the function prototype to return > void. This matches the equivalent arm64 implementation. > > fixes: 11e34eca5d0a ("clocksource/arm_arch_timer: Extract elf_hwcap use to arch-helper") > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Andrew Murray <andrew.murray@arm.com> > --- I can rebase my branch. I'll fold this patch with 11e34eca5d0a Thanks -- Daniel
diff --git a/arch/arm/include/asm/arch_timer.h b/arch/arm/include/asm/arch_timer.h index ae533caec1e9..99175812d903 100644 --- a/arch/arm/include/asm/arch_timer.h +++ b/arch/arm/include/asm/arch_timer.h @@ -125,7 +125,7 @@ static inline void arch_timer_set_cntkctl(u32 cntkctl) isb(); } -static inline bool arch_timer_set_evtstrm_feature(void) +static inline void arch_timer_set_evtstrm_feature(void) { elf_hwcap |= HWCAP_EVTSTRM; }
The function 'arch_timer_set_evtstrm_feature' has no return statement despite its prototype - let's change the function prototype to return void. This matches the equivalent arm64 implementation. fixes: 11e34eca5d0a ("clocksource/arm_arch_timer: Extract elf_hwcap use to arch-helper") Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Andrew Murray <andrew.murray@arm.com> --- arch/arm/include/asm/arch_timer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)