diff mbox

mmc: sdhi, mmcif: zboot: Correct clock disable logic

Message ID 1312351734-4426-1-git-send-email-horms@verge.net.au (mailing list archive)
State Superseded
Commit b3623080ff6974e696710b6c6eb4cdbf2bbab347
Headers show

Commit Message

Simon Horman Aug. 3, 2011, 6:08 a.m. UTC
This corrects a logic-error that I made in the original implementation.

An alternate patch would be to just remove these lines and
leave the clock running as it is reconfigured later on during
boot anyway.

Signed-off-by: Simon Horman <horms@verge.net.au>
---
 arch/arm/boot/compressed/mmcif-sh7372.c |    2 +-
 arch/arm/boot/compressed/sdhi-sh7372.c  |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Paul Mundt Aug. 8, 2011, 7:38 a.m. UTC | #1
On Wed, Aug 03, 2011 at 03:08:54PM +0900, Simon Horman wrote:
> This corrects a logic-error that I made in the original implementation.
> 
> An alternate patch would be to just remove these lines and
> leave the clock running as it is reconfigured later on during
> boot anyway.
> 
> Signed-off-by: Simon Horman <horms@verge.net.au>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/compressed/mmcif-sh7372.c b/arch/arm/boot/compressed/mmcif-sh7372.c
index b6f61d9..672ae95 100644
--- a/arch/arm/boot/compressed/mmcif-sh7372.c
+++ b/arch/arm/boot/compressed/mmcif-sh7372.c
@@ -82,7 +82,7 @@  asmlinkage void mmc_loader(unsigned char *buf, unsigned long len)
 
 
 	/* Disable clock to MMC hardware block */
-	__raw_writel(__raw_readl(SMSTPCR3) & (1 << 12), SMSTPCR3);
+	__raw_writel(__raw_readl(SMSTPCR3) | (1 << 12), SMSTPCR3);
 
 	mmc_update_progress(MMC_PROGRESS_DONE);
 }
diff --git a/arch/arm/boot/compressed/sdhi-sh7372.c b/arch/arm/boot/compressed/sdhi-sh7372.c
index d403a8b..d279294 100644
--- a/arch/arm/boot/compressed/sdhi-sh7372.c
+++ b/arch/arm/boot/compressed/sdhi-sh7372.c
@@ -85,7 +85,7 @@  asmlinkage void mmc_loader(unsigned short *buf, unsigned long len)
 		goto err;
 
         /* Disable clock to SDHI1 hardware block */
-        __raw_writel(__raw_readl(SMSTPCR3) & (1 << 13), SMSTPCR3);
+        __raw_writel(__raw_readl(SMSTPCR3) | (1 << 13), SMSTPCR3);
 
 	mmc_update_progress(MMC_PROGRESS_DONE);