| Message ID | 20190618125433.9739-4-andrew.murray@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | coresight: etm4x: save/restore ETMv4 context across CPU low power states | expand |
On 18/06/2019 13:54, Andrew Murray wrote: > Checkpatch indicates that octal permissions are preferred for > module parameters. Let's use octal permissions instead. > > Signed-off-by: Andrew Murray <andrew.murray@arm.com> > --- > drivers/hwtracing/coresight/coresight-etm4x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c > index ae623415c431..885c4f2c691c 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x.c > +++ b/drivers/hwtracing/coresight/coresight-etm4x.c > @@ -34,7 +34,7 @@ > #include "coresight-etm-perf.h" > > static int boot_enable; > -module_param_named(boot_enable, boot_enable, int, S_IRUGO); > +module_param_named(boot_enable, boot_enable, int, 0444); Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c index ae623415c431..885c4f2c691c 100644 --- a/drivers/hwtracing/coresight/coresight-etm4x.c +++ b/drivers/hwtracing/coresight/coresight-etm4x.c @@ -34,7 +34,7 @@ #include "coresight-etm-perf.h" static int boot_enable; -module_param_named(boot_enable, boot_enable, int, S_IRUGO); +module_param_named(boot_enable, boot_enable, int, 0444); /* The number of ETMv4 currently registered */ static int etm4_count;
Checkpatch indicates that octal permissions are preferred for module parameters. Let's use octal permissions instead. Signed-off-by: Andrew Murray <andrew.murray@arm.com> --- drivers/hwtracing/coresight/coresight-etm4x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)