diff mbox series

[1/2] scsi: mpt3sas: make driver options visible in sys

Message ID 20190614144144.6448-2-thenzl@redhat.com (mailing list archive)
State Mainlined
Commit ab9f5adb8d14a59fd5062ac1d880c5d10bb75959
Headers show
Series mpt3sas | expand

Commit Message

Tomas Henzl June 14, 2019, 2:41 p.m. UTC 
Support is easier with all driver parameters visible in sysfs.
Also I've replaced a constant with an octal permission.

Signed-off-by: Tomas Henzl <thenzl@redhat.com>
---
 drivers/scsi/mpt3sas/mpt3sas_base.c  | 14 +++++++-------
 drivers/scsi/mpt3sas/mpt3sas_scsih.c | 14 +++++++-------
 2 files changed, 14 insertions(+), 14 deletions(-)

Comments

Suganath Prabu S June 20, 2019, 7:22 a.m. UTC | #1 
Acked-by: Suganath Prabu <suganath-prabu.subramani@broadcom.com>

On Fri, Jun 14, 2019 at 8:12 PM Tomas Henzl <thenzl@redhat.com> wrote:
>
> Support is easier with all driver parameters visible in sysfs.
> Also I've replaced a constant with an octal permission.
>
> Signed-off-by: Tomas Henzl <thenzl@redhat.com>
> ---
>  drivers/scsi/mpt3sas/mpt3sas_base.c  | 14 +++++++-------
>  drivers/scsi/mpt3sas/mpt3sas_scsih.c | 14 +++++++-------
>  2 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
> index e6377ec07..839930764 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_base.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
> @@ -74,28 +74,28 @@ static MPT_CALLBACK mpt_callbacks[MPT_MAX_CALLBACKS];
>  #define MAX_HBA_QUEUE_DEPTH    30000
>  #define MAX_CHAIN_DEPTH                100000
>  static int max_queue_depth = -1;
> -module_param(max_queue_depth, int, 0);
> +module_param(max_queue_depth, int, 0444);
>  MODULE_PARM_DESC(max_queue_depth, " max controller queue depth ");
>
>  static int max_sgl_entries = -1;
> -module_param(max_sgl_entries, int, 0);
> +module_param(max_sgl_entries, int, 0444);
>  MODULE_PARM_DESC(max_sgl_entries, " max sg entries ");
>
>  static int msix_disable = -1;
> -module_param(msix_disable, int, 0);
> +module_param(msix_disable, int, 0444);
>  MODULE_PARM_DESC(msix_disable, " disable msix routed interrupts (default=0)");
>
>  static int smp_affinity_enable = 1;
> -module_param(smp_affinity_enable, int, S_IRUGO);
> +module_param(smp_affinity_enable, int, 0444);
>  MODULE_PARM_DESC(smp_affinity_enable, "SMP affinity feature enable/disable Default: enable(1)");
>
>  static int max_msix_vectors = -1;
> -module_param(max_msix_vectors, int, 0);
> +module_param(max_msix_vectors, int, 0444);
>  MODULE_PARM_DESC(max_msix_vectors,
>         " max msix vectors");
>
>  static int irqpoll_weight = -1;
> -module_param(irqpoll_weight, int, 0);
> +module_param(irqpoll_weight, int, 0444);
>  MODULE_PARM_DESC(irqpoll_weight,
>         "irq poll weight (default= one fourth of HBA queue depth)");
>
> @@ -104,7 +104,7 @@ MODULE_PARM_DESC(mpt3sas_fwfault_debug,
>         " enable detection of firmware fault and halt firmware - (default=0)");
>
>  static int perf_mode = -1;
> -module_param(perf_mode, int, 0);
> +module_param(perf_mode, int, 0444);
>  MODULE_PARM_DESC(perf_mode,
>         "Performance mode (only for Aero/Sea Generation), options:\n\t\t"
>         "0 - balanced: high iops mode is enabled &\n\t\t"
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> index 1f6aa8b19..27c731a3f 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> @@ -113,22 +113,22 @@ MODULE_PARM_DESC(logging_level,
>
>
>  static ushort max_sectors = 0xFFFF;
> -module_param(max_sectors, ushort, 0);
> +module_param(max_sectors, ushort, 0444);
>  MODULE_PARM_DESC(max_sectors, "max sectors, range 64 to 32767  default=32767");
>
>
>  static int missing_delay[2] = {-1, -1};
> -module_param_array(missing_delay, int, NULL, 0);
> +module_param_array(missing_delay, int, NULL, 0444);
>  MODULE_PARM_DESC(missing_delay, " device missing delay , io missing delay");
>
>  /* scsi-mid layer global parmeter is max_report_luns, which is 511 */
>  #define MPT3SAS_MAX_LUN (16895)
>  static u64 max_lun = MPT3SAS_MAX_LUN;
> -module_param(max_lun, ullong, 0);
> +module_param(max_lun, ullong, 0444);
>  MODULE_PARM_DESC(max_lun, " max lun, default=16895 ");
>
>  static ushort hbas_to_enumerate;
> -module_param(hbas_to_enumerate, ushort, 0);
> +module_param(hbas_to_enumerate, ushort, 0444);
>  MODULE_PARM_DESC(hbas_to_enumerate,
>                 " 0 - enumerates both SAS 2.0 & SAS 3.0 generation HBAs\n \
>                   1 - enumerates only SAS 2.0 generation HBAs\n \
> @@ -142,17 +142,17 @@ MODULE_PARM_DESC(hbas_to_enumerate,
>   * Either bit can be set, or both
>   */
>  static int diag_buffer_enable = -1;
> -module_param(diag_buffer_enable, int, 0);
> +module_param(diag_buffer_enable, int, 0444);
>  MODULE_PARM_DESC(diag_buffer_enable,
>         " post diag buffers (TRACE=1/SNAPSHOT=2/EXTENDED=4/default=0)");
>  static int disable_discovery = -1;
> -module_param(disable_discovery, int, 0);
> +module_param(disable_discovery, int, 0444);
>  MODULE_PARM_DESC(disable_discovery, " disable discovery ");
>
>
>  /* permit overriding the host protection capabilities mask (EEDP/T10 PI) */
>  static int prot_mask = -1;
> -module_param(prot_mask, int, 0);
> +module_param(prot_mask, int, 0444);
>  MODULE_PARM_DESC(prot_mask, " host protection capabilities mask, def=7 ");
>
>
> --
> 2.20.1
>
diff mbox series

Patch

diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
index e6377ec07..839930764 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
@@ -74,28 +74,28 @@  static MPT_CALLBACK	mpt_callbacks[MPT_MAX_CALLBACKS];
 #define MAX_HBA_QUEUE_DEPTH	30000
 #define MAX_CHAIN_DEPTH		100000
 static int max_queue_depth = -1;
-module_param(max_queue_depth, int, 0);
+module_param(max_queue_depth, int, 0444);
 MODULE_PARM_DESC(max_queue_depth, " max controller queue depth ");
 
 static int max_sgl_entries = -1;
-module_param(max_sgl_entries, int, 0);
+module_param(max_sgl_entries, int, 0444);
 MODULE_PARM_DESC(max_sgl_entries, " max sg entries ");
 
 static int msix_disable = -1;
-module_param(msix_disable, int, 0);
+module_param(msix_disable, int, 0444);
 MODULE_PARM_DESC(msix_disable, " disable msix routed interrupts (default=0)");
 
 static int smp_affinity_enable = 1;
-module_param(smp_affinity_enable, int, S_IRUGO);
+module_param(smp_affinity_enable, int, 0444);
 MODULE_PARM_DESC(smp_affinity_enable, "SMP affinity feature enable/disable Default: enable(1)");
 
 static int max_msix_vectors = -1;
-module_param(max_msix_vectors, int, 0);
+module_param(max_msix_vectors, int, 0444);
 MODULE_PARM_DESC(max_msix_vectors,
 	" max msix vectors");
 
 static int irqpoll_weight = -1;
-module_param(irqpoll_weight, int, 0);
+module_param(irqpoll_weight, int, 0444);
 MODULE_PARM_DESC(irqpoll_weight,
 	"irq poll weight (default= one fourth of HBA queue depth)");
 
@@ -104,7 +104,7 @@  MODULE_PARM_DESC(mpt3sas_fwfault_debug,
 	" enable detection of firmware fault and halt firmware - (default=0)");
 
 static int perf_mode = -1;
-module_param(perf_mode, int, 0);
+module_param(perf_mode, int, 0444);
 MODULE_PARM_DESC(perf_mode,
 	"Performance mode (only for Aero/Sea Generation), options:\n\t\t"
 	"0 - balanced: high iops mode is enabled &\n\t\t"
diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
index 1f6aa8b19..27c731a3f 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
@@ -113,22 +113,22 @@  MODULE_PARM_DESC(logging_level,
 
 
 static ushort max_sectors = 0xFFFF;
-module_param(max_sectors, ushort, 0);
+module_param(max_sectors, ushort, 0444);
 MODULE_PARM_DESC(max_sectors, "max sectors, range 64 to 32767  default=32767");
 
 
 static int missing_delay[2] = {-1, -1};
-module_param_array(missing_delay, int, NULL, 0);
+module_param_array(missing_delay, int, NULL, 0444);
 MODULE_PARM_DESC(missing_delay, " device missing delay , io missing delay");
 
 /* scsi-mid layer global parmeter is max_report_luns, which is 511 */
 #define MPT3SAS_MAX_LUN (16895)
 static u64 max_lun = MPT3SAS_MAX_LUN;
-module_param(max_lun, ullong, 0);
+module_param(max_lun, ullong, 0444);
 MODULE_PARM_DESC(max_lun, " max lun, default=16895 ");
 
 static ushort hbas_to_enumerate;
-module_param(hbas_to_enumerate, ushort, 0);
+module_param(hbas_to_enumerate, ushort, 0444);
 MODULE_PARM_DESC(hbas_to_enumerate,
 		" 0 - enumerates both SAS 2.0 & SAS 3.0 generation HBAs\n \
 		  1 - enumerates only SAS 2.0 generation HBAs\n \
@@ -142,17 +142,17 @@  MODULE_PARM_DESC(hbas_to_enumerate,
  * Either bit can be set, or both
  */
 static int diag_buffer_enable = -1;
-module_param(diag_buffer_enable, int, 0);
+module_param(diag_buffer_enable, int, 0444);
 MODULE_PARM_DESC(diag_buffer_enable,
 	" post diag buffers (TRACE=1/SNAPSHOT=2/EXTENDED=4/default=0)");
 static int disable_discovery = -1;
-module_param(disable_discovery, int, 0);
+module_param(disable_discovery, int, 0444);
 MODULE_PARM_DESC(disable_discovery, " disable discovery ");
 
 
 /* permit overriding the host protection capabilities mask (EEDP/T10 PI) */
 static int prot_mask = -1;
-module_param(prot_mask, int, 0);
+module_param(prot_mask, int, 0444);
 MODULE_PARM_DESC(prot_mask, " host protection capabilities mask, def=7 ");