| Message ID | c30f0e497f9e8bddc32e31a22f00ae7757e3d24e.1559024737.git.leonard.crestez@nxp.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [RESEND] PCI: Kconfig: Simplify PCI_IMX6 depends on | expand |
On Tue, May 28, 2019 at 5:06 AM Leonard Crestez <leonard.crestez@nxp.com> wrote: > > This driver can be used on imx6sx without enabling support for > imx6q or imx7d but the "depends on" condition doesn't allow that. > > Instead of making the condition even longer just drop the per-soc > defines and make it depend on "ARCH_MXC || COMPILE_TEST" instead, > similar to many other drivers. > > Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> Tested-by: Fabio Estevam <festevam@gmail.com> I have also noticed this issue and sent the same fix as I haven't seen this patch earlier. Thanks
Hi Lucas, On Tue, May 28, 2019 at 8:35 AM Fabio Estevam <festevam@gmail.com> wrote: > > On Tue, May 28, 2019 at 5:06 AM Leonard Crestez <leonard.crestez@nxp.com> wrote: > > > > This driver can be used on imx6sx without enabling support for > > imx6q or imx7d but the "depends on" condition doesn't allow that. > > > > Instead of making the condition even longer just drop the per-soc > > defines and make it depend on "ARCH_MXC || COMPILE_TEST" instead, > > similar to many other drivers. > > > > Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> > > Tested-by: Fabio Estevam <festevam@gmail.com> > > I have also noticed this issue and sent the same fix as I haven't seen > this patch earlier. A gentle ping. Thanks
Am Dienstag, den 28.05.2019, 08:06 +0000 schrieb Leonard Crestez: > This driver can be used on imx6sx without enabling support for > imx6q or imx7d but the "depends on" condition doesn't allow that. > > Instead of making the condition even longer just drop the per-soc > defines and make it depend on "ARCH_MXC || COMPILE_TEST" instead, > similar to many other drivers. > > Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> Urgh, sorry I thought I had done this long time ago: Acked-by: Lucas Stach <l.stach@pengutronix.de> > --- > drivers/pci/controller/dwc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Link to v1: https://patchwork.kernel.org/patch/10848143/ > > No objections were raised other than a request for Lucas to Ack the > patch. > > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig > index 6ea74b1c0d94..21747fd0e799 100644 > --- a/drivers/pci/controller/dwc/Kconfig > +++ b/drivers/pci/controller/dwc/Kconfig > @@ -88,11 +88,11 @@ config PCI_EXYNOS > > depends on PCI_MSI_IRQ_DOMAIN > > select PCIE_DW_HOST > > config PCI_IMX6 > > bool "Freescale i.MX6/7/8 PCIe controller" > > - depends on SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST > > + depends on ARCH_MXC || COMPILE_TEST > > depends on PCI_MSI_IRQ_DOMAIN > > select PCIE_DW_HOST > > config PCIE_SPEAR13XX > > bool "STMicroelectronics SPEAr PCIe controller"
diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig index 6ea74b1c0d94..21747fd0e799 100644 --- a/drivers/pci/controller/dwc/Kconfig +++ b/drivers/pci/controller/dwc/Kconfig @@ -88,11 +88,11 @@ config PCI_EXYNOS depends on PCI_MSI_IRQ_DOMAIN select PCIE_DW_HOST config PCI_IMX6 bool "Freescale i.MX6/7/8 PCIe controller" - depends on SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST + depends on ARCH_MXC || COMPILE_TEST depends on PCI_MSI_IRQ_DOMAIN select PCIE_DW_HOST config PCIE_SPEAR13XX bool "STMicroelectronics SPEAr PCIe controller"
This driver can be used on imx6sx without enabling support for imx6q or imx7d but the "depends on" condition doesn't allow that. Instead of making the condition even longer just drop the per-soc defines and make it depend on "ARCH_MXC || COMPILE_TEST" instead, similar to many other drivers. Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> --- drivers/pci/controller/dwc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Link to v1: https://patchwork.kernel.org/patch/10848143/ No objections were raised other than a request for Lucas to Ack the patch.