| Message ID | 20190610193215.23704-5-julien.grall@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xen/arm64: Rework head.S to make it more compliant with the Arm Arm | expand |
On Mon, 10 Jun 2019, Julien Grall wrote: > After the recent rework, the CPUID is only used at the very beginning of > the secondary CPUs boot path. So there is no need to "reserve" x24 for > he CPUID. If you are going to resend the series it would probably make sense to fold it in the previous patch, but it is also OK as is Acked-by: Stefano Stabellini <sstabellini@kernel.org> > Signed-off-by: Julien Grall <julien.grall@arm.com> > --- > xen/arch/arm/arm64/head.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index fd432ee15d..84e26582c4 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -69,7 +69,7 @@ > * x21 - DTB address (boot cpu only) > * x22 - is_secondary_cpu > * x23 - UART address > - * x24 - cpuid > + * x24 - > * x25 - identity map in place > * x26 - skip_zero_bss > * x27 - > -- > 2.11.0 >
Hi Stefano, On 26/06/2019 01:01, Stefano Stabellini wrote: > On Mon, 10 Jun 2019, Julien Grall wrote: >> After the recent rework, the CPUID is only used at the very beginning of >> the secondary CPUs boot path. So there is no need to "reserve" x24 for >> he CPUID. > > If you are going to resend the series it would probably make sense to > fold it in the previous patch, but it is also OK as is I am planning to resend the series. So I will fold it. Cheers,
diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index fd432ee15d..84e26582c4 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -69,7 +69,7 @@ * x21 - DTB address (boot cpu only) * x22 - is_secondary_cpu * x23 - UART address - * x24 - cpuid + * x24 - * x25 - identity map in place * x26 - skip_zero_bss * x27 -
After the recent rework, the CPUID is only used at the very beginning of the secondary CPUs boot path. So there is no need to "reserve" x24 for he CPUID. Signed-off-by: Julien Grall <julien.grall@arm.com> --- xen/arch/arm/arm64/head.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)