| Message ID | 20190626132335.14809-3-agruenba@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/3] iomap: don't mark the inode dirty in iomap_write_end | expand |
On Wed, Jun 26, 2019 at 03:23:35PM +0200, Andreas Gruenbacher wrote: > When we truncate a short write to have it retried, pass the truncated > length to the page_done callback instead of the full length. > > Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> Looks good: Reviewed-by: Christoph Hellwig <hch@lst.de>
On Wed, Jun 26, 2019 at 03:23:35PM +0200, Andreas Gruenbacher wrote: > When we truncate a short write to have it retried, pass the truncated > length to the page_done callback instead of the full length. > > Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> LGTM, Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> --D > --- > fs/iomap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/iomap.c b/fs/iomap.c > index 97569064faaa..9a9d016b2782 100644 > --- a/fs/iomap.c > +++ b/fs/iomap.c > @@ -803,7 +803,7 @@ iomap_write_end(struct inode *inode, loff_t pos, unsigned len, > if (old_size < pos) > pagecache_isize_extended(inode, old_size, pos); > if (page_ops && page_ops->page_done) > - page_ops->page_done(inode, pos, copied, page, iomap); > + page_ops->page_done(inode, pos, ret, page, iomap); > put_page(page); > > if (ret < len) > -- > 2.20.1 >
diff --git a/fs/iomap.c b/fs/iomap.c index 97569064faaa..9a9d016b2782 100644 --- a/fs/iomap.c +++ b/fs/iomap.c @@ -803,7 +803,7 @@ iomap_write_end(struct inode *inode, loff_t pos, unsigned len, if (old_size < pos) pagecache_isize_extended(inode, old_size, pos); if (page_ops && page_ops->page_done) - page_ops->page_done(inode, pos, copied, page, iomap); + page_ops->page_done(inode, pos, ret, page, iomap); put_page(page); if (ret < len)
When we truncate a short write to have it retried, pass the truncated length to the page_done callback instead of the full length. Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> --- fs/iomap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)