| Message ID | 20190623121630.17945-8-vadimp@mellanox.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | platform/x86: mlx-platform: init flow amendments and support for new attributes | expand |
On Sun, Jun 23, 2019 at 3:16 PM Vadim Pasternak <vadimp@mellanox.com> wrote: > > Remove duplicated attribute ‘jtag_en’, add instead missed attribute > ‘cpld3_version’. > This one doesn't apply. > Fixes: 52675da1d087f ("Documentation/ABI: Add new attribute for mlxreg-io sysfs interfaces") > Signed-off-by: Vadim Pasternak <vadimp@mellanox.com> > --- > Documentation/ABI/stable/sysfs-driver-mlxreg-io | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/ABI/stable/sysfs-driver-mlxreg-io b/Documentation/ABI/stable/sysfs-driver-mlxreg-io > index 8ca498447aeb..54202975ac3b 100644 > --- a/Documentation/ABI/stable/sysfs-driver-mlxreg-io > +++ b/Documentation/ABI/stable/sysfs-driver-mlxreg-io > @@ -29,7 +29,7 @@ Description: This file shows the system fans direction: > > The files are read only. > > -What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/jtag_enable > +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/cpld3_version > > Date: November 2018 > KernelVersion: 5.0 > -- > 2.11.0 >
> -----Original Message----- > From: Andy Shevchenko <andy.shevchenko@gmail.com> > Sent: Saturday, June 29, 2019 5:20 PM > To: Vadim Pasternak <vadimp@mellanox.com> > Cc: Darren Hart <dvhart@infradead.org>; Platform Driver <platform-driver- > x86@vger.kernel.org> > Subject: Re: [PATCH v1 platform-next 7/7] Documentation/ABI: Fix duplicated > attribute for mlxreg-io sysfs interfaces > > On Sun, Jun 23, 2019 at 3:16 PM Vadim Pasternak <vadimp@mellanox.com> > wrote: > > > > Remove duplicated attribute ‘jtag_en’, add instead missed attribute > > ‘cpld3_version’. > > > > This one doesn't apply. Hi Andy, I suppose this is because [PATCH] ABI: sysfs-driver-mlxreg-io: fix the what fields was not applied to for-next. Could it be applied before [PATCH v1 platform-next 7/7] Documentation/ABI: Fix duplicated attribute for mlxreg-io sysfs interfaces Or 7/7 just could be removed from the patchset, and I'll re-submit it after ' ABI: sysfs-driver-mlxreg-io: fix the what fields' will be in? Thanks, Vadim. > > > Fixes: 52675da1d087f ("Documentation/ABI: Add new attribute for > > mlxreg-io sysfs interfaces") > > Signed-off-by: Vadim Pasternak <vadimp@mellanox.com> > > --- > > Documentation/ABI/stable/sysfs-driver-mlxreg-io | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/ABI/stable/sysfs-driver-mlxreg-io > > b/Documentation/ABI/stable/sysfs-driver-mlxreg-io > > index 8ca498447aeb..54202975ac3b 100644 > > --- a/Documentation/ABI/stable/sysfs-driver-mlxreg-io > > +++ b/Documentation/ABI/stable/sysfs-driver-mlxreg-io > > @@ -29,7 +29,7 @@ Description: This file shows the system fans direction: > > > > The files are read only. > > > > -What: /sys/devices/platform/mlxplat/mlxreg- > io/hwmon/hwmon*/jtag_enable > > +What: /sys/devices/platform/mlxplat/mlxreg- > io/hwmon/hwmon*/cpld3_version > > > > Date: November 2018 > > KernelVersion: 5.0 > > -- > > 2.11.0 > > > > > -- > With Best Regards, > Andy Shevchenko
On Sat, Jun 29, 2019 at 6:37 PM Vadim Pasternak <vadimp@mellanox.com> wrote: > > -----Original Message----- > > From: Andy Shevchenko <andy.shevchenko@gmail.com> > > Sent: Saturday, June 29, 2019 5:20 PM > > To: Vadim Pasternak <vadimp@mellanox.com> > > Cc: Darren Hart <dvhart@infradead.org>; Platform Driver <platform-driver- > > x86@vger.kernel.org> > > Subject: Re: [PATCH v1 platform-next 7/7] Documentation/ABI: Fix duplicated > > attribute for mlxreg-io sysfs interfaces > > > > On Sun, Jun 23, 2019 at 3:16 PM Vadim Pasternak <vadimp@mellanox.com> > > wrote: > > > > > > Remove duplicated attribute ‘jtag_en’, add instead missed attribute > > > ‘cpld3_version’. > > > > > > > This one doesn't apply. > > Hi Andy, > > I suppose this is because > [PATCH] ABI: sysfs-driver-mlxreg-io: fix the what fields > was not applied to for-next. > > Could it be applied before > [PATCH v1 platform-next 7/7] Documentation/ABI: Fix duplicated attribute for mlxreg-io sysfs interfaces > > Or 7/7 just could be removed from the patchset, and I'll re-submit it > after ' ABI: sysfs-driver-mlxreg-io: fix the what fields' will be in? Second option sounds plausible.
diff --git a/Documentation/ABI/stable/sysfs-driver-mlxreg-io b/Documentation/ABI/stable/sysfs-driver-mlxreg-io index 8ca498447aeb..54202975ac3b 100644 --- a/Documentation/ABI/stable/sysfs-driver-mlxreg-io +++ b/Documentation/ABI/stable/sysfs-driver-mlxreg-io @@ -29,7 +29,7 @@ Description: This file shows the system fans direction: The files are read only. -What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/jtag_enable +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/cpld3_version Date: November 2018 KernelVersion: 5.0
Remove duplicated attribute ‘jtag_en’, add instead missed attribute ‘cpld3_version’. Fixes: 52675da1d087f ("Documentation/ABI: Add new attribute for mlxreg-io sysfs interfaces") Signed-off-by: Vadim Pasternak <vadimp@mellanox.com> --- Documentation/ABI/stable/sysfs-driver-mlxreg-io | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)