diff mbox series

hw/arm/virt: Add support for Cortex-A7

Message ID fc5404f7-4d1d-c28f-6e48-d8799c82acc0@web.de (mailing list archive)
State New, archived
Headers show
Series hw/arm/virt: Add support for Cortex-A7 | expand

Commit Message

Jan Kiszka June 30, 2019, 3:13 p.m. UTC 
From: Jan Kiszka <jan.kiszka@siemens.com>

No reason to deny this type.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 hw/arm/virt.c | 1 +
 1 file changed, 1 insertion(+)

--
2.16.4

Comments

Philippe Mathieu-Daudé July 1, 2019, 9:36 a.m. UTC | #1 
On 6/30/19 5:13 PM, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> No reason to deny this type.

Maybe add "As the A15, it supports the EL2/V7VE features."?

> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  hw/arm/virt.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 431e2900fd..ed009fa447 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -176,6 +176,7 @@ static const int a15irqmap[] = {
>  };
> 
>  static const char *valid_cpus[] = {
> +    ARM_CPU_TYPE_NAME("cortex-a7"),
>      ARM_CPU_TYPE_NAME("cortex-a15"),
>      ARM_CPU_TYPE_NAME("cortex-a53"),
>      ARM_CPU_TYPE_NAME("cortex-a57"),

Should we list here all cpu with arm_feature(ARM_FEATURE_V7VE | V8)? or EL2?

> --
> 2.16.4
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Peter Maydell July 1, 2019, 11:16 a.m. UTC | #2 
On Sun, 30 Jun 2019 at 16:13, Jan Kiszka <jan.kiszka@web.de> wrote:
>
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> No reason to deny this type.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  hw/arm/virt.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 431e2900fd..ed009fa447 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -176,6 +176,7 @@ static const int a15irqmap[] = {
>  };
>
>  static const char *valid_cpus[] = {
> +    ARM_CPU_TYPE_NAME("cortex-a7"),
>      ARM_CPU_TYPE_NAME("cortex-a15"),
>      ARM_CPU_TYPE_NAME("cortex-a53"),
>      ARM_CPU_TYPE_NAME("cortex-a57"),
> --



Applied to target-arm.next (with a commit message tweak
along the lines suggested by Philippe), thanks.

-- PMM
diff mbox series

Patch

diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 431e2900fd..ed009fa447 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -176,6 +176,7 @@  static const int a15irqmap[] = {
 };

 static const char *valid_cpus[] = {
+    ARM_CPU_TYPE_NAME("cortex-a7"),
     ARM_CPU_TYPE_NAME("cortex-a15"),
     ARM_CPU_TYPE_NAME("cortex-a53"),
     ARM_CPU_TYPE_NAME("cortex-a57"),