[v3,0/4] Perf uncore PMU event alias support for Hisi hip08 ARM64 platform

Message

John Garry June 28, 2019, 2:35 p.m. UTC

This patchset adds support for uncore PMU event aliasing for HiSilicon
hip08 ARM64 platform.

We can now get proper event description for uncore events for the
perf tool.

For HHA, DDRC, and L3C JSONs, we don't have all the event info yet, so
I will seek it out to update the JSONs later.

Changes to v3:
- Omit "perf pmu: Fix uncore PMU alias list for ARM64", as it has already
  been picked up
- Add comment for pmu_uncore_alias_match()

Changes to v2:
- Use strtok_r() in pmu_uncore_alias_match()
- from "sccl" from uncore aliases

John Garry (4):
  perf pmu: Support more complex PMU event aliasing
  perf jevents: Add support for Hisi hip08 DDRC PMU aliasing
  perf jevents: Add support for Hisi hip08 HHA PMU aliasing
  perf jevents: Add support for Hisi hip08 L3C PMU aliasing

 .../arm64/hisilicon/hip08/uncore-ddrc.json    | 44 ++++++++++++++++
 .../arm64/hisilicon/hip08/uncore-hha.json     | 51 +++++++++++++++++++
 .../arm64/hisilicon/hip08/uncore-l3c.json     | 37 ++++++++++++++
 tools/perf/pmu-events/jevents.c               |  3 ++
 tools/perf/util/pmu.c                         | 46 +++++++++++++++--
 5 files changed, 176 insertions(+), 5 deletions(-)
 create mode 100644 tools/perf/pmu-events/arch/arm64/hisilicon/hip08/uncore-ddrc.json
 create mode 100644 tools/perf/pmu-events/arch/arm64/hisilicon/hip08/uncore-hha.json
 create mode 100644 tools/perf/pmu-events/arch/arm64/hisilicon/hip08/uncore-l3c.json

Comments

Jiri Olsa June 28, 2019, 2:54 p.m. UTC | #1

On Fri, Jun 28, 2019 at 10:35:48PM +0800, John Garry wrote:
> This patchset adds support for uncore PMU event aliasing for HiSilicon
> hip08 ARM64 platform.
> 
> We can now get proper event description for uncore events for the
> perf tool.
> 
> For HHA, DDRC, and L3C JSONs, we don't have all the event info yet, so
> I will seek it out to update the JSONs later.
> 
> Changes to v3:
> - Omit "perf pmu: Fix uncore PMU alias list for ARM64", as it has already
>   been picked up
> - Add comment for pmu_uncore_alias_match()

Acked-by: Jiri Olsa <[e-mail]>

thanks,
jirka

> 
> Changes to v2:
> - Use strtok_r() in pmu_uncore_alias_match()
> - from "sccl" from uncore aliases
> 
> John Garry (4):
>   perf pmu: Support more complex PMU event aliasing
>   perf jevents: Add support for Hisi hip08 DDRC PMU aliasing
>   perf jevents: Add support for Hisi hip08 HHA PMU aliasing
>   perf jevents: Add support for Hisi hip08 L3C PMU aliasing
> 
>  .../arm64/hisilicon/hip08/uncore-ddrc.json    | 44 ++++++++++++++++
>  .../arm64/hisilicon/hip08/uncore-hha.json     | 51 +++++++++++++++++++
>  .../arm64/hisilicon/hip08/uncore-l3c.json     | 37 ++++++++++++++
>  tools/perf/pmu-events/jevents.c               |  3 ++
>  tools/perf/util/pmu.c                         | 46 +++++++++++++++--
>  5 files changed, 176 insertions(+), 5 deletions(-)
>  create mode 100644 tools/perf/pmu-events/arch/arm64/hisilicon/hip08/uncore-ddrc.json
>  create mode 100644 tools/perf/pmu-events/arch/arm64/hisilicon/hip08/uncore-hha.json
>  create mode 100644 tools/perf/pmu-events/arch/arm64/hisilicon/hip08/uncore-l3c.json
> 
> -- 
> 2.17.1
>

Arnaldo Carvalho de Melo July 2, 2019, 3:53 p.m. UTC | #2

Em Fri, Jun 28, 2019 at 04:54:06PM +0200, Jiri Olsa escreveu:
> On Fri, Jun 28, 2019 at 10:35:48PM +0800, John Garry wrote:
> > This patchset adds support for uncore PMU event aliasing for HiSilicon
> > hip08 ARM64 platform.
> > 
> > We can now get proper event description for uncore events for the
> > perf tool.
> > 
> > For HHA, DDRC, and L3C JSONs, we don't have all the event info yet, so
> > I will seek it out to update the JSONs later.
> > 
> > Changes to v3:
> > - Omit "perf pmu: Fix uncore PMU alias list for ARM64", as it has already
> >   been picked up
> > - Add comment for pmu_uncore_alias_match()
> 
> Acked-by: Jiri Olsa <[e-mail]>

Thanks, applied.

- Arnaldo