| Message ID | 20190621211346.1324-1-ezequiel@collabora.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | RK3288 Gamma LUT | expand |
Hi Heiko, On Fri, 2019-06-21 at 18:13 -0300, Ezequiel Garcia wrote: > Let's support Gamma LUT configuration on RK3288 SoCs. > > In order to do so, this series adds a new and optional > address resource. > > A separate address resource is required because on this RK3288, > the LUT address is after the MMU address, which is requested > by the iommu driver. This prevents the DRM driver > from requesting an entire register space. > > The current implementation works for RGB 10-bit tables, as that > is what seems to work on RK3288. > > This has been tested on a Rock2 Square board, using > a hacked 'modetest' tool, with legacy and atomic APIs. > > Thanks, > Eze > > Changes from v1: > * drop explicit linear LUT after finding a proper > way to disable gamma correction. > * avoid setting gamma is the CRTC is not active. > * s/int/unsigned int as suggested by Jacopo. > * only enable color management and set gamma size > if gamma LUT is supported, suggested by Doug. > * drop the reg-names usage, and instead just use indexed reg > specifiers, suggested by Doug. > > Changes from RFC: > * Request (an optional) address resource for the LUT. > * Add devicetree changes. > * Drop support for RK3399, which doesn't seem to work > out of the box and needs more research. > * Support pass-thru setting when GAMMA_LUT is NULL. > * Add a check for the gamma size, as suggested by Ilia. > * Move gamma setting to atomic_commit_tail, as pointed > out by Jacopo/Laurent, is the correct way. > > Ezequiel Garcia (3): > dt-bindings: display: rockchip: document VOP gamma LUT address > drm/rockchip: Add optional support for CRTC gamma LUT > ARM: dts: rockchip: Add RK3288 VOP gamma LUT address > > .../display/rockchip/rockchip-vop.txt | 6 +- > arch/arm/boot/dts/rk3288.dtsi | 4 +- > drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 3 + > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 114 ++++++++++++++++++ > drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 7 ++ > drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 2 + > 6 files changed, 133 insertions(+), 3 deletions(-) > Any other feedback on this series? If you are happy with the approach now, I am wondering if you can take it or if it's way too late. Thanks, Eze
Hi, On Tue, Jul 2, 2019 at 4:26 AM Ezequiel Garcia <ezequiel@collabora.com> wrote: > > Hi Heiko, > > On Fri, 2019-06-21 at 18:13 -0300, Ezequiel Garcia wrote: > > Let's support Gamma LUT configuration on RK3288 SoCs. > > > > In order to do so, this series adds a new and optional > > address resource. > > > > A separate address resource is required because on this RK3288, > > the LUT address is after the MMU address, which is requested > > by the iommu driver. This prevents the DRM driver > > from requesting an entire register space. > > > > The current implementation works for RGB 10-bit tables, as that > > is what seems to work on RK3288. > > > > This has been tested on a Rock2 Square board, using > > a hacked 'modetest' tool, with legacy and atomic APIs. > > > > Thanks, > > Eze > > > > Changes from v1: > > * drop explicit linear LUT after finding a proper > > way to disable gamma correction. > > * avoid setting gamma is the CRTC is not active. > > * s/int/unsigned int as suggested by Jacopo. > > * only enable color management and set gamma size > > if gamma LUT is supported, suggested by Doug. > > * drop the reg-names usage, and instead just use indexed reg > > specifiers, suggested by Doug. > > > > Changes from RFC: > > * Request (an optional) address resource for the LUT. > > * Add devicetree changes. > > * Drop support for RK3399, which doesn't seem to work > > out of the box and needs more research. > > * Support pass-thru setting when GAMMA_LUT is NULL. > > * Add a check for the gamma size, as suggested by Ilia. > > * Move gamma setting to atomic_commit_tail, as pointed > > out by Jacopo/Laurent, is the correct way. > > > > Ezequiel Garcia (3): > > dt-bindings: display: rockchip: document VOP gamma LUT address > > drm/rockchip: Add optional support for CRTC gamma LUT > > ARM: dts: rockchip: Add RK3288 VOP gamma LUT address > > > > .../display/rockchip/rockchip-vop.txt | 6 +- > > arch/arm/boot/dts/rk3288.dtsi | 4 +- > > drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 3 + > > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 114 ++++++++++++++++++ > > drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 7 ++ > > drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 2 + > > 6 files changed, 133 insertions(+), 3 deletions(-) I will note that I can confirm that the "gamma_test" app present on Chrome OS can be shown to work with this series, both on eDP and HDMI. I see a nice shiny RGB pattern on the screen. Thus: Tested-by: Douglas Anderson <dianders@chromium.org>
Let's support Gamma LUT configuration on RK3288 SoCs. In order to do so, this series adds a new and optional address resource. A separate address resource is required because on this RK3288, the LUT address is after the MMU address, which is requested by the iommu driver. This prevents the DRM driver from requesting an entire register space. The current implementation works for RGB 10-bit tables, as that is what seems to work on RK3288. This has been tested on a Rock2 Square board, using a hacked 'modetest' tool, with legacy and atomic APIs. Thanks, Eze Changes from v1: * drop explicit linear LUT after finding a proper way to disable gamma correction. * avoid setting gamma is the CRTC is not active. * s/int/unsigned int as suggested by Jacopo. * only enable color management and set gamma size if gamma LUT is supported, suggested by Doug. * drop the reg-names usage, and instead just use indexed reg specifiers, suggested by Doug. Changes from RFC: * Request (an optional) address resource for the LUT. * Add devicetree changes. * Drop support for RK3399, which doesn't seem to work out of the box and needs more research. * Support pass-thru setting when GAMMA_LUT is NULL. * Add a check for the gamma size, as suggested by Ilia. * Move gamma setting to atomic_commit_tail, as pointed out by Jacopo/Laurent, is the correct way. Ezequiel Garcia (3): dt-bindings: display: rockchip: document VOP gamma LUT address drm/rockchip: Add optional support for CRTC gamma LUT ARM: dts: rockchip: Add RK3288 VOP gamma LUT address .../display/rockchip/rockchip-vop.txt | 6 +- arch/arm/boot/dts/rk3288.dtsi | 4 +- drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 3 + drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 114 ++++++++++++++++++ drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 7 ++ drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 2 + 6 files changed, 133 insertions(+), 3 deletions(-)