[0/2] PCI/IOV: Resolve regression in SR-IOV VF cfg_size

Message

Alex Williamson June 13, 2019, 10:56 p.m. UTC

The commit reverted in the first patch introduced a regression where
only the first VF reports the correct config space size, subsequent VFs
report 256 bytes of config space.  Replace this in the second patch
with an assumption that all VFs support extended config space by virtue
of the SR-IOV spec requiring a PCIe capability and reachability of the
PF extended config space already being proven by the existence of the
VF.  Thanks,

Alex

---

Alex Williamson (2):
      Revert: PCI/IOV: Use VF0 cached config space size for other VFs
      PCI/IOV: Assume SR-IOV VFs support extended config space.


 drivers/pci/iov.c   |    2 --
 drivers/pci/pci.h   |    1 -
 drivers/pci/probe.c |   26 ++++++++++++--------------
 3 files changed, 12 insertions(+), 17 deletions(-)

Comments

Bjorn Helgaas July 3, 2019, 1:59 p.m. UTC | #1

On Thu, Jun 13, 2019 at 04:56:57PM -0600, Alex Williamson wrote:
> The commit reverted in the first patch introduced a regression where
> only the first VF reports the correct config space size, subsequent VFs
> report 256 bytes of config space.  Replace this in the second patch
> with an assumption that all VFs support extended config space by virtue
> of the SR-IOV spec requiring a PCIe capability and reachability of the
> PF extended config space already being proven by the existence of the
> VF.  Thanks,
> 
> Alex
> 
> ---
> 
> Alex Williamson (2):
>       Revert: PCI/IOV: Use VF0 cached config space size for other VFs
>       PCI/IOV: Assume SR-IOV VFs support extended config space.

Applied to pci/virtualization for v5.3 with Kuppuswamy's reviewed-by on
2/2, thanks!

>  drivers/pci/iov.c   |    2 --
>  drivers/pci/pci.h   |    1 -
>  drivers/pci/probe.c |   26 ++++++++++++--------------
>  3 files changed, 12 insertions(+), 17 deletions(-)