| Message ID | 20190702141207.47552-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 68092f9cf932ed894131a3b845923f4b555024ca |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [-next] carl9170: remove set but not used variable 'udev' | expand |
On Tuesday, July 2, 2019 4:12:07 PM CEST YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/wireless/ath/carl9170/usb.c: In function carl9170_usb_disconnect: > drivers/net/wireless/ath/carl9170/usb.c:1110:21: > warning: variable udev set but not used [-Wunused-but-set-variable] > > It is not use since commit feb09b293327 ("carl9170: > fix misuse of device driver API") > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Acked-by: Christian Lamparter <chunkeey@gmail.com>
YueHaibing <yuehaibing@huawei.com> wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/wireless/ath/carl9170/usb.c: In function carl9170_usb_disconnect: > drivers/net/wireless/ath/carl9170/usb.c:1110:21: > warning: variable udev set but not used [-Wunused-but-set-variable] > > It is not use since commit feb09b293327 ("carl9170: > fix misuse of device driver API") > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > Acked-by: Christian Lamparter <chunkeey@gmail.com> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. 68092f9cf932 carl9170: remove set but not used variable 'udev'
diff --git a/drivers/net/wireless/ath/carl9170/usb.c b/drivers/net/wireless/ath/carl9170/usb.c index 99f1897..486957a 100644 --- a/drivers/net/wireless/ath/carl9170/usb.c +++ b/drivers/net/wireless/ath/carl9170/usb.c @@ -1107,12 +1107,10 @@ static int carl9170_usb_probe(struct usb_interface *intf, static void carl9170_usb_disconnect(struct usb_interface *intf) { struct ar9170 *ar = usb_get_intfdata(intf); - struct usb_device *udev; if (WARN_ON(!ar)) return; - udev = ar->udev; wait_for_completion(&ar->fw_load_wait); if (IS_INITIALIZED(ar)) {
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/wireless/ath/carl9170/usb.c: In function carl9170_usb_disconnect: drivers/net/wireless/ath/carl9170/usb.c:1110:21: warning: variable udev set but not used [-Wunused-but-set-variable] It is not use since commit feb09b293327 ("carl9170: fix misuse of device driver API") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/net/wireless/ath/carl9170/usb.c | 2 -- 1 file changed, 2 deletions(-)