diff mbox series

[v2] get_maintainer: Improve patch recognition

Message ID 20190618111149.32515-1-volodymyr_babchuk@epam.com (mailing list archive)
State New, archived
Headers show
Series [v2] get_maintainer: Improve patch recognition | expand

Commit Message

Volodymyr Babchuk June 18, 2019, 11:12 a.m. UTC 
From: Joe Perches <joe@perches.com>

There are mode change and rename only patches that are unrecognized
by the get_maintainer.pl script.

Recognize them.

[ Linux commit 0455c74788fd5aad4399f00e3fbbb7e87450ca58 ]

Reported-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
CC: Julien Grall <julien.grall@arm.com>
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
---

 Changes wrt to v1:
 - Updated commit message - add Linux commit id

 scripts/get_maintainer.pl | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

Comments

Julien Grall July 7, 2019, 5:26 p.m. UTC | #1 
Hi,

On 6/18/19 12:12 PM, Volodymyr Babchuk wrote:
> From: Joe Perches <joe@perches.com>
> 
> There are mode change and rename only patches that are unrecognized
> by the get_maintainer.pl script.
> 
> Recognize them.
> 
> [ Linux commit 0455c74788fd5aad4399f00e3fbbb7e87450ca58 ]
> 
> Reported-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> CC: Julien Grall <julien.grall@arm.com>
> Signed-off-by: Joe Perches <joe@perches.com>
> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>

This looks good to me.

Acked-by: Julien Grall <julien.grall@arm.com>

Cheers,
diff mbox series

Patch

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index d528da738c..174dfb7e40 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -445,7 +445,18 @@  foreach my $file (@ARGV) {
 
 	while (<$patch>) {
 	    my $patch_line = $_;
-	    if (m/^\+\+\+\s+(\S+)/ or m/^---\s+(\S+)/) {
+	    if (m/^ mode change [0-7]+ => [0-7]+ (\S+)\s*$/) {
+		my $filename = $1;
+		push(@files, $filename);
+	    } elsif (m/^rename (?:from|to) (\S+)\s*$/) {
+		my $filename = $1;
+		push(@files, $filename);
+	    } elsif (m/^diff --git a\/(\S+) b\/(\S+)\s*$/) {
+		my $filename1 = $1;
+		my $filename2 = $2;
+		push(@files, $filename1);
+		push(@files, $filename2);
+	    } elsif (m/^\+\+\+\s+(\S+)/ or m/^---\s+(\S+)/) {
 		my $filename = $1;
 		if ($1 ne "/dev/null") { #Ignore the no-file placeholder
 		    $filename =~ s@^[^/]*/@@;