| Message ID | 20190704003615.204860-19-brendanhiggins@google.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | kunit: introduce KUnit, the Linux kernel unit testing framework | expand |
On Wed, Jul 03, 2019 at 05:36:15PM -0700, Brendan Higgins wrote: > Add entry for the new proc sysctl KUnit test to the PROC SYSCTL section. > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Reviewed-by: Logan Gunthorpe <logang@deltatee.com> > Acked-by: Luis Chamberlain <mcgrof@kernel.org> Come to think of it, I'd welcome Iurii to be added as a maintainer, with the hope Iurii would be up to review only the kunit changes. Of course if Iurii would be up to also help review future proc changes, even better. 3 pair of eyeballs is better than 2 pairs. Luis
CC'ing Iurii Zaikin On Fri, Jul 5, 2019 at 1:48 PM Luis Chamberlain <mcgrof@kernel.org> wrote: > > On Wed, Jul 03, 2019 at 05:36:15PM -0700, Brendan Higgins wrote: > > Add entry for the new proc sysctl KUnit test to the PROC SYSCTL section. > > > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Reviewed-by: Logan Gunthorpe <logang@deltatee.com> > > Acked-by: Luis Chamberlain <mcgrof@kernel.org> > > Come to think of it, I'd welcome Iurii to be added as a maintainer, > with the hope Iurii would be up to review only the kunit changes. Of > course if Iurii would be up to also help review future proc changes, > even better. 3 pair of eyeballs is better than 2 pairs. What do you think, Iurii?
I'm in. On Mon, Jul 8, 2019 at 4:16 PM Brendan Higgins <brendanhiggins@google.com> wrote: > CC'ing Iurii Zaikin > > On Fri, Jul 5, 2019 at 1:48 PM Luis Chamberlain <mcgrof@kernel.org> wrote: > > > > On Wed, Jul 03, 2019 at 05:36:15PM -0700, Brendan Higgins wrote: > > > Add entry for the new proc sysctl KUnit test to the PROC SYSCTL > section. > > > > > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > > > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > Reviewed-by: Logan Gunthorpe <logang@deltatee.com> > > > Acked-by: Luis Chamberlain <mcgrof@kernel.org> > > > > Come to think of it, I'd welcome Iurii to be added as a maintainer, > > with the hope Iurii would be up to review only the kunit changes. Of > > course if Iurii would be up to also help review future proc changes, > > even better. 3 pair of eyeballs is better than 2 pairs. > > What do you think, Iurii? >
> On Mon, Jul 8, 2019 at 4:16 PM Brendan Higgins <brendanhiggins@google.com> wrote: >> >> CC'ing Iurii Zaikin >> >> On Fri, Jul 5, 2019 at 1:48 PM Luis Chamberlain <mcgrof@kernel.org> wrote: >> > >> > On Wed, Jul 03, 2019 at 05:36:15PM -0700, Brendan Higgins wrote: >> > > Add entry for the new proc sysctl KUnit test to the PROC SYSCTL section. >> > > >> > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> >> > > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> > > Reviewed-by: Logan Gunthorpe <logang@deltatee.com> >> > > Acked-by: Luis Chamberlain <mcgrof@kernel.org> >> > >> > Come to think of it, I'd welcome Iurii to be added as a maintainer, >> > with the hope Iurii would be up to review only the kunit changes. Of >> > course if Iurii would be up to also help review future proc changes, >> > even better. 3 pair of eyeballs is better than 2 pairs. >> >> What do you think, Iurii? I'm in.
diff --git a/MAINTAINERS b/MAINTAINERS index 856a7c4f7dcf2..7b4dcae2526c6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12727,6 +12727,7 @@ S: Maintained F: fs/proc/proc_sysctl.c F: include/linux/sysctl.h F: kernel/sysctl.c +F: kernel/sysctl-test.c F: tools/testing/selftests/sysctl/ PS3 NETWORK SUPPORT