| Message ID | 20190712073554.21918-2-pagupta@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | virtio pmem: coverity fixes | expand |
On Fri, Jul 12, 2019 at 01:05:52PM +0530, Pankaj Gupta wrote: > Coverity reported memory region returns zero > for non-null value. This is because of wrong > arguments to '?:' , fixing this. > > Signed-off-by: Pankaj Gupta <pagupta@redhat.com> > --- > hw/virtio/virtio-pmem-pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> > > diff --git a/hw/virtio/virtio-pmem-pci.c b/hw/virtio/virtio-pmem-pci.c > index 8b2d0dbccc..0da6627469 100644 > --- a/hw/virtio/virtio-pmem-pci.c > +++ b/hw/virtio/virtio-pmem-pci.c > @@ -57,7 +57,7 @@ static uint64_t virtio_pmem_pci_get_plugged_size(const MemoryDeviceState *md, > MemoryRegion *mr = vpc->get_memory_region(pmem, errp); > > /* the plugged size corresponds to the region size */ > - return mr ? 0 : memory_region_size(mr); > + return mr ? memory_region_size(mr) : 0; > } > > static void virtio_pmem_pci_fill_device_info(const MemoryDeviceState *md, > -- > 2.14.5
On Fri, 12 Jul 2019 13:05:52 +0530 Pankaj Gupta <pagupta@redhat.com> wrote: > Coverity reported memory region returns zero > for non-null value. This is because of wrong > arguments to '?:' , fixing this. > > Signed-off-by: Pankaj Gupta <pagupta@redhat.com> > --- > hw/virtio/virtio-pmem-pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Cornelia Huck <cohuck@redhat.com>
On 7/12/19 9:35 AM, Pankaj Gupta wrote: > Coverity reported memory region returns zero > for non-null value. This is because of wrong > arguments to '?:' , fixing this. > Please amend: Fixes: Coverity (CID 1403009) > Signed-off-by: Pankaj Gupta <pagupta@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > hw/virtio/virtio-pmem-pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/virtio/virtio-pmem-pci.c b/hw/virtio/virtio-pmem-pci.c > index 8b2d0dbccc..0da6627469 100644 > --- a/hw/virtio/virtio-pmem-pci.c > +++ b/hw/virtio/virtio-pmem-pci.c > @@ -57,7 +57,7 @@ static uint64_t virtio_pmem_pci_get_plugged_size(const MemoryDeviceState *md, > MemoryRegion *mr = vpc->get_memory_region(pmem, errp); > > /* the plugged size corresponds to the region size */ > - return mr ? 0 : memory_region_size(mr); > + return mr ? memory_region_size(mr) : 0; > } > > static void virtio_pmem_pci_fill_device_info(const MemoryDeviceState *md, >
On 12.07.19 09:35, Pankaj Gupta wrote: > Coverity reported memory region returns zero > for non-null value. This is because of wrong > arguments to '?:' , fixing this. > > Signed-off-by: Pankaj Gupta <pagupta@redhat.com> > --- > hw/virtio/virtio-pmem-pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/virtio/virtio-pmem-pci.c b/hw/virtio/virtio-pmem-pci.c > index 8b2d0dbccc..0da6627469 100644 > --- a/hw/virtio/virtio-pmem-pci.c > +++ b/hw/virtio/virtio-pmem-pci.c > @@ -57,7 +57,7 @@ static uint64_t virtio_pmem_pci_get_plugged_size(const MemoryDeviceState *md, > MemoryRegion *mr = vpc->get_memory_region(pmem, errp); > > /* the plugged size corresponds to the region size */ > - return mr ? 0 : memory_region_size(mr); > + return mr ? memory_region_size(mr) : 0; > } > > static void virtio_pmem_pci_fill_device_info(const MemoryDeviceState *md, > Reviewed-by: David Hildenbrand <david@redhat.com>
diff --git a/hw/virtio/virtio-pmem-pci.c b/hw/virtio/virtio-pmem-pci.c index 8b2d0dbccc..0da6627469 100644 --- a/hw/virtio/virtio-pmem-pci.c +++ b/hw/virtio/virtio-pmem-pci.c @@ -57,7 +57,7 @@ static uint64_t virtio_pmem_pci_get_plugged_size(const MemoryDeviceState *md, MemoryRegion *mr = vpc->get_memory_region(pmem, errp); /* the plugged size corresponds to the region size */ - return mr ? 0 : memory_region_size(mr); + return mr ? memory_region_size(mr) : 0; } static void virtio_pmem_pci_fill_device_info(const MemoryDeviceState *md,
Coverity reported memory region returns zero for non-null value. This is because of wrong arguments to '?:' , fixing this. Signed-off-by: Pankaj Gupta <pagupta@redhat.com> --- hw/virtio/virtio-pmem-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)