| Message ID | 20190717171259.3311-8-logang@deltatee.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix nvme block test issues | expand |
On Wed, Jul 17, 2019 at 11:12:54AM -0600, Logan Gunthorpe wrote: > This test does not need to test the error message content, it's > only important that a read past the end of the file fails. Therefore, > pipe stderr of nvme-cli to /dev/null. pipe stderr of nvme-cli to $FULL Otherwise, Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
diff --git a/tests/nvme/018 b/tests/nvme/018 index e29fa92e8153..f5f5ecdb0989 100755 --- a/tests/nvme/018 +++ b/tests/nvme/018 @@ -44,9 +44,8 @@ test() { sectors="$(blockdev --getsz "/dev/${nvmedev}n1")" bs="$(blockdev --getbsz "/dev/${nvmedev}n1")" - if nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs"; then - echo "ERROR: Successfully read out of device lba range" - fi + nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" 2>"$FULL" \ + && echo "ERROR: Successfully read out of device lba range" nvme disconnect -n "${subsys_name}"
nvme-cli at some point started printing the error message: NVMe status: CAP_EXCEEDED: The execution of the command has caused the capacity of the namespace to be exceeded(0x6081) This was not accounted for by test 018 and caused it to fail. This test does not need to test the error message content, it's only important that a read past the end of the file fails. Therefore, pipe stderr of nvme-cli to /dev/null. Signed-off-by: Logan Gunthorpe <logang@deltatee.com> --- tests/nvme/018 | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)