| Message ID | 20190718225353.2078-8-denis.ciocca@st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio:st_sensors: make use of regmap API | expand |
On Thu, 18 Jul 2019 15:53:49 -0700 Denis Ciocca <denis.ciocca@st.com> wrote: > This patch set gyro settings right after probe start. This is > done in preparation of regmap that needs different configuration > based on multiread bit value. > > Signed-off-by: Denis Ciocca <denis.ciocca@st.com> Applied, Thanks, Jonathan > --- > Changes in v2: > not there in v1. > > drivers/iio/gyro/st_gyro_i2c.c | 18 ++++++++++++++---- > drivers/iio/gyro/st_gyro_spi.c | 16 +++++++++++++--- > 2 files changed, 27 insertions(+), 7 deletions(-) > > diff --git a/drivers/iio/gyro/st_gyro_i2c.c b/drivers/iio/gyro/st_gyro_i2c.c > index f2a8683db7d9..fa71e94b76f4 100644 > --- a/drivers/iio/gyro/st_gyro_i2c.c > +++ b/drivers/iio/gyro/st_gyro_i2c.c > @@ -63,19 +63,29 @@ MODULE_DEVICE_TABLE(of, st_gyro_of_match); > #endif > > static int st_gyro_i2c_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > + const struct i2c_device_id *id) > { > - struct iio_dev *indio_dev; > + const struct st_sensor_settings *settings; > struct st_sensor_data *gdata; > + struct iio_dev *indio_dev; > int err; > > + st_sensors_of_name_probe(&client->dev, st_gyro_of_match, > + client->name, sizeof(client->name)); > + > + settings = st_gyro_get_settings(client->name); > + if (!settings) { > + dev_err(&client->dev, "device name %s not recognized.\n", > + client->name); > + return -ENODEV; > + } > + > indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*gdata)); > if (!indio_dev) > return -ENOMEM; > > gdata = iio_priv(indio_dev); > - st_sensors_of_name_probe(&client->dev, st_gyro_of_match, > - client->name, sizeof(client->name)); > + gdata->sensor_settings = (struct st_sensor_settings *)settings; > > st_sensors_i2c_configure(indio_dev, client, gdata); > > diff --git a/drivers/iio/gyro/st_gyro_spi.c b/drivers/iio/gyro/st_gyro_spi.c > index 93c48248bea6..bb7082055f85 100644 > --- a/drivers/iio/gyro/st_gyro_spi.c > +++ b/drivers/iio/gyro/st_gyro_spi.c > @@ -69,18 +69,28 @@ MODULE_DEVICE_TABLE(of, st_gyro_of_match); > > static int st_gyro_spi_probe(struct spi_device *spi) > { > - struct iio_dev *indio_dev; > + const struct st_sensor_settings *settings; > struct st_sensor_data *gdata; > + struct iio_dev *indio_dev; > int err; > > + st_sensors_of_name_probe(&spi->dev, st_gyro_of_match, > + spi->modalias, sizeof(spi->modalias)); > + > + settings = st_gyro_get_settings(spi->modalias); > + if (!settings) { > + dev_err(&spi->dev, "device name %s not recognized.\n", > + spi->modalias); > + return -ENODEV; > + } > + > indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*gdata)); > if (!indio_dev) > return -ENOMEM; > > gdata = iio_priv(indio_dev); > + gdata->sensor_settings = (struct st_sensor_settings *)settings; > > - st_sensors_of_name_probe(&spi->dev, st_gyro_of_match, > - spi->modalias, sizeof(spi->modalias)); > st_sensors_spi_configure(indio_dev, spi, gdata); > > err = st_gyro_common_probe(indio_dev);
diff --git a/drivers/iio/gyro/st_gyro_i2c.c b/drivers/iio/gyro/st_gyro_i2c.c index f2a8683db7d9..fa71e94b76f4 100644 --- a/drivers/iio/gyro/st_gyro_i2c.c +++ b/drivers/iio/gyro/st_gyro_i2c.c @@ -63,19 +63,29 @@ MODULE_DEVICE_TABLE(of, st_gyro_of_match); #endif static int st_gyro_i2c_probe(struct i2c_client *client, - const struct i2c_device_id *id) + const struct i2c_device_id *id) { - struct iio_dev *indio_dev; + const struct st_sensor_settings *settings; struct st_sensor_data *gdata; + struct iio_dev *indio_dev; int err; + st_sensors_of_name_probe(&client->dev, st_gyro_of_match, + client->name, sizeof(client->name)); + + settings = st_gyro_get_settings(client->name); + if (!settings) { + dev_err(&client->dev, "device name %s not recognized.\n", + client->name); + return -ENODEV; + } + indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*gdata)); if (!indio_dev) return -ENOMEM; gdata = iio_priv(indio_dev); - st_sensors_of_name_probe(&client->dev, st_gyro_of_match, - client->name, sizeof(client->name)); + gdata->sensor_settings = (struct st_sensor_settings *)settings; st_sensors_i2c_configure(indio_dev, client, gdata); diff --git a/drivers/iio/gyro/st_gyro_spi.c b/drivers/iio/gyro/st_gyro_spi.c index 93c48248bea6..bb7082055f85 100644 --- a/drivers/iio/gyro/st_gyro_spi.c +++ b/drivers/iio/gyro/st_gyro_spi.c @@ -69,18 +69,28 @@ MODULE_DEVICE_TABLE(of, st_gyro_of_match); static int st_gyro_spi_probe(struct spi_device *spi) { - struct iio_dev *indio_dev; + const struct st_sensor_settings *settings; struct st_sensor_data *gdata; + struct iio_dev *indio_dev; int err; + st_sensors_of_name_probe(&spi->dev, st_gyro_of_match, + spi->modalias, sizeof(spi->modalias)); + + settings = st_gyro_get_settings(spi->modalias); + if (!settings) { + dev_err(&spi->dev, "device name %s not recognized.\n", + spi->modalias); + return -ENODEV; + } + indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*gdata)); if (!indio_dev) return -ENOMEM; gdata = iio_priv(indio_dev); + gdata->sensor_settings = (struct st_sensor_settings *)settings; - st_sensors_of_name_probe(&spi->dev, st_gyro_of_match, - spi->modalias, sizeof(spi->modalias)); st_sensors_spi_configure(indio_dev, spi, gdata); err = st_gyro_common_probe(indio_dev);
This patch set gyro settings right after probe start. This is done in preparation of regmap that needs different configuration based on multiread bit value. Signed-off-by: Denis Ciocca <denis.ciocca@st.com> --- Changes in v2: not there in v1. drivers/iio/gyro/st_gyro_i2c.c | 18 ++++++++++++++---- drivers/iio/gyro/st_gyro_spi.c | 16 +++++++++++++--- 2 files changed, 27 insertions(+), 7 deletions(-)